Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for GetConflictConfigurations #1872

Closed
wants to merge 1 commit into from
Closed

add test for GetConflictConfigurations #1872

wants to merge 1 commit into from

Conversation

zhyzhyzhy
Copy link

Ⅰ. Describe what this PR did

add unit-test for getConflictConfigurations

Ⅱ. Does this pull request fix one issue?

fixed issue #1759

Ⅲ. Describe how you did it

create tests for target methods

Ⅳ. Describe how to verify it

go test and everything pass

Ⅴ. Special notes for reviews

baiji group 5

@pouchrobot
Copy link
Collaborator

@zhyzhyzhy Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @zhyzhyzhy
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @zhyzhyzhy
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@zhuangqh zhuangqh closed this Jul 24, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@afc7a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1872   +/-   ##
=========================================
  Coverage          ?   56.52%           
=========================================
  Files             ?      200           
  Lines             ?    15659           
  Branches          ?        0           
=========================================
  Hits              ?     8851           
  Misses            ?     5715           
  Partials          ?     1093
Flag Coverage Δ
#critest 33.54% <ø> (?)
#integrationtest 37.65% <ø> (?)
#unittest 20.68% <ø> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants