-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1 #1873
Issue1 #1873
Conversation
Thanks for your contribution. 🍻 @YitianChen1996 |
@YitianChen1996 Thanks for your contribution. 🍻 |
We found this is your first time to contribute to Pouch, @YitianChen1996 |
ping @YitianChen1996 |
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
=========================================
Coverage ? 51.56%
=========================================
Files ? 200
Lines ? 15659
Branches ? 0
=========================================
Hits ? 8075
Misses ? 6528
Partials ? 1056
|
Ⅰ. Describe what this PR did
Add unit-test for getConflictConfigurations method which locate on daemon/config/config.go.
Ⅱ. Does this pull request fix one issue?
fixes #1759
Ⅲ. Describe how you did it
Read the function source code and understand the logic of the code,then consider all possibilities
Ⅳ. Describe how to verify it
If the input is equal to the expected output,it means passing the test.
Ⅴ. Special notes for reviews