Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1 #1873

Closed
Closed

Conversation

YitianChen1996
Copy link

Ⅰ. Describe what this PR did

Add unit-test for getConflictConfigurations method which locate on daemon/config/config.go.

Ⅱ. Does this pull request fix one issue?

fixes #1759

Ⅲ. Describe how you did it

Read the function source code and understand the logic of the code,then consider all possibilities

Ⅳ. Describe how to verify it

If the input is equal to the expected output,it means passing the test.

Ⅴ. Special notes for reviews

@pouchrobot
Copy link
Collaborator

Thanks for your contribution. 🍻 @YitianChen1996
While we thought PR TITLE could be more specific, longer than 20 chars.
Please edit this PR title instead of opening a new one.
More details, please refer to https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md

@pouchrobot
Copy link
Collaborator

@YitianChen1996 Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @YitianChen1996
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @YitianChen1996
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@zhuangqh zhuangqh closed this Jul 24, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@afc7a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1873   +/-   ##
=========================================
  Coverage          ?   51.56%           
=========================================
  Files             ?      200           
  Lines             ?    15659           
  Branches          ?        0           
=========================================
  Hits              ?     8075           
  Misses            ?     6528           
  Partials          ?     1056
Flag Coverage Δ
#critest 33.52% <ø> (?)
#integrationtest 36.4% <ø> (?)
#unittest 20.71% <ø> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for daemon/config/getConfigurations
4 participants