Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unit test for daemon/config/config.go: getConflictConfiguration… #1878

Closed
wants to merge 1 commit into from

Conversation

simonla
Copy link

@simonla simonla commented Jul 24, 2018

Ⅰ. Describe what this PR did

add unit test for daemon/config/config.go: getConflictConfigurations

Ⅱ. Does this pull request fix one issue?

fix #1759

Ⅲ. Describe how you did it

we have four cases :

  • case1: no conflict => do no thing
  • case2: slice conflict =>do no thing
  • case3: one conflict => return value which key is conflict
  • case4: multiple conflict => return each conflict value

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

We are BaiJi Term 9

@pouchrobot
Copy link
Collaborator

@simonla Thanks for your contribution. 🍻
Please sign off in each of your commits.

@pouchrobot
Copy link
Collaborator

We found this is your first time to contribute to Pouch, @simonla
👏 We really appreciate it.
Just remind that you have read the contribution guide: https://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md
If you didn't, you should do that first. If done, welcome again and please enjoy hacking! 🍻

@pouchrobot
Copy link
Collaborator

ping @simonla
Conflict happens after merging a previous commit.
Please rebase the branch against master and push it back again. Thanks a lot.

@zhuangqh zhuangqh closed this Jul 24, 2018
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@afc7a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1878   +/-   ##
========================================
  Coverage          ?   53.7%           
========================================
  Files             ?     200           
  Lines             ?   15659           
  Branches          ?       0           
========================================
  Hits              ?    8410           
  Misses            ?    6189           
  Partials          ?    1060
Flag Coverage Δ
#critest 33.57% <ø> (?)
#integrationtest 40.83% <ø> (?)
#unittest 20.53% <ø> (?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted] add unit-test for daemon/config/getConfigurations
4 participants