11039 the api should return a 401 status code when a session is invalid #11658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
solution/studio/designer
standeren
force-pushed
the
11039-the-api-should-return-a-401-status-code-when-a-session-is-invalid
branch
from
288d8e3
to
2033fcb
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mirkoSekulic
requested changes
Nov 24, 2023
There was a problem hiding this comment.
Conceptually it is not ok to change the response code of the endpoint in the delegating handler that is used to call third-party service.
Just curious, when we're getting the invalid session? Seems like we're solving the issue for gitea session since solution lies in the delegating handler. Are we trying to solve the problem when user logs in from, for example 2 browsers?
…rom source control fetch remote changes method
standeren
force-pushed
the
11039-the-api-should-return-a-401-status-code-when-a-session-is-invalid
branch
from
416ee29
to
9168884
Compare
standeren
force-pushed
the
11039-the-api-should-return-a-401-status-code-when-a-session-is-invalid
branch
from
f873e70
to
1206f0f
Compare
backend/src/Designer/Services/Implementation/SourceControlLoggingDecorator.cs
Outdated
Show resolved
Hide resolved
mirkoSekulic
approved these changes
Nov 28, 2023
standeren
force-pushed
the
11039-the-api-should-return-a-401-status-code-when-a-session-is-invalid
branch
from
91818f3
to
b602ab5
Compare
standeren
deleted the
11039-the-api-should-return-a-401-status-code-when-a-session-is-invalid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a custom 401 delegation handler on the http client for the gitea service. The custom delegation handler checks if the response from the underlying gitea api is 401 when the appKeyToken is no longer valid and deletes all cookies.
Related Issue(s)
Verification