-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize PR checks #12636
Closed
Closed
Optimize PR checks #12636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
skip-releasenotes
Issues that do not make sense to list in our release notes
label
Apr 8, 2024
Will be solved by #13032 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/app-deploy
Area: Related to deploying apps from Altinn Studio to Altinn Apps.
area/dashboard
Area: Related to the dashboard
skip-releasenotes
Issues that do not make sense to list in our release notes
solution/studio/designer
Issues related to the Altinn Studio Designer solution.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Optimization of PR checks to reduce execution time and decrease resource consumption.
build-image-on-pr.yaml
workflow as Docker images are already built by Playwright testsBuilding
job fromfrontend-unit-tests.yml
workflow as the solution is already built by Playwright testsBuild all images
job fromrun-playwright-on-pr.yaml
as the solution is already built during setupStop compose file
job fromrun-playwright-on-pr.yaml
as it's already stopped when the VM is stoppeddotnet build
fromDockerfile
as the backend is already built bydotnet publish
typecheck
command to prevent it from running multiple times. This is a quick fix, we should fix thetsconfig.json
files to make them work per workspace (see: Fix typecheck command #13031)Dockerfile
layer caching by separating the copying ofpackage.json
andyarn.lock
filesrun-playwright-on-pr.yaml
to stop previous running instances--cache
flag to the eslint command to only check changed files--changedSince
flag to the Jest command to only run tests impacted by changes in a PRWe still run all the tests when merging a PR into main, as it seems that sometimes this command does not execute all the impacted files.
PR checks
Docker layer caching
Related Issue(s)
Verification