Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here is the list of optimizations made on PR checks:
build-image-on-pr.yaml
workflow since Docker images are already built by Playwright testsBuilding
job fromfrontend-unit-tests.yml
workflow as the solution is already built by Playwright testsBuild all images
job fromrun-playwright-on-pr.yaml
since the solution is already built during setupStop compose file
job fromrun-playwright-on-pr.yaml
as it's already stopped when the VM is stoppeddotnet build
fromDockerfile
as the backend is already built bydotnet publish
typecheck
command to prevent it from running multiple times. This is a quick fix, we should fix thetsconfig.json
files to make thetypecheck
command work per workspace (see: Fix typecheck command #13031)Dockerfile
layer caching by separating the copying ofpackage.json
andyarn.lock
filesrun-playwright-on-pr.yaml
to stop previous running instances--cache
flag to the eslint command to only check changed files--changedSince
flag to the Jest command to only run tests impacted by changes in a PRWe still run all the tests when merging a PR into main, as it seems that sometimes this command does not execute all the impacted files.
There are more optimizations that can be made, particularly regarding caching during the installation of Playwright, but this requires more work, so I have created a separate issue for that (see: #13028).
PR checks
Docker layer caching
Related Issue(s)
Verification