Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup static files #13254

Merged
merged 26 commits into from
Aug 21, 2024
Merged

Cleanup static files #13254

merged 26 commits into from
Aug 21, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Jul 30, 2024 •
edited
Loading

Description

  • Removed duplicated and unused static files
  • Cleaned up nginx and compose configurations
  • Removed fortawesome, fontawesome and bootstrap
  • Created a common layout (_Layout.cshtml) for all pages (dashboard, app-development, app-preview, studio-root, resourceadm and start page)

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added area/dashboard Area: Related to the dashboard solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes area/studio-root labels Jul 30, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (681c093) to head (c14439b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13254   +/-   ##
=======================================
  Coverage   93.71%   93.72%           
=======================================
  Files        1438     1438           
  Lines       19927    19919    -8     
  Branches     2417     2417           
=======================================
- Hits        18675    18669    -6     
+ Misses       1004     1002    -2     
  Partials      248      248

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlqn mlqn changed the title Cleanup Cleanup static files Jul 31, 2024
@mlqn mlqn self-assigned this Jul 31, 2024
@mlqn mlqn mentioned this pull request Aug 12, 2024
Closed
@mlqn mlqn linked an issue Aug 12, 2024 that may be closed by this pull request
Cleanup static files #11614
Closed
@github-actions github-actions bot added the kind/dependencies Used for issues or pull requests that are dependency updates label Aug 16, 2024
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. labels Aug 18, 2024
@mlqn mlqn marked this pull request as ready for review August 18, 2024 14:53
@mlqn mlqn linked an issue Aug 18, 2024 that may be closed by this pull request
Remove unused frontend assets in Altinn Studio backend #10072
Closed
TomasEng
TomasEng approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@TomasEng TomasEng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastisk opprydning. Regner med at filen startpage.css inneholder ting du har slettet andre steder. Vi kan nok slette det aller meste her, kanskje alt, men la oss gjøre det som en separat oppgave. Da blir det lettere å finne årsaken hvis vi skulle oppdage at noe mangler.

backend/src/Designer/wwwroot/designer/css/startpage.css Show resolved Hide resolved
mirkoSekulic
mirkoSekulic approved these changes Aug 19, 2024
View reviewed changes
Copy link
Collaborator

@mirkoSekulic mirkoSekulic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🚀

@mirkoSekulic
Copy link
Collaborator

Tested ok in dev.

@mirkoSekulic mirkoSekulic merged commit 6d04a39 into main Aug 21, 2024
22 checks passed
@mirkoSekulic mirkoSekulic deleted the chore/cleanup branch August 21, 2024 10:47
@mlqn mlqn mentioned this pull request Aug 26, 2024
Closed
@mlqn mlqn mentioned this pull request Sep 12, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkoSekulic mirkoSekulic mirkoSekulic approved these changes

@TomasEng TomasEng TomasEng approved these changes

Assignees

@mlqn mlqn

Labels
added-to-sprint area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/dashboard Area: Related to the dashboard area/studio-root area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cleanup static files Remove unused frontend assets in Altinn Studio backend
3 participants
@mlqn @mirkoSekulic @TomasEng