Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed designer prefix #13379

Closed
wants to merge 31 commits into from
Closed

Removed designer prefix #13379

wants to merge 31 commits into from

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Aug 17, 2024

Description

  • Removed the /designer prefix from all frontend and backend paths at it does not seem to serve any purpose. 🤷‍♂️
  • Removed unused /designerapi and /Home aliases
  • Moved frontend files from /wwwroot/designer/frontend/ to /wwwroot/ since wwwroot only contain frontend files

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@mlqn mlqn changed the title Remove designer prefix Removed designer prefix Aug 17, 2024
@github-actions github-actions bot added area/dashboard Area: Related to the dashboard area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes kind/dependencies Used for issues or pull requests that are dependency updates area/studio-root labels Aug 17, 2024
Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.74%. Comparing base (957f1cb) to head (9e33f64).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13379   +/-   ##
=======================================
  Coverage   93.74%   93.74%           
=======================================
  Files        1446     1446           
  Lines       20030    20030           
  Branches     2429     2429           
=======================================
  Hits        18778    18778           
  Misses       1004     1004           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. label Aug 20, 2024
@mlqn
Copy link
Contributor Author

mlqn commented Sep 12, 2024

I'm closing this PR and converting it to an issue as it's not a priority and it would require more work.
This PR only had a couple of simple commits; the others come from #13254, which has already been merged.

@mlqn mlqn closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/app-deploy Area: Related to deploying apps from Altinn Studio to Altinn Apps. area/dashboard Area: Related to the dashboard area/studio-root area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant