Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jumpy behavior on Info Popover in lage page #13415

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fix jumpy behavior on Info Popover in lage page #13415

merged 2 commits into from
Aug 27, 2024

Conversation

lassopicasso
Copy link
Contributor

@lassopicasso lassopicasso commented Aug 22, 2024 •
edited
Loading

Description

Added a portal prop to the popover in InformationPanelComponent.tsx to prevent it from being overridden by the container's styling.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso linked an issue Aug 22, 2024 that may be closed by this pull request
Fix "jumpy" behaviour in Popover on "lage" page #13218
Closed
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Aug 22, 2024
@lassopicasso lassopicasso marked this pull request as ready for review August 22, 2024 08:54
JamalAlabdullah
JamalAlabdullah approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTOM👍

@JamalAlabdullah JamalAlabdullah merged commit 0d961fe into main Aug 27, 2024
14 checks passed
@JamalAlabdullah JamalAlabdullah deleted the fix-jumpy-behaviour-on-info-popover branch August 27, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@framitdavid framitdavid framitdavid approved these changes

@JamalAlabdullah JamalAlabdullah JamalAlabdullah approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix "jumpy" behaviour in Popover on "lage" page
3 participants
@lassopicasso @framitdavid @JamalAlabdullah