Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed Tom knapp + help text #13895

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

Ildest
Copy link
Contributor

@Ildest Ildest commented Oct 24, 2024

Description

Changed Tom knapp to Egendefinert knapp, and amended the help text. Please see information in related issues/sub-issues about how Anniken and I think we should proceed with improving the user experience of the button components.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Ildest Ildest requested a review from nkylstad October 24, 2024 06:31
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Oct 24, 2024
@Ildest Ildest linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.09%. Comparing base (e371e77) to head (6596192).
Report is 32 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13895   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files        1657     1657           
  Lines       22097    22097           
  Branches     2601     2601           
=======================================
  Hits        21014    21014           
  Misses        835      835           
  Partials      248      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ildest Ildest changed the title Changed Tom knapp + help text refactor: Changed Tom knapp + help text Oct 24, 2024
@Ildest Ildest changed the title refactor: Changed Tom knapp + help text refactor: changed "Tom knapp" + help text Oct 24, 2024
@Ildest Ildest changed the title refactor: changed "Tom knapp" + help text refactor: changed Tom knapp + help text Oct 24, 2024
Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nkylstad nkylstad added the skip-releasenotes Issues that do not make sense to list in our release notes label Oct 25, 2024
@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 4, 2024
@Ildest Ildest merged commit 3ffb639 into main Nov 5, 2024
12 checks passed
@Ildest Ildest deleted the Refactor-tom-knapp-to-egendefinert branch November 5, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change component name "Tom knapp" to "Egendefinert knapp"
3 participants