Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Inter font #1173

Merged
merged 23 commits into from
Jul 5, 2023
Merged

Switch to Inter font #1173

merged 23 commits into from
Jul 5, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented May 19, 2023

Description

The font has been switched from Altinn-DIN to Inter.

I have confirmed that it works in the PDF generation.

Preview: https://github.com/Altinn/app-frontend-react/releases/tag/v3.65.1-interpreview2

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@bjosttveit bjosttveit changed the title WIP: Switch to Inter font Switch to Inter font Jul 4, 2023
@bjosttveit bjosttveit marked this pull request as ready for review July 4, 2023 07:27
@bjosttveit bjosttveit added the kind/product-feature Pull requests containing new features label Jul 4, 2023
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 🚀 I guess it is nice to have percy back for this one. 😄

@bjosttveit
Copy link
Member Author

Well done! 🚀 I guess it is nice to have percy back for this one. 😄

Indeed 🙏

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

79.7% 79.7% Coverage
0.0% 0.0% Duplication

@bjosttveit bjosttveit merged commit 77195bd into main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change font from Altinn-DIN to Inter
2 participants