Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove link to altinn-din from app-template #184

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

tjololo
Copy link
Member

@tjololo tjololo commented Jul 19, 2023

Description

In the next release of app-frontend, the font is switched to use Inter, and this font is added directly through app-frontend's css bundle, so a link in app-template is not needed Altinn/app-frontend-react#1173. Therefore, the link to Altinn-DIN should be removed since this will no longer be used.

Related Issue(s)

Fixes #181

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@bjosttveit
Copy link
Member

FYI: the switch to Inter is not in prod yet

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tjololo tjololo requested a review from bjosttveit July 20, 2023 07:18
@tjololo
Copy link
Member Author

tjololo commented Jul 20, 2023

Setting @bjosttveit as reviewer, he can approve this when the necessary changes in app-frontend is in prod

Copy link
Member

@RonnyB71 RonnyB71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕹️

@RonnyB71
Copy link
Member

RonnyB71 commented Aug 8, 2023

Setting @bjosttveit as reviewer, he can approve this when the necessary changes in app-frontend is in prod

Missed the comment and approved, but still valid as I'm just a poor backender :-D

Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tjololo tjololo merged commit e89898b into main Aug 15, 2023
7 checks passed
@tjololo tjololo deleted the feature/181-remove-altinn-din-link branch August 15, 2023 10:53
tjololo added a commit that referenced this pull request Aug 16, 2023
tjololo added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove link to Altinn-DIN font
3 participants