Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression validation #1540

Merged
merged 32 commits into from
Oct 9, 2023
Merged

Expression validation #1540

merged 32 commits into from
Oct 9, 2023

Conversation

bjosttveit
Copy link
Member

@bjosttveit bjosttveit commented Oct 4, 2023

Description

Validation using expressions. This feature requires app-lib v8, see: Altinn/app-lib-dotnet#311.

  • Fetches validation config <dataType>.validation.json from app backend.
  • Runs expression validations along side other types of validations.
  • Added argv expression to get positional arguments passed to an expression. (used to get the dataModel field the validation is for)

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@bjosttveit bjosttveit marked this pull request as ready for review October 4, 2023 11:36
@bjosttveit bjosttveit added the kind/product-feature Pull requests containing new features label Oct 4, 2023
@bjosttveit bjosttveit force-pushed the expression-validation branch from 0b8118f to aedebf8 Compare October 4, 2023 12:11
@bjosttveit bjosttveit added the kind/breaking-change Issue/pull request containing a breaking change label Oct 5, 2023
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a mean, clean-coding machine, @bjosttveit! 🙌 🤩 🥳 Well done!!

schemas/json/layout/expression.schema.v1.json Outdated Show resolved Hide resolved
src/hooks/queries/useCustomValidationConfig.ts Outdated Show resolved Hide resolved
src/utils/validation/expressionValidation.ts Show resolved Hide resolved
test/e2e/pageobjects/app-frontend.ts Show resolved Hide resolved
@lassopicasso
Copy link
Contributor

FYI: The following PR fixes the cy-test of grid; #1551

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

62.9% 62.9% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@bjosttveit bjosttveit merged commit 5c91390 into main Oct 9, 2023
8 of 9 checks passed
@bjosttveit bjosttveit deleted the expression-validation branch October 9, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change Issue/pull request containing a breaking change kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validering ved hjelp av dynamikk
3 participants