Expression validation #311
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| foreach (var file in files) | ||
| { | ||
| var data = File.ReadAllText(file); | ||
| ExpressionValidationTestModel testCase = JsonSerializer.Deserialize<ExpressionValidationTestModel>( | ||
| data, | ||
| new JsonSerializerOptions | ||
| { | ||
| ReadCommentHandling = JsonCommentHandling.Skip, | ||
| PropertyNamingPolicy = JsonNamingPolicy.CamelCase, | ||
| })!; | ||
| yield return new object[] { testCase }; | ||
| } |
Check notice
Code scanning / CodeQL
Missed opportunity to use Select Note test
bjosttveit
force-pushed
the
expression-validation
branch
from
0f837b9 to
ee4527a
Compare
bjosttveit
added
the
breaking-change
bjosttveit
force-pushed
the
expression-validation
branch
from
e829a24 to
b84a621
Compare
|
SonarCloud Quality Gate failed.
|
| catch | ||
| { | ||
| logger.LogError($"Error while evaluating expression validation for {resolvedField}"); | ||
| throw; |
There was a problem hiding this comment.
👍 I think throwing is the best solution. Returning a validation error tied to the data would present the user with an error he cannot do anything about, tied to a field where he possibly have provided the data.
| catch | ||
| { | ||
| logger.LogError($"Error while evaluating expression validation for {resolvedField}"); | ||
| throw; |
There was a problem hiding this comment.
Æsj, jeg burde sett dette før.
Det er lurt å sende med exception i loggen, og også gjøre meldingen parametrisk så man kan lage bedre queries i application insights.
| catch | |
| { | |
| logger.LogError($"Error while evaluating expression validation for {resolvedField}"); | |
| throw; | |
| catch(Exception e) | |
| { | |
| logger.LogError(e, "Error while evaluating expression validation for {resolvedField}", resolvedField); | |
| throw; |
There was a problem hiding this comment.
👍 nice catch, I missed that one 🙈 fix in new PR: #319
Description
ExpressionValidationis enabled inAppSettings.argvexpression for getting arguments passed to expressions. (used to get the dataModel field the validation is for)RemoveHiddenDataPreviewsetting has been replaced with:RemoveHiddenData: Removes hidden data on submitRequiredValidation: Runs required validations (will run hidden expressions first regardless of the flag above, but does not affect submission)dataModelexpression to only return "legal" values and null if it is an object or array. This logic previously only existed inJsonDataModel(used for running shared tests) and not in the regularDataModelclass. So the tests were passing while the implementation used in practice was wrong. This logic has been removed fromJsonDataModelto match the actualDataModelimplementation since other places in the code relies on getting objects and arrays from the datamodel.JsonDataModelto useJsonNodeinstead ofJsonElement.JsonNodeis mutable and was needed to be able to implementRemoveFieldfor shared testing.Related Issue(s)
Verification
Documentation