Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove link to altinn-din from app-template" #188

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

tjololo
Copy link
Member

@tjololo tjololo commented Aug 16, 2023

Change of font caused breaking changes. Reverting removal of altinn-din

@sonarcloud
Copy link

sonarcloud bot commented Aug 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ivarne
Copy link
Member

ivarne commented Jan 2, 2024

5 months? Should this be done in all apps created in that timeframe too?

@tjololo
Copy link
Member Author

tjololo commented Jan 2, 2024

5 months? Should this be done in all apps created in that timeframe too?

There has not been any releases of the template so no apps are affected by the removal

@olemartinorg
Copy link
Contributor

@bjosttveit Do we need this, or can we load the font CSS via app-frontend?

@bjosttveit
Copy link
Member

@bjosttveit Do we need this, or can we load the font CSS via app-frontend?

I would much rather have app-frontend be in control of the font, and we simply need to switch the css import from inter to altinn-din (it has its own css file with font-face definitions) and then switch the font-family. That way we wont have apps loading unecessary assets when we eventually switch to something else.

image

@tjololo
Copy link
Member Author

tjololo commented Jan 9, 2024

Removing it is fine by me, does version 3 of app-frontend load the font?
We can remove it again when we upgrade the tempate to version 4 if version 3 doesn't manage it by it self

@bjosttveit
Copy link
Member

Right, v3 does not currently load the font itself, and still relies on this being set in the template

@tjololo tjololo merged commit 53409ab into main Jan 9, 2024
7 checks passed
@tjololo tjololo deleted the revert-184-feature/181-remove-altinn-din-link branch January 9, 2024 08:04
@bjosttveit
Copy link
Member

I created a branch for changes related to frontend v4 here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants