Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 10 photos page and blissfest 2023 content #21

Merged
merged 16 commits into from
May 25, 2024
Merged

Feature/issue 10 photos page and blissfest 2023 content #21

merged 16 commits into from
May 25, 2024

Conversation

thescientist13
Copy link

@thescientist13 thescientist13 commented May 2, 2024 •
edited
Loading

Related Issue

resolves #10

Summary of Changes

  1. Add Photos link to site header
  2. Create top level /photos page / route
  3. Create Blissfest 2023 gallery page and integrate with Cloudinary
    • bumped project to Node to v20.x for built in env support 🙌

TODO

  1. Confirm Cloudinary integration in Netlify
  2. Gallery styling (Masonry layout?)
  3. refactor logic for stacking images into the masonry layout (horizontally first)
  4. nested SSR pages (and API routes) are throwing a module not found error (needs additional patch for adapters) ProjectEvergreen/greenwood#1223
  5. master rebase / fix header specs
  6. browser / device testing
  7. Perf check / asset fine tuning - photo gallery page lighthouse audit #42
  8. Update Storybook / contributing docs for Cloudinary + local dev
  9. Get Feedback
  10. Credit Photographers

Nice to have / good first issues

  1. create a media card component
  2. mix up images and videos - Photo Gallery component enhancements #39
  3. how to handle cloudinary vs uncloudinary local dev workflows (env / package.json scripts) - Photo Gallery component enhancements #39
  4. tap to zoom / enlarge - Photo Gallery component enhancements #39
  5. fade in images on load - Photo Gallery component enhancements #39
  6. media card component test cases - Media Card component test cases #40

@thescientist13 thescientist13 added documentation Improvements or additions to documentation enhancement New feature or request integration content labels May 2, 2024
@thescientist13 thescientist13 self-assigned this May 2, 2024
@thescientist13 thescientist13 added feature needs upstream and removed enhancement New feature or request labels May 2, 2024
@thescientist13 thescientist13 marked this pull request as ready for review May 2, 2024 19:26
@netlify Netlify
Copy link

netlify bot commented May 3, 2024

❌ Deploy Preview for thriving-kataifi-2b287f failed.

Name Link
🔨 Latest commit f0f0fe4
🔍 Latest deploy log https://app.netlify.com/sites/thriving-kataifi-2b287f/deploys/66356dcf77f03b000890259f

@thescientist13 thescientist13 marked this pull request as draft May 16, 2024 15:31
This was referenced May 16, 2024
Open
Closed
@thescientist13 thescientist13 force-pushed the feature/issue-10-photos-page-and-blissfest-2023-content branch from 959bce4 to cf131cf Compare May 16, 2024 19:41
@thescientist13
Copy link
Author

sweet, this trick worked for getting <video> posters to show on iOS 🥳
https://stackoverflow.com/a/65226419/417806
IMG_9406

@thescientist13 thescientist13 mentioned this pull request May 16, 2024
Open
@thescientist13 thescientist13 marked this pull request as ready for review May 16, 2024 20:37
@luminaire-dev luminaire-dev mentioned this pull request May 24, 2024
Merged
2 tasks
thescientist13
thescientist13 commented May 25, 2024
View reviewed changes
Copy link
Author

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, got feedback from folks and this looks good to go! About to land #43 and then this can go live.

@luminaire-dev @thescientist13
Fix issue #40 - Add test and stories for media card (#43)
a8da7f7 
* add test and stories for media card

* add tests to verify publicId is in the src and fix lint

* minor refactor and minor story fix

* shared mock data for specs and stories

---------

Co-authored-by: Leila Elkhalidy <leila@Leilas-MacBook-Pro.local>
Co-authored-by: Owen Buckley <owenbuckley13@gmail.com>
@thescientist13 thescientist13 merged commit 9846b65 into main May 25, 2024
5 checks passed
@thescientist13 thescientist13 deleted the feature/issue-10-photos-page-and-blissfest-2023-content branch May 25, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thescientist13 thescientist13

Labels
content documentation Improvements or additions to documentation feature integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Photo Gallery page and share photos from Blissfest 2023
2 participants
@thescientist13 @luminaire-dev