Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etcd-cpp-apiv3] Review changes for CCI #11

Conversation

uilianries
Copy link

Related to conan-io#22596

This PR is my review over the PR conan-io#22596

It's working (locally) in MacOS, both static and shared. Some notes:

  • Both protobuf and gRPC require theirs compilers (e.g. protoc) so we need to add tool_requires and buildenv
  • The cppstd is required to work in Mac, the upstream overrides the cmake definition for it
  • OpensslDIR is checked BEFORE trying to find the OpenSSL package, causing problem in Mac

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
@AndreyMlashkin AndreyMlashkin merged commit 8bc07bc into AndreyMlashkin:etcd-cpp-apiv3/initial-implementation Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants