Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[etcd-cpp-apiv3] Review changes for CCI #11

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions recipes/etcd-cpp-apiv3/all/conanfile.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from conan import ConanFile
from conan.errors import ConanInvalidConfiguration
from conan.tools.cmake import CMake, CMakeToolchain, CMakeDeps, cmake_layout
from conan.tools.files import export_conandata_patches, get, load, copy, collect_libs, rmdir
from conan.tools.files import export_conandata_patches, get, copy, rmdir
from conan.tools.env import VirtualBuildEnv, VirtualRunEnv
import os

required_conan_version = ">=1.53.0"
Expand All @@ -11,9 +11,9 @@ class EtcdCppApiv3Conan(ConanFile):
package_type = "library"
url = "https://github.com/conan-io/conan-center-index"
homepage = "https://github.com/etcd-cpp-apiv3/etcd-cpp-apiv3"
license = "etcd-cpp-apiv3"
license = "BSD-3-Clause"
description = ("C++ library for etcd's v3 client APIs, i.e., ETCDCTL_API=3.")
topics = ("etcd-cpp-apiv3", "api")
topics = ("etcd", "api", )

settings = "os", "arch", "compiler", "build_type"
options = {
Expand All @@ -25,6 +25,10 @@ class EtcdCppApiv3Conan(ConanFile):
"fPIC": True,
}

@property
def _is_legacy_one_profile(self):
return not hasattr(self, "settings_build")

def export_sources(self):
export_conandata_patches(self)

Expand All @@ -39,25 +43,32 @@ def configure(self):
def layout(self):
cmake_layout(self, src_folder="src")

def build_requirements(self):
if not self._is_legacy_one_profile:
self.tool_requires("protobuf/<host_version>")
self.tool_requires("grpc/<host_version>")

def requirements(self):
self.requires("protobuf/3.21.12")
self.requires("openssl/[>=1.1 <4]")
self.requires("grpc/1.54.3")
self.requires("cpprestsdk/2.10.19", transitive_headers=True, transitive_libs=True)

def validate(self):
if self.dependencies["grpc"].options.shared:
raise ConanInvalidConfiguration("grpc must be built as a static library")
if self.settings.os == "Macos":
raise ConanInvalidConfiguration("Recipe is not MasOs ready yet")

def source(self):
get(self, **self.conan_data["sources"][self.version],
destination=self.source_folder, strip_root=True)

def generate(self):
env = VirtualBuildEnv(self)
env.generate()
if self._is_legacy_one_profile:
env = VirtualRunEnv(self)
env.generate(scope="build")

tc = CMakeToolchain(self)
tc.variables["gRPC_VERSION"] = self.dependencies["grpc"].ref.version
tc.variables["ETCD_CMAKE_CXX_STANDARD"] = self.settings.compiler.get_safe("cppstd", "11")
tc.variables["OpenSSL_DIR"] = self.dependencies["openssl"].package_folder
tc.generate()

cmake_deps = CMakeDeps(self)
Expand All @@ -76,4 +87,3 @@ def package(self):

def package_info(self):
self.cpp_info.libs = ["etcd-cpp-api"]

Loading