Express GH shoulder reactions in glenoid coordinate system #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The glenoid shoulder reactions in "SelectedOutput" was previously expressed in the scapula coordinate system. The scapula coordinate system was slightly misalligned with glenoid surface, which caused cross talk between the: GlenoHumeral_DistractionForce, GlenoHumeral_InferoSuperiorForce, andGlenoHumeral_AnteroPosteriorForce variables. This fixes the problem by expressing the forces in the GHReactionCenterNodeRotated node.
melund
commented
Nov 11, 2022
melund
commented
Nov 16, 2022
melund
added a commit
that referenced
this pull request
Jul 27, 2023
This is a regression from chancing the way the force is expressed. #700 fixes: ab#2259
melund
added a commit
that referenced
this pull request
Aug 7, 2023
This is a regression from chancing the way the force is expressed. #700 fixes: ab#2259
melund
added a commit
that referenced
this pull request
Aug 10, 2023
* Fix SternoClavicular distraction force This is a regression from chancing the way the force is expressed. #700 fixes: ab#2259 --------- Co-authored-by: dsc <dsc@anybodytech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glenoid reaction forces are now epressed in the coordinate system of the glenoid cup instead of the general scapula coordinate system. This means that the three force variables
GlenoHumeral_DistractionForce,GlenoHumeral_InferoSuperiorForce,GlenoHumeral_AnteroPosteriorForcenow represents the three direction given by the glenoid cup.This means that the variables will be slightly different even though the force is the same.
@menzejo Does this also make sense to you?
fixes #699