Fix SternoClavicular distraction force in selected output #819
Conversation
melund
changed the title
This is a regression from chancing the way the force is expressed. #700 fixes: ab#2259
melund
force-pushed
the
gh-scapula-distraction-force
branch
from
1e9dd14
to
9d24859
Compare
|
@divyaksh-chander. I fixed the issues you found with this PR. The fix is now applied to the correct DistractionForce variable. Ready for an other review |
…revious results and comment
There was a problem hiding this comment.
I have changed the sign of Infero-Superior force on left arm to be consistent with the previous definition of inferior positive. Here is a screenshot of the reference frame in AMMR 2.4
and here is a screenshot of the reference frames in the proposed change:
.
Let me know what you think about this?
Secondly, I fixed a typo in "ResultanForce".
p.s. I don't like that our model is somewhat weaker but in the first step of the push-up model. But it's probably for another time.
There was a problem hiding this comment.
The change to ResultantForce causes the shoulder validation model to fail for an unresolved object. We could fix that model or revert this commit. @melund
|
@divyaksh-chander. No we should just change all the wrong names. I have done that and pushed a commit |
This is a regression from chancing the way the force is expressed in #700.
fixes: AB#2259