Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utt 33 turnoff ct insights #337

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

sinatragianpaolo
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jun 17, 2024

Tests difference:

New Tests

< GET /campaigns/{campaignId}/ux - draft modified - Should return status published if there are published campaign data and data are not equal to last draft

Removed Tests

> GET /campaigns/{campaignId}/ux - data - Should return all findings of a specific Campaign
> GET /campaigns/{campaignId}/ux - data - Should return all the enabled findings
> GET /campaigns/{campaignId}/ux - data - Should return all the video part in a finding
> GET /campaigns/{campaignId}/ux - data - Should return the correct ids for each finding
> GET /campaigns/{campaignId}/ux - draft modified - insight - Should return status published if there are published campaign data and data are not equal to last draft
> GET /campaigns/{campaignId}/ux - draft modified - video part - Should return status published if there are published campaign data and data are not equal to last draft
> PATCH /campaigns/{campaignId}/ux - from draft - Should add insight videopart as draft
> PATCH /campaigns/{campaignId}/ux - from draft - Should create a new version of insights on publish
> PATCH /campaigns/{campaignId}/ux - from draft - Should create a new version of videoparts on publish
> PATCH /campaigns/{campaignId}/ux - from draft - Should disable the insights as draft if the insights are not sent 
> PATCH /campaigns/{campaignId}/ux - from draft - Should insert a insights as draft if an item without id is sent
> PATCH /campaigns/{campaignId}/ux - from draft - Should insert new insight with videopart as draft
> PATCH /campaigns/{campaignId}/ux - from draft - Should remove insight videopart if empty
> PATCH /campaigns/{campaignId}/ux - from draft - Should thrown an error if trying to edit an insight that not exists
> PATCH /campaigns/{campaignId}/ux - from draft - Should update a insights as draft if an item with id is sent
> PATCH /campaigns/{campaignId}/ux - from draft - Should update insight videopart as draft
> PATCH /campaigns/{campaignId}/ux - from empty - Should insert insight as draft
> PATCH /campaigns/{campaignId}/ux - from empty - Should insert insight as draft with correct finding_id
> PATCH /campaigns/{campaignId}/ux - from empty - Should insert insight videopart as draft
> PATCH /campaigns/{campaignId}/ux - from empty - Should return 400 if inserting video part with invalid media id
> PATCH /campaigns/{campaignId}/ux - from publish - Should disable insights from the draft
> PATCH /campaigns/{campaignId}/ux - from publish - Should insert a insights in the draft
> PATCH /campaigns/{campaignId}/ux - from publish - Should insert a insights video part in the draft
> With draft only - Should not return findings of a deleted clusters
> With draft only - Should remove deleted cluster on returning findings

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 77.798% (-0.2%) from 78.039%
when pulling c740e6d on UTT-33-turnoff-ct-insights
into c730378 on develop.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 77.777% (-0.3%) from 78.039%
when pulling dc01739 on UTT-33-turnoff-ct-insights
into c730378 on develop.

@sinatragianpaolo sinatragianpaolo marked this pull request as ready for review June 19, 2024 13:24
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 78.039% (-0.3%) from 78.293%
when pulling f7c60d7 on UTT-33-turnoff-ct-insights
into d9db054 on develop.

@cannarocks cannarocks merged commit 9600feb into develop Aug 2, 2024
5 of 7 checks passed
@cannarocks cannarocks deleted the UTT-33-turnoff-ct-insights branch August 2, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants