Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utt 33 turnoff ct insights #337

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Utt 33 turnoff ct insights #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee39cdf
refactor(patch-ux): remove insights from body
sinatragianpaolo Jun 17, 2024
88a1940
feat: Remove unused code for insights in PATCH /campaigns/{campaignId…
sinatragianpaolo Jun 17, 2024
337d826
Remove unused code for insights in PATCH /campaigns/{campaignId}/ux
sinatragianpaolo Jun 18, 2024
f7c60d7
refactor(get-campaigns-campaign-ux): remove insights and videopart
sinatragianpaolo Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
293 changes: 0 additions & 293 deletions src/reference/openapi.yml
View file
Open in desktop

Large diffs are not rendered by default.

188 changes: 7 additions & 181 deletions src/routes/campaigns/campaignId/ux/UxData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,30 +23,6 @@ export default class UxData {
}
| undefined;

private _findings: {
id: number;
finding_id: number;
campaign_id: number;
version: number;
title: string;
description: string;
severity_id: number;
cluster_ids: string;
order: number;
}[] = [];

private _videoParts: {
id: number;
media_id: number;
insight_id: number;
start: number;
end: number;
description: string;
location: string;
streamUrl: string;
poster?: string;
}[] = [];

private _questions: {
id: number;
campaign_id: number;
Expand All @@ -71,19 +47,13 @@ export default class UxData {

if (!data) return { data: undefined };

const findings = await this.getFindings({ version: data.version });
const clusters = await this.getClusters();

const findingsIds = findings.map((f) => f.id);
const videoParts = findingsIds.length
? await this.getVideoParts(findingsIds)
: [];

const questions = await this.getQuestions({ version: data.version });

const sentiments = await this.getSentiments({ version: data.version });

return { data, findings, clusters, videoParts, questions, sentiments };
return { data, clusters, questions, sentiments };
}

private async getSentiments({ version }: { version: number }) {
Expand All @@ -107,27 +77,6 @@ export default class UxData {
.orderBy("version", "DESC");
}

private async getVideoParts(findingsIds: number[]) {
return await tryber.tables.UxCampaignVideoParts.do()
.select(
tryber.ref("id").withSchema("ux_campaign_video_parts"),
"media_id",
"start",
"end",
"description",
"location",
"insight_id"
)
.join(
"wp_appq_user_task_media",
"wp_appq_user_task_media.id",
"ux_campaign_video_parts.media_id"
)
.whereIn("insight_id", findingsIds)
.where("location", "like", "%.mp4")
.orderBy("order", "asc");
}

private async getUxData({ published }: { published: number }) {
return await tryber.tables.UxCampaignData.do()
.select()
Expand All @@ -152,88 +101,30 @@ export default class UxData {
.orderBy("version", "DESC");
}

private async getFindings({ version }: { version: number }) {
const result = await tryber.tables.UxCampaignInsights.do()
.select()
.where({
campaign_id: this.campaignId,
version,
})
.where({ enabled: 1 })
.orderBy("order", "asc");
return await this.filterDeletedClusters(result);
}

public async lastPublished() {
const { data, findings, clusters, videoParts, questions, sentiments } =
await this.getOne({
published: 1,
});
const { data, clusters, questions, sentiments } = await this.getOne({
published: 1,
});

if (findings) this._findings = findings;
if (clusters) this._clusters = clusters;
if (videoParts) this._videoParts = await this.verifyUrls(videoParts);
if (questions) this._questions = questions;
if (sentiments) this._sentiments = sentiments;
this._data = data;
}

public async lastDraft() {
const { data, findings, clusters, videoParts, questions, sentiments } =
await this.getOne({
published: 0,
});
const { data, clusters, questions, sentiments } = await this.getOne({
published: 0,
});

if (!data) return;
this._data = data;

if (findings) this._findings = findings;
if (clusters) this._clusters = clusters;
if (videoParts) this._videoParts = await this.verifyUrls(videoParts);
if (questions) this._questions = questions;
if (sentiments) this._sentiments = sentiments;
}

private async filterDeletedClusters(
findings: {
id: number;
finding_id: number;
campaign_id: number;
version: number;
title: string;
description: string;
severity_id: number;
cluster_ids: string;
order: number;
}[]
) {
let res = [];

// Get all cluster ids
const clusterIds = await this.getClusterIds();
//remove deleted clusters from findings
for (const f of findings) {
const fClusterIds = f.cluster_ids.split(",").map(Number);
const validClusterIds = fClusterIds.filter((c) => clusterIds.includes(c));
if (f.cluster_ids === "0") res.push(f);
else if (validClusterIds.length) {
res.push({ ...f, cluster_ids: validClusterIds.join(",") });
}
}

return res;
}

private async getClusterIds() {
const results = await tryber.tables.WpAppqUsecaseCluster.do()
.where({ campaign_id: this.campaignId })
.select("id");

if (!results.length) return [];

return results.map((c) => c.id);
}

get version() {
return this._data?.version;
}
Expand All @@ -243,49 +134,11 @@ export default class UxData {
const { id: i, version: v, published: p, ...data } = this._data;
return {
...data,

findings: this.findings,
questions: this.questions,
sentiments: this.sentiments,
};
}

get findings() {
return this._findings.map((f) => {
const severityName =
f.severity_id in this.SEVERITIES
? this.SEVERITIES[f.severity_id as keyof typeof this.SEVERITIES]
: "Unknown";

const videoParts = this._videoParts.filter((v) => v.insight_id === f.id);

return {
id: f.id,
title: f.title,
description: f.description,
clusters: evaluateClusters(this._clusters),
severity: { id: f.severity_id, name: severityName },
videoParts: videoParts.map((v) => ({
id: v.id,
start: v.start,
mediaId: v.media_id,
end: v.end,
description: v.description,
url: v.location,
streamUrl: v.streamUrl,
poster: v.poster,
})),
findingId: f.finding_id,
};

function evaluateClusters(clusters: { id: number; name: string }[]) {
if (f.cluster_ids === "0") return "all" as const;
const clusterIds = f.cluster_ids.split(",").map(Number);
return clusters.filter((c) => clusterIds.includes(c.id));
}
});
}

get questions() {
return this._questions.map((q) => ({
id: q.id,
Expand All @@ -310,33 +163,6 @@ export default class UxData {
return true;
}

async verifyUrls(
videoParts: {
id: number;
media_id: number;
insight_id: number;
start: number;
end: number;
description: string;
location: string;
}[]
) {
const video = [];
for (const v of videoParts) {
const stream = v.location.replace(".mp4", "-stream.m3u8");
const isValidStream = await checkUrl(stream);
const poster = v.location.replace(".mp4", ".0000000.jpg");
const isValidPoster = await checkUrl(poster);
video.push({
...v,
location: this.mapToDistribution(v.location),
streamUrl: isValidStream ? this.mapToDistribution(stream) : "",
poster: isValidPoster ? this.mapToDistribution(poster) : undefined,
});
}
return video;
}

private mapToDistribution(url: string) {
return mapToDistribution(url);
}
Expand Down
Loading
Loading