Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved transcript + player #391

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Improved transcript + player #391

merged 10 commits into from
Jun 11, 2024

Conversation

marcbon
Copy link
Collaborator

@marcbon marcbon commented Jun 11, 2024

No description provided.

marcbon and others added 10 commits June 10, 2024 17:33
…ponent

🔨 refactor(highlight): remove handleSelection prop usage in index.stories and index file
🔧 fix(index.stories.tsx): remove unused imports and console logs
🔧 fix(index.tsx): remove unused imports and console logs, refactor Highlight function
🎨 style(highlight): add Italian text for storytelling in index.stories.tsx

🔥 refactor(highlight): remove unnecessary code from index.stories.tsx

🔨 refactor(index.stories.tsx): refactor words array into separate variable
🔨 refactor(index.stories.tsx): remove unused WithSelectionButton component

🔨 refactor(index.stories.tsx): remove onSelectionButtonClick and i18n props from WithTooltip.args
🚀 chore(index.stories.tsx): add WithSelectionButton story with default args

🔨 refactor(highlight/index.tsx): remove unused import statement
🎨 style(highlight/index.tsx): improve color styling and z-index for better UI visualisation
…mponent

🔧 refactor(highlight): pass start and end data attributes to ActiveWord component
…e unnecessary code

🔧 chore(index.stories.tsx): add WithSearch story with search functionality
🩹 fix(controls.tsx, floatingControls.tsx): adjust height to 80px for better
@marcbon marcbon merged commit c45d349 into master Jun 11, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant