Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply ConfigureAwait(false) to inner method calls of bulk operations API #382

Merged
merged 1 commit into from
Jun 1, 2022
Merged

Apply ConfigureAwait(false) to inner method calls of bulk operations API #382

merged 1 commit into from
Jun 1, 2022

Conversation

DiscoPYF
Copy link
Collaborator

@DiscoPYF DiscoPYF commented Jun 1, 2022 •
edited
Loading

ConfigureAwait(false) should be applied at all async call levels to make sure none of them resume on a captured synchronization context.

Source: https://stackoverflow.com/a/57055739

Zyqsempai
Zyqsempai approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Zyqsempai Zyqsempai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjoubert tjoubert merged commit a490d81 into ArangoDB-Community:master Jun 1, 2022
@DiscoPYF DiscoPYF deleted the missingConfigureAwait branch June 3, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zyqsempai Zyqsempai Zyqsempai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DiscoPYF @Zyqsempai @tjoubert