Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply ConfigureAwait(false) to inner method calls of bulk operations API #382

Merged
merged 1 commit into from
Jun 1, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,10 @@ public virtual async Task<ImportDocumentsResponse> PostImportDocumentArraysAsync
var options = new ApiClientSerializationOptions(true, true);
foreach (var valueArr in body.ValueArrays)
{
sb.AppendLine(GetContentString(valueArr, options) );
sb.AppendLine(GetContentString(valueArr, options));
}
return await PostImportDocumentArraysAsync(query, sb.ToString());
return await PostImportDocumentArraysAsync(query, sb.ToString())
.ConfigureAwait(false);
}

/// <summary>
Expand Down Expand Up @@ -155,7 +156,7 @@ public virtual async Task<ImportDocumentsResponse> PostImportDocumentObjectsAsyn
{
throw new ArgumentException("body is required", nameof(body));
}

if (body.Documents == null || body.Documents.Count() < 1)
{
throw new ArgumentException("Documents is required", nameof(body.Documents));
Expand All @@ -177,7 +178,8 @@ public virtual async Task<ImportDocumentsResponse> PostImportDocumentObjectsAsyn
//body should be one array of JSON objects
sb.Append(GetContentString(body.Documents, options));
}
return await PostImportDocumentObjectsAsync(query, sb.ToString());
return await PostImportDocumentObjectsAsync(query, sb.ToString())
.ConfigureAwait(false);
}

/// <summary>
Expand Down