Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ESP32: added implementation of GPIO function #24431

Closed
wants to merge 1 commit into from

Conversation

radityankn
Copy link
Contributor

implementation of GPIO function for ESP32 HAL.
class DigitalSource and USB detection have not been implemented and currently using AP_HAL_Empty's definition

implementation of GPIO function for ESP32 HAL.
class DigitalSource and USB detection have not been implemented and currently
using AP_HAL_Empty's definition
Copy link
Collaborator

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Contributor

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needs to change HAL_ESP32_Class.cpp, changing Empty::GPIO to GPIO and declaring the GPIO class instance, then needs testing

@tridge tridge removed the DevCallEU label May 29, 2024
@davidbuzz
Copy link
Collaborator

Superceded by #28268 which was tested by its author in discord in their branch

@davidbuzz davidbuzz closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants