Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_HAL_ESP32: Add GPIO driver for ESP32 #28268

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AP_HAL_ESP32: Add GPIO driver for ESP32 #28268

wants to merge 1 commit into from
+192 −1

Conversation

sblaksono
Copy link

Add GPIO driver for ESP32

davidbuzz
davidbuzz approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@davidbuzz davidbuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs squash into a single commit, but the code changes look good

@davidbuzz davidbuzz mentioned this pull request Sep 30, 2024
Closed
@tpwrules
Copy link
Contributor

tpwrules commented Oct 1, 2024

This looks reasonable, but please rebase on master and retest. We did just merge a big upgrade to ESP-IDF 5.3 which might break it.

@sblaksono
Copy link
Author

Done merging, tested on my esp32 board. No issue...

@tpwrules
Copy link
Contributor

tpwrules commented Oct 1, 2024

Please rebase on master and squash to one commit, the project does not permit merge commits.

@sblaksono
Copy link
Author

@tpwrules done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbuzz davidbuzz davidbuzz approved these changes

Assignees
No one assigned
Labels
esp32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sblaksono @tpwrules @davidbuzz