Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add COMPOSER_MEMORY_LIMIT env variable to fix Memory Issues in T… #767

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

imagina
Copy link
Contributor

@imagina imagina commented Sep 7, 2020

…ravis CI.

@nWidart
Copy link
Member

nWidart commented Sep 8, 2020

Thank you very nice!
I'm surprised it only works on PHP 7.1 🤔

@nWidart nWidart merged commit ce7d2e1 into AsgardCms:master Sep 8, 2020
@mikemand
Copy link
Contributor

mikemand commented Sep 8, 2020

It's working for the other PHP versions too, but it looks like Travis had database issues:

  1. Modules\Menu\Tests\EloquentMenuItemRepositoryTest::it_should_create_menu_item_as_root
    Illuminate\Database\QueryException: SQLSTATE[HY000]: General error: 1 no such index: IDX_EA23F583EE35BD72 (SQL: DROP INDEX IDX_EA23F583EE35BD72)

@imagina
Copy link
Contributor Author

imagina commented Sep 9, 2020

@mikemand @nWidart I was digging in the issue and it's not Travis

Seems to be related to SQLite and PDO now failing some previously "silent" errors. Like Drop Foreign Keys and Dropping Indexes.

laravel/framework#25475

@imagina
Copy link
Contributor Author

imagina commented Sep 9, 2020

Ok, i found the issue. It's caused by a regression in doctrine/dbal. Downgrading to 2.10.2 fixes the problem at least in my test with PHP 7.2

Soon to be fixed on doctrine/dbal 2.10.4 doctrine/dbal#4243

I'll send a pull request to force the doctrine/dbal version to the last one working: 2.10.2

@imagina
Copy link
Contributor Author

imagina commented Sep 10, 2020

PR sent: #768

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants