SQLite Foreign Key Behavior BC Break #4243

taylorotwell · 2020-09-02T13:48:40Z

BC Break Report

Q	A
BC Break	yes
Version	2.10.3

Summary

A change in SQLite foreign key constraint behavior is a breaking change that was released as a patch release.

See: laravel/framework#34093

MyIgel · 2020-09-02T14:22:01Z

It looks like the regex in

dbal/lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php

Lines 126 to 139 in f69c990

    
                           $createSql !== null && preg_match_all( 
        
                               '# 
        
                               (?:CONSTRAINT\s+([^\s]+)\s+)? 
        
                               (?:FOREIGN\s+KEY[^\)]+\)\s*)? 
        
                               REFERENCES\s+[^\s]+\s+(?:\([^\)]+\))? 
        
                               (?: 
        
                                   [^,]*? 
        
                                   (NOT\s+DEFERRABLE|DEFERRABLE) 
        
                                   (?:\s+INITIALLY\s+(DEFERRED|IMMEDIATE))? 
        
                               )?#isx', 
        
                               $createSql, 
        
                               $match 
        
                           ) 
        
                       ) {

does not find what it wants:

$createSql:

CREATE TABLE "users_contact" (
    "user_id" integer not null,
    "dect" varchar null,
    "mobile" varchar null,
    "email" varchar null,
    foreign key("user_id") references "users"("id") on delete cascade on update cascade,
    primary key ("user_id")
)

$match:

array:4 [
  0 => array:1 [
    0 => "foreign key("user_id") references "users"("id") "
  ]
  1 => array:1 [
    0 => ""
  ]
  2 => array:1 [
    0 => ""
  ]
  3 => array:1 [
    0 => ""
  ]
]

MyIgel · 2020-09-02T15:18:44Z

The problem is that it creates queries like, #4244 contains example code

CONSTRAINT 0 FOREIGN KEY (user_id) REFERENCES users (id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE

The 0 value comes from getListTableForeignKeysSQL

dbal/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php

Lines 859 to 864 in f69c990

    
           public function getListTableForeignKeysSQL($table, $database = null) 
        
           { 
        
               $table = str_replace('.', '__', $table); 
        
               return sprintf('PRAGMA foreign_key_list(%s)', $this->quoteStringLiteral($table)); 
        
           }

(called in listTableForeignKeys)

dbal/lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php

Lines 119 to 120 in ce85bd8

    
           $sql              = $this->_platform->getListTableForeignKeysSQL($table, $database); 
        
           $tableForeignKeys = $this->_conn->fetchAllAssociative($sql);

$tableForeignKeys has the following format:

^ array:1 [
  0 => array:8 [
    "id" => "0"
    "seq" => "0"
    "table" => "users"
    "from" => "user_id"
    "to" => "id"
    "on_update" => "CASCADE"
    "on_delete" => "CASCADE"
    "match" => "NONE"
  ]
]

-> the id field is used as a fallback when no CONSTRAINT name is defined:

dbal/lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php

Line 151 in ce85bd8

    
           'constraint_name' => isset($names[$id]) && $names[$id] !== '' ? $names[$id] : $id,

and it's in that case the 0 which then does not get escaped

MyIgel · 2020-09-02T17:25:22Z

A solution could be to change it to null as its expected on other parts of the code #4246
or to find somehow a way to escape numbers here but thats imho not intended as there was no name configured previously

MyIgel · 2020-09-02T17:56:41Z

That one could be #4247 but it somehow does not feel that right as it adds a name where none was before

MyIgel · 2020-09-02T17:58:56Z

Any thoughts about that @taylorotwell?

greg0ire · 2020-09-02T18:06:56Z

In the list of changes since previous version, #3762 stands out as related by its title.

EDIT: I see that you found it too in the linked bug report

MyIgel · 2020-09-02T18:08:30Z

Jea, thats the change that "broke" it aka "enabled the bug" but it was already working "wrong" before it

greg0ire · 2020-09-02T18:10:15Z

Is the enabled bug also located in doctrine/dbal?

MyIgel · 2020-09-02T18:14:02Z

It is, yes

The problem is that numbers in reference constraint names are not escaped and/or that "ids" are used as names, depending on how you see it

greg0ire · 2020-09-02T18:36:25Z

@MyIgel thanks for your investigation, I edited your messages to add more links, please check I did not mess them up 🙏

@beberlei @morozov can you please take a look/recommend a solution?

greg0ire · 2020-09-02T19:55:29Z

@MyIgel the issues you looked into seem a little "late", meaning they relate to listing foreign keys, but you also reported that "it creates queries like"

CONSTRAINT 0 FOREIGN KEY (user_id) REFERENCES users (id) ON UPDATE CASCADE ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE

That sounds more interesting… is it possible that the issue is with the creation of the foreign key, as opposed to listing a table that has it? I'm not sure creating a foreign key named 0 is actually what is intended here, a stack trace would help understanding how we end with that declaration.

morozov · 2020-09-02T19:57:23Z

I'm not familiar with this change enough to propose a quick solution. Having a failing test at hand could help to understand the problem and facilitate the solution.

MyIgel · 2020-09-02T20:28:21Z

The relevant stack traces are

Creating the "interesting" constraint without escaping its name in \Doctrine\DBAL\Platforms\AbstractPlatform::getForeignKeyBaseDeclarationSQL:

#0  Doctrine\DBAL\Platforms\AbstractPlatform->getForeignKeyBaseDeclarationSQL() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php:2522]
#1  Doctrine\DBAL\Platforms\AbstractPlatform->getForeignKeyDeclarationSQL() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:320]
#2  Doctrine\DBAL\Platforms\SqlitePlatform->getForeignKeyDeclarationSQL() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:342]
#3  Doctrine\DBAL\Platforms\SqlitePlatform->_getCreateTableSQL() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php:1627]
#4  Doctrine\DBAL\Platforms\AbstractPlatform->getCreateTableSQL() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:850]
#5  Doctrine\DBAL\Platforms\SqlitePlatform->getCreateTableSQL() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php:983]
#6  Doctrine\DBAL\Platforms\SqlitePlatform->getAlterTableSQL() called at [/var/www/vendor/illuminate/database/Schema/Grammars/ChangeColumn.php:45]
#7  Illuminate\Database\Schema\Grammars\ChangeColumn::compile() called at [/var/www/vendor/illuminate/database/Schema/Grammars/Grammar.php:55]
#8  Illuminate\Database\Schema\Grammars\Grammar->compileChange() called at [/var/www/vendor/illuminate/database/Schema/Blueprint.php:128]
#9  Illuminate\Database\Schema\Blueprint->toSql() called at [/var/www/vendor/illuminate/database/Schema/Blueprint.php:101]
#10 Illuminate\Database\Schema\Blueprint->build() called at [/var/www/vendor/illuminate/database/Schema/Builder.php:290]
#11 Illuminate\Database\Schema\Builder->build() called at [/var/www/vendor/illuminate/database/Schema/Builder.php:151]
#12 Illuminate\Database\Schema\Builder->table() called at [...]

Call of Blueprint $table->string($column, $length)->change(); in a migration while running unit tests

And when getting the foreign keys from the sqlite db in \Doctrine\DBAL\Schema\SqliteSchemaManager::listTableForeignKeys:

#0  Doctrine\DBAL\Schema\SqliteSchemaManager->listTableForeignKeys() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/AbstractSchemaManager.php:276]
#1  Doctrine\DBAL\Schema\AbstractSchemaManager->listTableDetails() called at [/var/www/vendor/doctrine/dbal/lib/Doctrine/DBAL/Schema/SqliteSchemaManager.php:554]
#2  Doctrine\DBAL\Schema\SqliteSchemaManager->listTableDetails() called at [/var/www/vendor/illuminate/database/Schema/Grammars/ChangeColumn.php:61]
#3  Illuminate\Database\Schema\Grammars\ChangeColumn::getChangedDiff() called at [/var/www/vendor/illuminate/database/Schema/Grammars/ChangeColumn.php:41]
#4  Illuminate\Database\Schema\Grammars\ChangeColumn::compile() called at [/var/www/vendor/illuminate/database/Schema/Grammars/Grammar.php:55]
#5  Illuminate\Database\Schema\Grammars\Grammar->compileChange() called at [/var/www/vendor/illuminate/database/Schema/Blueprint.php:128]
#6  Illuminate\Database\Schema\Blueprint->toSql() called at [/var/www/vendor/illuminate/database/Schema/Blueprint.php:101]
#7  Illuminate\Database\Schema\Blueprint->build() called at [/var/www/vendor/illuminate/database/Schema/Builder.php:290]
#8  Illuminate\Database\Schema\Builder->build() called at [/var/www/vendor/illuminate/database/Schema/Builder.php:151]
#9  Illuminate\Database\Schema\Builder->table() called at [...]

Call of Blueprint $table->string($column, $length)->change(); in a migration while running unit tests

The important points here:

The existing sqlite table before the change has a foreign key without a name
The \Doctrine\DBAL\Schema\SqliteSchemaManager::listTableForeignKeys has a "fallback" for creating a name (when it does not find one after the CONSTRAINT keyword) which uses its "id" which is a number generated by the sqlite database (effectively "adding" one that was never there, for functionality using null here is better as its the value thats expected by other methods)
The \Doctrine\DBAL\Platforms\AbstractPlatform::getForeignKeyBaseDeclarationSQL uses $foreignKey->getQuotedName($this) but that does not escape numbers which leads us to the above 0 in the query

My two change suggestions try to fix both of the points and i can create PRs for both of them if it helps

greg0ire · 2020-09-02T20:47:09Z

Ok, I understand far better now, thanks a lot! Please do send the PRs for your suggested changes 👍

MyIgel · 2020-09-02T20:49:43Z

And here they are, also updated the links above

greg0ire · 2020-09-02T21:03:34Z

The existing sqlite table before the change has a foreign key without a name

Are newly-created FKs created without a name too?

MyIgel · 2020-09-02T21:10:13Z

Are newly-created FKs created without a name too?

As these are unit test migrations that run before every test i would say no, they have no name

hakanersu · 2020-09-02T23:41:31Z

Hi here is my call stack. I created main issue on laravel repository (laravel/framework#34093) and after re-checking my fresh installation, found that is not relevant to this problem and removed that part from main issue. I also added migration file that can be seen in call stack.

 SQLSTATE[HY000]: General error: 1 near "0": syntax error (SQL: CREATE TABLE tasks (id INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, account_id INTEGER NOT NULL, user_id INTEGER DEFAULT NULL, subject VARCHAR(255) NOT NULL COLLATE BINARY, start_date DATETIME NOT NULL, state INTEGER DEFAULT 0 NOT NULL, task_type INTEGER DEFAULT 0 NOT NULL, task_queue_id INTEGER NOT NULL, created_by_type VARCHAR(255) DEFAULT NULL COLLATE BINARY, created_by_id INTEGER DEFAULT NULL, created_at DATETIME DEFAULT NULL, updated_at DATETIME DEFAULT NULL, content CLOB DEFAULT NULL COLLATE BINARY, end_date DATETIME DEFAULT NULL, CONSTRAINT 0 FOREIGN KEY (user_id) REFERENCES users (id) ON UPDATE NO ACTION ON DELETE SET NULL NOT DEFERRABLE INITIALLY IMMEDIATE, CONSTRAINT 1 FOREIGN KEY (account_id) REFERENCES accounts (id) ON UPDATE NO ACTION ON DELETE CASCADE NOT DEFERRABLE INITIALLY IMMEDIATE))

  at vendor/laravel/framework/src/Illuminate/Database/Connection.php:671
    667|         // If an exception occurs when attempting to run a query, we'll format the error
    668|         // message to include the bindings with SQL, which will make this exception a
    669|         // lot more helpful to the developer instead of just the database's errors.
    670|         catch (Exception $e) {
  > 671|             throw new QueryException(
    672|                 $query, $this->prepareBindings($bindings), $e
    673|             );
    674|         }
    675| 

  1   vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:72
      Doctrine\DBAL\Driver\PDOException::("SQLSTATE[HY000]: General error: 1 near "0": syntax error")

  2   vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:67
      PDOException::("SQLSTATE[HY000]: General error: 1 near "0": syntax error")

  3   vendor/doctrine/dbal/lib/Doctrine/DBAL/Driver/PDOConnection.php:67
      PDO::prepare()

  4   vendor/laravel/framework/src/Illuminate/Database/Connection.php:458
      Doctrine\DBAL\Driver\PDOConnection::prepare()

  5   vendor/laravel/framework/src/Illuminate/Database/Connection.php:664
      Illuminate\Database\Connection::Illuminate\Database\{closure}()

  6   vendor/laravel/framework/src/Illuminate/Database/Connection.php:631
      Illuminate\Database\Connection::runQueryCallback()

  7   vendor/laravel/framework/src/Illuminate/Database/Connection.php:465
      Illuminate\Database\Connection::run()

  8   vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php:102
      Illuminate\Database\Connection::statement()

  9   vendor/laravel/framework/src/Illuminate/Database/Schema/Builder.php:290
      Illuminate\Database\Schema\Blueprint::build()

  10  vendor/laravel/framework/src/Illuminate/Database/Schema/Builder.php:151
      Illuminate\Database\Schema\Builder::build()

  11  vendor/laravel/framework/src/Illuminate/Support/Facades/Facade.php:261
      Illuminate\Database\Schema\Builder::table()

  12  database/migrations/2020_05_04_085002_add_nullable_to_some_fields_in_tasks_table.php:19
      Illuminate\Support\Facades\Facade::__callStatic()

  13  vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:392
      AddNullableToSomeFieldsInTasksTable::up()

  14  vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:401
      Illuminate\Database\Migrations\Migrator::Illuminate\Database\Migrations\{closure}()

  15  vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:200
      Illuminate\Database\Migrations\Migrator::runMigration()

  16  vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:165
      Illuminate\Database\Migrations\Migrator::runUp()

  17  vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:110
      Illuminate\Database\Migrations\Migrator::runPending()

  18  vendor/laravel/framework/src/Illuminate/Database/Console/Migrations/MigrateCommand.php:72
      Illuminate\Database\Migrations\Migrator::run()

  19  vendor/laravel/framework/src/Illuminate/Database/Migrations/Migrator.php:541
      Illuminate\Database\Console\Migrations\MigrateCommand::Illuminate\Database\Console\Migrations\{closure}()

  20  vendor/laravel/framework/src/Illuminate/Database/Console/Migrations/MigrateCommand.php:81
      Illuminate\Database\Migrations\Migrator::usingConnection()

  21  vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:37
      Illuminate\Database\Console\Migrations\MigrateCommand::handle()

  22  vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:37
      call_user_func_array()

  23  vendor/laravel/framework/src/Illuminate/Container/Util.php:37
      Illuminate\Container\BoundMethod::Illuminate\Container\{closure}()

  24  vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:95
      Illuminate\Container\Util::unwrapIfClosure()

  25  vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:39
      Illuminate\Container\BoundMethod::callBoundMethod()

  26  vendor/laravel/framework/src/Illuminate/Container/Container.php:596
      Illuminate\Container\BoundMethod::call()

  27  vendor/laravel/framework/src/Illuminate/Console/Command.php:134
      Illuminate\Container\Container::call()

  28  vendor/symfony/console/Command/Command.php:258
      Illuminate\Console\Command::execute()

  29  vendor/laravel/framework/src/Illuminate/Console/Command.php:121
      Symfony\Component\Console\Command\Command::run()

  30  vendor/symfony/console/Application.php:916
      Illuminate\Console\Command::run()

  31  vendor/symfony/console/Application.php:264
      Symfony\Component\Console\Application::doRunCommand()

  32  vendor/symfony/console/Application.php:140
      Symfony\Component\Console\Application::doRun()

  33  vendor/laravel/framework/src/Illuminate/Console/Application.php:93
      Symfony\Component\Console\Application::run()

  34  vendor/laravel/framework/src/Illuminate/Console/Application.php:185
      Illuminate\Console\Application::run()

  35  vendor/laravel/framework/src/Illuminate/Foundation/Console/Kernel.php:263
      Illuminate\Console\Application::call()

  36  vendor/laravel/framework/src/Illuminate/Testing/PendingCommand.php:171
      Illuminate\Foundation\Console\Kernel::call()

<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

class AddNullableToSomeFieldsInTasksTable extends Migration
{
    /**
     * Run the migrations.
     *
     * @return void
     */
    public function up()
    {
        Schema::table('tasks', function (Blueprint $table) {
            $table->text('content')->nullable()->change();
            $table->dateTime('end_date')->nullable()->change();
        });
    }

    /**
     * Reverse the migrations.
     *
     * @return void
     */
    public function down()
    {
        Schema::table('tasks', function (Blueprint $table) {
            $table->text('content')->change();
            $table->dateTime('end_date')->change();
        });
    }
}

greg0ire · 2020-09-03T06:02:06Z

Thanks for the stack trace! It shows that Laravel is calling Doctrine with an SQL query as string: https://github.com/laravel/framework/blob/caec40ed2695c2aa84b5eb195c822e3a961fc445/src/Illuminate/Database/Connection.php#L458

Where is that query built? Is it built by Blueprint, and built differently because Doctrine says SQlite supports foreign keys?

uuf6429 · 2020-09-03T08:32:59Z

Regarding General error: 1 no such index: IDX_DC8C84A116FE72E1 (SQL: DROP INDEX IDX_DC8C84A116FE72E1) (also reported here), I created a small example: https://github.com/uuf6429/doc-sqlite-poc (first run composer install and then run the test and it should fail with a similar error).

SirNarsh · 2020-09-03T09:09:04Z

For me the create table migration is not failing, but what is failing is the migration that alters table, for some reason it tries to drop an index that was not created or at least drop it with wrong name maybe? ...

The create table

CREATE TABLE "items" ("id" integer not null primary key autoincrement, "package_id" integer null, "sort" integer not null default '0', "title" varchar null, "sub_title" varchar null, "center_text" varchar null, "background_image_id" integer null, "created_by" integer null, "updated_by" integer null, "created_at" datetime null, "updated_at" datetime null, foreign key("package_id") references "packages"("id"), foreign key("background_image_id") references "images"("id"), foreign key("created_by") references "users"("id"), foreign key("updated_by") references "users"("id")

Then here the failing migration (alter table by deleting center_text column)

   Illuminate\Database\QueryException 
  SQLSTATE[HY000]: General error: 1 no such index: IDX_DC8C84A116FE72E1 (SQL: DROP INDEX IDX_DC8C84A116FE72E1)

  at vendor/laravel/framework/src/Illuminate/Database/Connection.php:671
    667|         // If an exception occurs when attempting to run a query, we'll format the error
    668|         // message to include the bindings with SQL, which will make this exception a
    669|         // lot more helpful to the developer instead of just the database's errors.
    670|         catch (Exception $e) {
  > 671|             throw new QueryException(
    672|                 $query, $this->prepareBindings($bindings), $e
    673|             );
    674|         }
    675|

I traced it down to this behaviour, but I'm not familiar really with dbal internals

-> Method getPreAlterTableIndexForeignKeySQL() -> SqllitePlatform.php (Doctrine\DBAL\Platforms\SqlitePlatform)
Gets called with different TableDiff than before

The diff $diff->fromTable->getIndexes() in new version has indexes it didn't have in 2.10.2

dumping $diff->fromTable->getIndexes() for 2.10.3
contains

array:5 [
  "primary" => Doctrine\DBAL\Schema\Index^ {#2803
    #_columns: array:1 [
      "id" => Doctrine\DBAL\Schema\Identifier^ {#2804
        #_name: "id"
        #_namespace: null
        #_quoted: false
      }
    ]
    #_isUnique: true
    #_isPrimary: true
    #_flags: []
    -options: array:1 [
      "lengths" => array:1 [
        0 => null
      ]
    ]
    #_name: "primary"
    #_namespace: null
    #_quoted: false
  }
  "idx_dc8c84a116fe72e1" => Doctrine\DBAL\Schema\Index^ {#2805
    #_columns: array:1 [
      "updated_by" => Doctrine\DBAL\Schema\Identifier^ {#2806
        #_name: "updated_by"
        #_namespace: null
        #_quoted: false
      }
    ]
    #_isUnique: false
    #_isPrimary: false
    #_flags: []
    -options: []
    #_name: "IDX_DC8C84A116FE72E1"
    #_namespace: null
    #_quoted: false
  }
  "idx_dc8c84a1de12ab56" => Doctrine\DBAL\Schema\Index^ {#2807
    #_columns: array:1 [
      "created_by" => Doctrine\DBAL\Schema\Identifier^ {#2808
        #_name: "created_by"
        #_namespace: null
        #_quoted: false
      }
    ]
    #_isUnique: false
    #_isPrimary: false
    #_flags: []
    -options: []
    #_name: "IDX_DC8C84A1DE12AB56"
    #_namespace: null
    #_quoted: false
  }
  "idx_dc8c84a1e6da28aa" => Doctrine\DBAL\Schema\Index^ {#2809
    #_columns: array:1 [
      "background_image_id" => Doctrine\DBAL\Schema\Identifier^ {#2810
        #_name: "background_image_id"
        #_namespace: null
        #_quoted: false
      }
    ]
    #_isUnique: false
    #_isPrimary: false
    #_flags: []
    -options: []
    #_name: "IDX_DC8C84A1E6DA28AA"
    #_namespace: null
    #_quoted: false
  }
  "idx_dc8c84a1445b8adf" => Doctrine\DBAL\Schema\Index^ {#2811
    #_columns: array:1 [
      "package_id" => Doctrine\DBAL\Schema\Identifier^ {#2812
        #_name: "package_id"
        #_namespace: null
        #_quoted: false
      }
    ]
    #_isUnique: false
    #_isPrimary: false
    #_flags: []
    -options: []
    #_name: "IDX_DC8C84A1445B8ADF"
    #_namespace: null
    #_quoted: false
  }
]

dumping $diff->fromTable->getIndexes() for 2.10.2
it's just the primary key

array:1 [
  "primary" => Doctrine\DBAL\Schema\Index^ {#2787
    #_columns: array:1 [
      "id" => Doctrine\DBAL\Schema\Identifier^ {#2788
        #_name: "id"
        #_namespace: null
        #_quoted: false
      }
    ]
    #_isUnique: true
    #_isPrimary: true
    #_flags: []
    -options: array:1 [
      "lengths" => array:1 [
        0 => null
      ]
    ]
    #_name: "primary"
    #_namespace: null
    #_quoted: false
  }
]

Maybe the problem (newly enabled bug) is with getPreAlterTableIndexForeignKeySQL as for all other platforms it checks first what was the removed indexes from diff, and then drop them, for Sqllite instead it drops all indexes now?
But this also doesn't answer why is it trying to drop by a name that was not used to create the index...

…r follow-up bug.

… fk with multiple columns.

…mprove other parts.

See doctrine/dbal#4243

…Case

…onalTestCase" This reverts commit 0c384b4.

…erFunctionalTestCase"" This reverts commit bf724a7.

When introducing SQLite foreign key support a case was not considered where not Doctrine DBAL is creating the schema, but some other code that is not naming foreign key constraints. This leads to triggr a bug that the code already had but was never before executed.

…n Doctrine/Dbal: doctrine/dbal#4243

…in Doctrine/Dbal: doctrine/dbal#4243

github-actions · 2022-07-28T00:22:53Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

taylorotwell mentioned this issue Sep 2, 2020

Tests broken after upgrade doctrine/dbal to 2.10.3 laravel/framework#34093

Closed

mfn mentioned this issue Sep 2, 2020

Problem changing table when run tests using in memory sqlite after upgrade on v2.10.3. #4244

Closed

This was referenced Sep 2, 2020

SQLite: Fix wrongly detected reference constraint name on schema change #4246

Merged

SQLite: Escape numbers as keywords #4247

Closed

morozov added this to the 2.10.4 milestone Sep 3, 2020

morozov added Foreign Keys Regression Schema Management SQLite labels Sep 3, 2020

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Handle sqlite foreign key without constraint_name.

f47f593

greg0ire mentioned this issue Sep 6, 2020

Workaround for laravel greg0ire/dbal#3

Closed

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Change to example with two foreign keys, fix anothe…

11e36f0

…r follow-up bug.

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Change to example with two foreign keys, fix anothe…

010f69b

…r follow-up bug.

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Address review comments and improve test example to…

0748561

… fk with multiple columns.

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Address review comments and improve test example to…

16eab09

… fk with multiple columns.

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Add comparator test showing both continue 2 work, i…

017ebfc

…mprove other parts.

beberlei added a commit to beberlei/dbal that referenced this issue Sep 6, 2020

[doctrineGH-4243] Add comparator test showing both continue 2 work, i…

f5ccf9c

…mprove other parts.

greg0ire mentioned this issue Sep 8, 2020

Carry #4256 #4262

Closed

fulopattila122 added a commit to artkonekt/address that referenced this issue Sep 9, 2020

Attempt 4 to fix recent SQLite test problem

b392841

See doctrine/dbal#4243

beberlei added a commit to beberlei/dbal that referenced this issue Sep 9, 2020

[doctrineGH-4243] Move test up to generic SchemaManagerFunctionalTest…

8f8a24a

…Case

beberlei added a commit to beberlei/dbal that referenced this issue Sep 9, 2020

[doctrineGH-4243] Move test up to generic SchemaManagerFunctionalTest…

0c384b4

…Case

beberlei added a commit to beberlei/dbal that referenced this issue Sep 9, 2020

Revert "[doctrineGH-4243] Move test up to generic SchemaManagerFuncti…

bf724a7

…onalTestCase" This reverts commit 0c384b4.

beberlei added a commit to beberlei/dbal that referenced this issue Sep 9, 2020

Revert "Revert "[doctrineGH-4243] Move test up to generic SchemaManag…

c0d5ffa

…erFunctionalTestCase"" This reverts commit bf724a7.

imagina mentioned this issue Sep 9, 2020

Fix: add COMPOSER_MEMORY_LIMIT env variable to fix Memory Issues in T… AsgardCms/Platform#767

Merged

imagina added a commit to imagina/imaginacms-platform that referenced this issue Sep 9, 2020

Fix: Issue with PHP > 7.2 Testing and Sqlite caused by a regression i…

14f4503

…n Doctrine/Dbal: doctrine/dbal#4243

imagina added a commit to imagina/imaginacms-platform that referenced this issue Sep 9, 2020

Fix: Issue with PHP >= 7.2 Testing and Sqlite caused by a regression …

3e9d85b

…in Doctrine/Dbal: doctrine/dbal#4243

imagina added a commit to imagina/imaginacms-platform that referenced this issue Sep 10, 2020

Fix: Issue with PHP >= 7.2 Testing and Sqlite caused by a regression …

f7a2bf5

…in Doctrine/Dbal: doctrine/dbal#4243

imagina mentioned this issue Sep 10, 2020

Fix: Issue with PHP >= 7.2 Testing and Sqlite caused by a regression … AsgardCms/Platform#768

Merged

imagina added a commit to imagina/imaginacms-platform that referenced this issue Sep 10, 2020

Fix: Issue with PHP >= 7.2 Testing and Sqlite caused by a regression …

077aee1

…in Doctrine/Dbal: doctrine/dbal#4243

greg0ire mentioned this issue Sep 10, 2020

Catch doctrine/persistence MappingException doctrine/orm#8264

Merged

morozov linked a pull request Sep 11, 2020 that will close this issue

Revert full support for foreign key constraints for SQLite #4255

Merged

morozov closed this as completed Sep 11, 2020

morozov self-assigned this Sep 11, 2020

greg0ire unpinned this issue Sep 11, 2020

webignition mentioned this issue Sep 23, 2020

Sqlite: what is needed to re-introduce foreign key constraint support? #4288

Closed

morozov mentioned this issue Apr 26, 2022

SQLite should properly check if foreign keys are supported and/or omit foreign key statements when a table diff is analyzed #5365

Closed

github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SQLite Foreign Key Behavior BC Break #4243

SQLite Foreign Key Behavior BC Break #4243

taylorotwell commented Sep 2, 2020

MyIgel commented Sep 2, 2020 •

edited by greg0ire

Loading

MyIgel commented Sep 2, 2020 •

edited by greg0ire

Loading

MyIgel commented Sep 2, 2020 •

edited

Loading

MyIgel commented Sep 2, 2020 •

edited

Loading

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020 •

edited

Loading

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020 •

edited

Loading

greg0ire commented Sep 2, 2020

morozov commented Sep 2, 2020

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020

MyIgel commented Sep 2, 2020 •

edited

Loading

hakanersu commented Sep 2, 2020 •

edited

Loading

greg0ire commented Sep 3, 2020

uuf6429 commented Sep 3, 2020

SirNarsh commented Sep 3, 2020 •

edited

Loading

github-actions bot commented Jul 28, 2022

SQLite Foreign Key Behavior BC Break #4243

SQLite Foreign Key Behavior BC Break #4243

Comments

taylorotwell commented Sep 2, 2020

BC Break Report

Summary

MyIgel commented Sep 2, 2020 • edited by greg0ire Loading

MyIgel commented Sep 2, 2020 • edited by greg0ire Loading

MyIgel commented Sep 2, 2020 • edited Loading

MyIgel commented Sep 2, 2020 • edited Loading

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020 • edited Loading

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020 • edited Loading

greg0ire commented Sep 2, 2020

morozov commented Sep 2, 2020

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020

MyIgel commented Sep 2, 2020

greg0ire commented Sep 2, 2020

MyIgel commented Sep 2, 2020 • edited Loading

hakanersu commented Sep 2, 2020 • edited Loading

greg0ire commented Sep 3, 2020

uuf6429 commented Sep 3, 2020

SirNarsh commented Sep 3, 2020 • edited Loading

github-actions bot commented Jul 28, 2022

MyIgel commented Sep 2, 2020 •

edited by greg0ire

Loading

MyIgel commented Sep 2, 2020 •

edited by greg0ire

Loading

MyIgel commented Sep 2, 2020 •

edited

Loading

MyIgel commented Sep 2, 2020 •

edited

Loading

greg0ire commented Sep 2, 2020 •

edited

Loading

greg0ire commented Sep 2, 2020 •

edited

Loading

MyIgel commented Sep 2, 2020 •

edited

Loading

hakanersu commented Sep 2, 2020 •

edited

Loading

SirNarsh commented Sep 3, 2020 •

edited

Loading