Skip to content
This repository has been archived by the owner on Feb 3, 2022. It is now read-only.

fix: support EIP-1559 #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

roy1210
Copy link
Contributor

@roy1210 roy1210 commented Aug 27, 2021

=Before=

@roy1210
Copy link
Contributor Author

roy1210 commented Sep 1, 2021

Hi @bobo-kovacevic
This is the deployed demo URL: https://lockdrop-ui-beta-debp0tsiv-roy1210.vercel.app/#/lock-form

Can you help to check with using the latest version of metamask (Supports EIP-1559) to call the contract function? I can't check it since the UI only allows to call the function by user who locked ETH long times ago. Also, please help to check if max priority fee has set as 2gwei.

It looks something like this but just 2gwei for max priority fee
image

@roy1210
Copy link
Contributor Author

roy1210 commented Sep 1, 2021

I've set maxPriorityFeePerGas as 2gwei as hard coding, but ideally get the value dynamically.
I recommend to use blocknative API to get the latest maxPriorityFeePerGas. You can use this API with free account.

telegram-cloud-photo-size-5-6145464195139874319-y
Usually I just get confidence: 80

@roy1210
Copy link
Contributor Author

roy1210 commented Sep 6, 2021

Hi @hoonsubin @bobo-kovacevic
Any update for this PR? Thanks!

@bobo-k2
Copy link
Collaborator

bobo-k2 commented Sep 6, 2021

Hi @roy1210 I apologize for late response. We will test the feature this week.

@bobo-k2
Copy link
Collaborator

bobo-k2 commented Sep 14, 2021

@roy1210 I tried to test your changes on my machine, but unfortunately this is not possible yet because of Ganache lacking London hardfork support. There is a PR to fix that trufflesuite/ganache#1135. I will try again when they enable London support.

@roy1210
Copy link
Contributor Author

roy1210 commented Sep 14, 2021

Hi @bobo-kovacevic

I tried to test your changes on my machine,

I see. Would you mind letting me reproduce this part on my machine? I'd like to debug if possible.
My telegram ID: @Roy_Shoe_Kure

@roy1210
Copy link
Contributor Author

roy1210 commented Sep 24, 2021

Hi @bobo-kovacevic
The PR trufflesuite/ganache#1135 has been merged a while ago. Could you update, please?

@bobo-k2
Copy link
Collaborator

bobo-k2 commented Sep 25, 2021

Hi @bobo-kovacevic
The PR trufflesuite/ganache#1135 has been merged a while ago. Could you update, please?

Hi @roy1210 thank you for update update about the PR. I will take a look. Also, I will contact you on Telegram regarding debugging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants