This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Update eslint to version 4.3.0 🚀 #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
Arcanemagus
changed the title
|
Blocked on a compatible version of |
Version 4.1.0 just got published.Update to this version instead 🚀 Release Notesv4.1.0
CommitsThe new version differs by 22 commits.
There are 22 commits in total. See the full diff |
Version 4.1.0 just got published.Update to this version instead 🚀 Release Notesv4.1.0
|
Version 4.1.1 just got published.Update to this version instead 🚀 Release Notesv4.1.1
CommitsThe new version differs by 7 commits.
See the full diff |
Version 4.1.1 just got published.Update to this version instead 🚀 Release Notesv4.1.1
|
Version 4.2.0 just got published.Update to this version instead 🚀 Release Notesv4.2.0
CommitsThe new version differs by 38 commits.
There are 38 commits in total. See the full diff |
Version 4.2.0 just got published.Update to this version instead 🚀 Release Notesv4.2.0
|
Version 4.3.0 just got published.Update to this version instead 🚀 Release Notesv4.3.0
CommitsThe new version differs by 28 commits.
There are 28 commits in total. See the full diff |
Version 4.3.0 just got published.Update to this version instead 🚀 Release Notesv4.3.0
|
|
airbnb now supports ESLint 4 🎉 https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/CHANGELOG.md#1130--2017-07-23 |
|
Finally! |
Arcanemagus
changed the title
Having ESLint specified in both the `dependencies` _and_ `devDependencies` isn't a supported configuration in the first place. As the version specified there is the bundled version and not the actual supported version of ESLint I think this is the best course of action moving forward.
Arcanemagus
force-pushed
the
greenkeeper/eslint-4.0.0
branch
from
1b503e0 to
d765601
Compare
It looks like the range for a reported message was slightly fixed in this newer ESLint version.
Arcanemagus
force-pushed
the
greenkeeper/eslint-4.0.0
branch
from
2ec23bc to
78b80eb
Compare
The Atom build-package.sh script only checks `devDependencies` for linters to run, as ESLint is only listed in our direct `dependencies` now we need to trigger linting manually. Includes: * Minor update to the addon APT packages for Travis CI. * Structure of the Circle CI script is updated to match that of atom/ci. * Installing Noide.js on AppVeyor to run ESLint.
Arcanemagus
force-pushed
the
greenkeeper/eslint-4.0.0
branch
from
78b80eb to
0e60de5
Compare
ESLint forever pauses the build, as this is being doubly covered by Travis CI and CircleCI I feel fine with simply not running it on AppVeyor.
IanVS
approved these changes
Jul 24, 2017
There was a problem hiding this comment.
This all seems reasonable enough to me.
Since eslint version 4 throws errors on invalid .eslintrc configuration, and users depending on the bundled version of eslint will get their version bumped from 3 to 4, we will need a major version bump when we release this.
|
@IanVS any plans for a new release yet? |
|
If you'd like to use eslint version 4, you're already free to install and use it in your projects. In fact, this particular update will only effect those relying on the bundled fallback eslint, which we strongly recommend against relying on. But, to answer your question, yes we will get a release out soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.0.0 of eslint just got published.
The version 4.0.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Release Notes
v4.0.0no-mixed-requires(#8686) (Fangzhou Li)Commits
The new version differs by 119 commits.
c61194f4.0.0821a1e6Build: changelog update for 4.0.04aefb49Chore: avoid using deprecated rules on ESLint codebase (#8708)389febaChore: upgrade deps. (#8684)3da7b5eFix: Semi-Style only check for comments when tokens exist (fixes #8696) (#8697)3cfe9eeFix: Add space between async and param on fix (fixes #8682) (#8693)c702858Chore: enable no-multiple-empty-lines on ESLint codebase (#8694)34c4020Update: Add support for parens on left side for-loops (fixes: #8393) (#8679)735cd09Docs: Correct the comment in an example forno-mixed-requires(#8686)026f048Chore: remove dead code from prefer-const (#8683)a8e1c1c4.0.0-rc.01768dc0Build: changelog update for 4.0.0-rc.00058b0fUpdate: add --fix to no-debugger (#8660)b4daa22Docs: Note to --fix option for strict rule (#8680)4df33e7Chore: check for root:true in project sooner (fixes #8561) (#8638)There are 119 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴