Playlist ID offset in legacy indexing #3574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacsolo
force-pushed
the
is-offset-playlist
branch
from
94f1ddc to
18b715e
Compare
isaacsolo
force-pushed
the
is-offset-playlist
branch
from
18b715e to
c23f8d9
Compare
isaacsolo
force-pushed
the
is-offset-playlist
branch
from
c23f8d9 to
0e51335
Compare
There was a problem hiding this comment.
Let's consider the case where IDs collide and do not respect our off-chain min/max boundaries (from here) - https://github.com/AudiusProject/audius-protocol/pull/3400/files#diff-b3fc3b9d8061a71a8ad45591eb7bdab08624693172f21852cd58d9d45b21ebd2R35
isaacsolo
force-pushed
the
hn_audius_data_write_path
branch
from
b16201a to
66a6ada
Compare
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
sliptype
pushed a commit
that referenced
this pull request
Sep 10, 2023
[1957c34] Add remove from playlist overflow action (#3621) Kyle Shanks [67e0012] [C-2712] Clear favorites on sign-out (#3620) Dylan Jeffers [97b6b94] [PAY-1421] Fix android reaction offsets (#3611) Michael Piazza [9867571] [PAY-1494] Change chats copy to beginning of message history (#3617) Reed [1b7ca71] Add overflow menu options for track list items on mobile (#3608) Kyle Shanks [810f0df] [PAY-1487] Increase hit slop of mobile dms send button (#3618) Reed [06dae51] [PAY-1470] Remove border radius from track/playlist tiles (#3613) Marcus Pasell [dbdfb84] [PAY-1469] Clear the search after creating a chat (#3616) Marcus Pasell [3f31554] [PAY-1489] Add more space to reacted to messages (#3615) Marcus Pasell [ed4f321] [PAY-1473] Clear input on chat change (#3614) Marcus Pasell [e9683d9] Use emojis instead of 'heart' etc as reactions (#3602) Marcus Pasell [192fd44] [PAY-1486] DMs: Fix purple border around unfurls (#3612) Marcus Pasell [b0c2e4a] Lowercase library restricted handle (#3590) Isaac Solo [a8daa72] Change text to 'Beginning of Conversation' (#3605) Marcus Pasell [332c0c0] Developer app modal - small fixes (#3609) nicoback2 [0e43db1] [PAY-1476] Inbox unavailable copy update (#3607) Reed [d862fd5] [PAY-1484] Allow reactions while keyboard is open on mobile (#3606) Reed [3bd5928] [PAY-944] DMs: Add Mobile Web drawer prompting app download (#3565) Marcus Pasell [5bea105] Wait for libs to init before initting SDK (#3604) Marcus Pasell [f4d28e0] Add option to cache bust node_modules (#3603) Dylan Jeffers [9b165c4] [PAY-1455] Optimize reactions perf (maybe) (#3599) Michael Piazza [0a1a68b] [PAY-1465] Auto-nav to chat only when permitted (#3598) Reed [72e9f92] [C-2665 C-2714] Add developer apps settings modal (#3589) Dylan Jeffers [b787344] [PAY-1456] Fix followee-gated create chat crash (#3593) Reed [dbae5bd] Reduce MessageLockedButton size on profile screen (#3597) Reed [097879b] [PAY-1437] Fix drawers sharing state causing crash (#3595) Reed [818b215] [C-2770] Fix issue where playlist library can disappear (#3596) Dylan Jeffers [f3ada88] [PAY-1461] Format follower count in chat search screen (#3594) Reed [eb924e7] [C-2713] Add track metadata fields to new upload form (#3574) Andrew Mendelsohn [be56d1f] Fix mobile textinput borders + labels (#3592) Reed [fc7541b] Update collection list id flow to add the create tile (#3591) Kyle Shanks [dc15518] [PAY-1432] Fix chat playlist artist sometimes undefined (#3585) Reed [399d0b5] [C-2588] Update share modal and drawer to properly add user twitter handle (#3584) Kyle Shanks [9f30855] [C-2761] Add mutations to audius-query (#3581) Dylan Jeffers [597dfe5] [PAY-1448] End the race between SDK and Libs, once and for all (#3588) Marcus Pasell [56914cf] [C-2768] Update InputV2, add TextField/TextAreaField (#3587) Dylan Jeffers [c9358b6] [CON-742] Make users and track actions v2 for v2 users/tracks even when feature flags are disabled (#3582) Theo Ilie [a94f035] audius-query debug flag usage in README (#3586) Reed [bceb3fe] [INF-417] Generate sourcemaps when running web:prod (#3583) Sebastian Klingler [f4ad466] [PAY-1454] Redline mobile header to latest figma design (#3576) Michael Piazza [eec6af0] [PAY-1405] Add padding to bottom of chat user search screen (#3580) Reed [a6c8ece] [PAY-1435] Navigate to chat after unblocking user on mobile (#3578) Reed [ee1b6c3] [PLAT-659] Metamask sign in/up on ACDC (#3563) Raymond Jacobson [fbd4053] [C-2472] Update mobile track list items for playlists to have the overflow menu (#3577) Kyle Shanks [51f44ac] [PAY-1399] Fix Android chat send button color (#3575) Reed [7d440de] [PAY-1442] Fix drawer touchables on android (#3572) Reed [8c90ff6] Allow drag and dropping tracks into chat (#3573) Michael Piazza [f7489e0] Upgrade dapp store version to v1.5.26 (#3504) Dylan Jeffers [6be0c64] [PAY-1440][PAY-1441] Mobile inbox settings UI fixes (#3571) Reed [001007e] [PAY-1434] Dismiss keyboard on create chat screen row press (#3569) Reed [c70e9fe] [PAY-1446] Set MessageLocked icon in profile screen to 0.4 opacity (#3570) Reed [2cc8ad0] [C-2716] Improve notifications on fresh account (#3568) Dylan Jeffers [01f05ba] [C-2474] Generate playlist artwork from track artwork (#3518) Dylan Jeffers [0355c10] [PAY-1325] Remove userbadges from chat unavailable message in chat screen (#3567) Reed [da10bbc] [PAY-1389] CTA on create chat when not permitted (#3566) Reed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip legacy playlist txs when they involve an ID from the new playlist flow.
Tests
Tested against main and AudiusProject/audius-client#1661.
Hardcoded cutoff for testing and verified any legacy txs for taking an action on a playlist over the MIN_PLAYLIST_ID were skipped.
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?