Filter out notifications from bad initiators #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sddioulde
force-pushed
the
sd-fix-notif-rollup
branch
from
73bf3c3 to
e01c479
Compare
sddioulde
commented
Aug 11, 2022
| * @param {Object[]} notifications | ||
| * @returns {Promise<Object[]>} notifications - after having filtered out notifications from bad initiators | ||
| */ | ||
| async function filterOutAbusiveUsers (notifications) { |
There was a problem hiding this comment.
maybe i pull this function and the one below to a helper/util
raymondjacobson
approved these changes
Aug 11, 2022
sddioulde
force-pushed
the
sd-fix-notif-rollup
branch
from
a5aca7f to
d056421
Compare
audius-infra
pushed a commit
that referenced
this pull request
Aug 12, 2022
## Changelog - 2022-08-12 [c38a6a8] Update @solana/spl-token to 0.1.8 (#3689) [Marcus Pasell] - 2022-08-12 [587b38e] CON-327 Miscellaneous secondarySyncFromPrimary() improvements to logic + metric tracking (#3678) [Sid Sethi] - 2022-08-12 [1afa5d5] [CON-324] Add orphaned data recovery queue (#3680) [Theo Ilie] - 2022-08-12 [10599f4] Handle zero error code (#3686) [Saliou Diallo] - 2022-08-12 [2346960] Use abuse error codes in relay (#3683) [Raymond Jacobson] - 2022-08-12 [c3f578e] populate save_count in feed endpoint (#3684) [Steve Perkins] - 2022-08-11 [5e6217f] Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682) [Raymond Jacobson] - 2022-08-11 [a44aad2] Fix bad notifs (#3681) [Saliou Diallo] - 2022-08-11 [23a6c3b] [PAY-485][PAY-491] Handle premium content signature (#3610) [Saliou Diallo] - 2022-08-11 [a478a1d] [PAY-459] Add dethroned notifications on Identity (#3674) [Michael Piazza] - 2022-08-11 [8fb6084] Add a log before force resync happen (#3677) [vicky :)] - 2022-08-11 [47f55f4] [PAY-506] Exposes AAO error code (#3662) [Reed] - 2022-08-11 [4bc58cf] Filter out notifications from bad initiators (#3676) [Saliou Diallo] - 2022-08-11 [e01c91c] Prevent extra unnecessary reconfig events (#3671) [vicky :)] - 2022-08-11 [cff11a9] Fix downgrades (#3667) [Joseph Lee] - 2022-08-11 [424ff50] Add disable flag to logspout (#3672) [Dheeraj Manjunath] - 2022-08-11 [bac7669] Bump sdk to v0.0.33 [audius-infra]
audius-infra
pushed a commit
that referenced
this pull request
Aug 12, 2022
## Changelog - 2022-08-12 [c38a6a8] Update @solana/spl-token to 0.1.8 (#3689) [Marcus Pasell] - 2022-08-12 [587b38e] CON-327 Miscellaneous secondarySyncFromPrimary() improvements to logic + metric tracking (#3678) [Sid Sethi] - 2022-08-12 [1afa5d5] [CON-324] Add orphaned data recovery queue (#3680) [Theo Ilie] - 2022-08-12 [10599f4] Handle zero error code (#3686) [Saliou Diallo] - 2022-08-12 [2346960] Use abuse error codes in relay (#3683) [Raymond Jacobson] - 2022-08-12 [c3f578e] populate save_count in feed endpoint (#3684) [Steve Perkins] - 2022-08-11 [5e6217f] Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682) [Raymond Jacobson] - 2022-08-11 [a44aad2] Fix bad notifs (#3681) [Saliou Diallo] - 2022-08-11 [23a6c3b] [PAY-485][PAY-491] Handle premium content signature (#3610) [Saliou Diallo] - 2022-08-11 [a478a1d] [PAY-459] Add dethroned notifications on Identity (#3674) [Michael Piazza] - 2022-08-11 [8fb6084] Add a log before force resync happen (#3677) [vicky :)] - 2022-08-11 [47f55f4] [PAY-506] Exposes AAO error code (#3662) [Reed] - 2022-08-11 [4bc58cf] Filter out notifications from bad initiators (#3676) [Saliou Diallo] - 2022-08-11 [e01c91c] Prevent extra unnecessary reconfig events (#3671) [vicky :)] - 2022-08-11 [cff11a9] Fix downgrades (#3667) [Joseph Lee] - 2022-08-11 [424ff50] Add disable flag to logspout (#3672) [Dheeraj Manjunath] - 2022-08-11 [bac7669] Bump sdk to v0.0.33 [audius-infra]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Filter out notifs from initiators deemed abusive as soon as we get the notifs from DN, for both poa and sol notifs.
Tests
Manual
Monitoring - How will this change be monitored? Are there sufficient logs / alerts?
Added logs for number of bad initiators filtered out.