Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAY-506] Exposes AAO error code #3662

Merged
merged 2 commits into from
Aug 11, 2022
Merged

[PAY-506] Exposes AAO error code #3662

merged 2 commits into from
Aug 11, 2022

Conversation

dharit-tan
Copy link
Contributor

Description

Expose AAO error codes in rewardsAttester.

Tests

Manually tested on web client.

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

piazzatron
piazzatron suggested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good - just a few little things to fix and then should be good to go

libs/src/api/rewards.js Outdated Show resolved Hide resolved
libs/src/api/rewards.js Outdated Show resolved Hide resolved
libs/src/api/rewards.js Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/M and removed size/S labels Aug 9, 2022
@dharit-tan dharit-tan requested a review from piazzatron August 9, 2022 21:45
piazzatron
piazzatron approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@piazzatron piazzatron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!!

libs/src/api/Rewards.ts Show resolved Hide resolved
@dharit-tan dharit-tan merged commit 47f55f4 into master Aug 11, 2022
@dharit-tan dharit-tan deleted the rt-PAY-506 branch August 11, 2022 20:42
audius-infra pushed a commit that referenced this pull request Aug 12, 2022
Bump sdk to v0.0.34
4143fbb 
## Changelog

- 2022-08-12 [c38a6a8] Update @solana/spl-token to 0.1.8 (#3689) [Marcus Pasell]
- 2022-08-12 [587b38e] CON-327 Miscellaneous secondarySyncFromPrimary() improvements to logic + metric tracking (#3678) [Sid Sethi]
- 2022-08-12 [1afa5d5] [CON-324] Add orphaned data recovery queue (#3680) [Theo Ilie]
- 2022-08-12 [10599f4] Handle zero error code (#3686) [Saliou Diallo]
- 2022-08-12 [2346960] Use abuse error codes in relay (#3683) [Raymond Jacobson]
- 2022-08-12 [c3f578e] populate save_count in feed endpoint (#3684) [Steve Perkins]
- 2022-08-11 [5e6217f] Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682) [Raymond Jacobson]
- 2022-08-11 [a44aad2] Fix bad notifs (#3681) [Saliou Diallo]
- 2022-08-11 [23a6c3b] [PAY-485][PAY-491] Handle premium content signature (#3610) [Saliou Diallo]
- 2022-08-11 [a478a1d] [PAY-459] Add dethroned notifications on Identity (#3674) [Michael Piazza]
- 2022-08-11 [8fb6084] Add a log before force resync happen (#3677) [vicky :)]
- 2022-08-11 [47f55f4] [PAY-506] Exposes AAO error code (#3662) [Reed]
- 2022-08-11 [4bc58cf] Filter out notifications from bad initiators (#3676) [Saliou Diallo]
- 2022-08-11 [e01c91c] Prevent extra unnecessary reconfig events (#3671) [vicky :)]
- 2022-08-11 [cff11a9] Fix downgrades (#3667) [Joseph Lee]
- 2022-08-11 [424ff50] Add disable flag to logspout (#3672) [Dheeraj Manjunath]
- 2022-08-11 [bac7669] Bump sdk to v0.0.33 [audius-infra]
audius-infra pushed a commit that referenced this pull request Aug 12, 2022
Bump sdk to v0.0.34
82dcf35 
## Changelog

- 2022-08-12 [c38a6a8] Update @solana/spl-token to 0.1.8 (#3689) [Marcus Pasell]
- 2022-08-12 [587b38e] CON-327 Miscellaneous secondarySyncFromPrimary() improvements to logic + metric tracking (#3678) [Sid Sethi]
- 2022-08-12 [1afa5d5] [CON-324] Add orphaned data recovery queue (#3680) [Theo Ilie]
- 2022-08-12 [10599f4] Handle zero error code (#3686) [Saliou Diallo]
- 2022-08-12 [2346960] Use abuse error codes in relay (#3683) [Raymond Jacobson]
- 2022-08-12 [c3f578e] populate save_count in feed endpoint (#3684) [Steve Perkins]
- 2022-08-11 [5e6217f] Revert "[PLAT-259] Upgrade EthereumTx version (#3606)" (#3682) [Raymond Jacobson]
- 2022-08-11 [a44aad2] Fix bad notifs (#3681) [Saliou Diallo]
- 2022-08-11 [23a6c3b] [PAY-485][PAY-491] Handle premium content signature (#3610) [Saliou Diallo]
- 2022-08-11 [a478a1d] [PAY-459] Add dethroned notifications on Identity (#3674) [Michael Piazza]
- 2022-08-11 [8fb6084] Add a log before force resync happen (#3677) [vicky :)]
- 2022-08-11 [47f55f4] [PAY-506] Exposes AAO error code (#3662) [Reed]
- 2022-08-11 [4bc58cf] Filter out notifications from bad initiators (#3676) [Saliou Diallo]
- 2022-08-11 [e01c91c] Prevent extra unnecessary reconfig events (#3671) [vicky :)]
- 2022-08-11 [cff11a9] Fix downgrades (#3667) [Joseph Lee]
- 2022-08-11 [424ff50] Add disable flag to logspout (#3672) [Dheeraj Manjunath]
- 2022-08-11 [bac7669] Bump sdk to v0.0.33 [audius-infra]
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@dylanjeffers
[C-2798] Fix playlist button overlap (#3662)
3ec8edf
sliptype pushed a commit that referenced this pull request Sep 10, 2023
@dylanjeffers
v1.5.31
bd21819 
[4a26077] [C-2678] Add Stems and Source Files Modal (#3671) Andrew Mendelsohn
[6a3342a] Bump android version to 1.1.391 to fix play-store build (#3678) Dylan Jeffers
[2064212] [C-2813] Catch collectibles runtime errors (#3675) Dylan Jeffers
[29233ea] [C-2808] Improve storageNodeSelector usage and perf (#3674) Dylan Jeffers
[2de2035] Fix mobile image uri (#3670) Dylan Jeffers
[55a6089] [C-2807] Add ModalField subforms with cancellation (#3664) Andrew Mendelsohn
[e26986f] [C-2812] Use storageNodeSelector in libs, fix mobile images (#3667) Dylan Jeffers
[5daea08] Enable playlist updates on prod (#3668) Dylan Jeffers
[d90c369] [PAY-1541] Autofocus textinput on mobile search users screen (#3666) Reed
[194f894] [PAY-1542][PAY-1539][PAY-1537] Mobile chats QA improvements (#3665) Reed
[58b9028] [C-2798] Fix playlist button overlap (#3662) Dylan Jeffers
[a935588] [PAY-1538] Fix autocorrect behavior (#3661) Michael Piazza
[1a8a6e7] [PAY-1518] DMs: Align the overflow menu bottom center (#3654) Marcus Pasell
[c880b2a] [plat-1085] disable fav and repost on hidden tracks in play bar (#3653) sabrina-kiam
[d80617e] [PAY-1529] Add initial types for usdc purchases (#3651) Randy Schott
[68e87ff] [C-2787] Reregister device-token on app startup (#3660) Dylan Jeffers
[ddfa510] [C-2802] Move embed to client monorepo! (#3659) Raymond Jacobson
[6a2f008] Add Sentry error logging to Audius query C-2800 (#3656) nicoback2
[79213de] Add Amplitude events to new Write OAuth flows C-2801 (#3657) nicoback2
[6576ae4] Fix android chat message cut off at top (#3658) Reed
[160b325] [C-2677] Remix Settings Modal layout complete (#3647) Andrew Mendelsohn
[c01c022] [C-2790] Add private DogEar to desktop playlist cards (#3655) Dylan Jeffers
[50e8f4e] [PAY-1522][PAY-1451] Fix issues with DMs notification dot (#3649) Michael Piazza
[1658810] [PAY-1530] adds usdc feature flag and hooks for fetching it (#3645) Randy Schott
@AudiusProject AudiusProject deleted a comment from linear bot Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piazzatron piazzatron piazzatron approved these changes

@rickyrombo rickyrombo rickyrombo approved these changes

@sddioulde sddioulde Awaiting requested review from sddioulde

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dharit-tan @rickyrombo @piazzatron