[C-3526] Select artist screen perf #7018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Preview this change https://demo.audius.co/dj-c-3526-select-artist-perf |
DejayJD
reviewed
Dec 23, 2023
| const initialValues: SelectArtistsValues = { | ||
| selectedArtists: [] | ||
| } | ||
|
|
||
| export const SelectArtistsScreen = () => { |
There was a problem hiding this comment.
Might be a good idea to add a comment somewhere in here explaining why we're not using Formik
DejayJD
reviewed
Dec 23, 2023
| @@ -1,11 +1,18 @@ | |||
| import type { ChangeEvent } from 'react' | |||
There was a problem hiding this comment.
nit: Since this isn't technically a "Field" anymore, maybe it's worth renaming
DejayJD
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
LGTM! Didn't check out the performance locally but I trust that it's improved!
I actually kind of vibe with the overall concept of not treating this page as a "form" since each follow button technically behaves the same as a follow button later in the app (or at least I assume thats the case), so it makes sense to me to treat them the same
audius-infra
pushed a commit
that referenced
this pull request
Dec 30, 2023
[54e51d0] [C-3521] Add option menu to create collection tile (web) (#7046) Andrew Mendelsohn [8300ad0] [C-3550] Upgrade react native to 0.73.1 (#7042) Dylan Jeffers [116a19a] [SDK] Fix validate ETH address util (#7043) nicoback2 [e6a4565] [C-3533] Fix add track to collection toast (#7044) Andrew Mendelsohn [8c1e557] Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025) Marcus Pasell [9700752] Add rate limits for DashboardWalletUser relays (#7041) nicoback2 [95dd48f] [C-3434] Add Divider to native harmony (#7040) Kyle Shanks [858da9f] [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039) nicoback2 [a2d87ca] [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033) nicoback2 [eec88be] [PROTO-1492] Add sandbox env to comms (#7030) Theo Ilie [ad3f877] [C-3547] Upgrade eslint, typescript, and prettier (#7036) Dylan Jeffers [8e65654] Fix release dates and listing status (#7037) Raymond Jacobson [0729448] Disable scheduled releases job (#7035) Raymond Jacobson [ddac7e8] [C-3545] Upgrade reanimated and dependents (#7031) Dylan Jeffers [dea3dfb] Run comms locally via audius-compose (#7028) Marcus Pasell [14385bf] Disable slack notify if full release when sent to app store (#7032) Raymond Jacobson [29cf448] [C-3489, C-3516] Sign up QA #3 (#7016) Dylan Jeffers [2e7f47e] [C-3526] Select artist screen perf (#7018) Dylan Jeffers [2dcdb5a] [C-3540] tRPC call to get albums for track (#7029) Andrew Mendelsohn [44b99b6] Re-gen SDK for DashboardWalletUsers APIs (#7027) nicoback2
schottra
added a commit
that referenced
this pull request
Jan 2, 2024
* origin/main: (64 commits) v1.5.58 [C-3521] Add option menu to create collection tile (web) (#7046) [C-3550] Upgrade react native to 0.73.1 (#7042) [SDK] Fix validate ETH address util (#7043) [C-3533] Fix add track to collection toast (#7044) Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025) Add rate limits for DashboardWalletUser relays (#7041) [C-3434] Add Divider to native harmony (#7040) [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039) [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033) [PROTO-1492] Add sandbox env to comms (#7030) [C-3547] Upgrade eslint, typescript, and prettier (#7036) Fix release dates and listing status (#7037) Disable scheduled releases job (#7035) [C-3545] Upgrade reanimated and dependents (#7031) Run comms locally via audius-compose (#7028) Disable slack notify if full release when sent to app store (#7032) [C-3489, C-3516] Sign up QA #3 (#7016) [C-3526] Select artist screen perf (#7018) [C-3540] tRPC call to get albums for track (#7029) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates select artist screen to use redux instead of formik, due to super slow perf. Using redux seemed to be cleanest option, rather than a context + memo approach