Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rate limits for DashboardWalletUser relays #7041

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

nicoback2
Copy link
Contributor

@nicoback2 nicoback2 commented Dec 28, 2023

Description

Rate limits are high because you can only have one wallet per user, and the wallet also has to sign the tx.
Need to add this or else the relay for these txs fails.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
audius-web-ssr ⬜️ Ignored (Inspect) Dec 28, 2023 10:15pm

@nicoback2 nicoback2 requested review from a team and dylanjeffers and removed request for a team December 28, 2023 22:15
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nicoback2 nicoback2 merged commit 9700752 into main Dec 28, 2023
11 of 12 checks passed
@nicoback2 nicoback2 deleted the nkang--add-dwu-rate-limit branch December 28, 2023 22:28
audius-infra pushed a commit that referenced this pull request Dec 30, 2023
[54e51d0] [C-3521] Add option menu to create collection tile (web) (#7046) Andrew Mendelsohn
[8300ad0] [C-3550] Upgrade react native to 0.73.1 (#7042) Dylan Jeffers
[116a19a] [SDK] Fix validate ETH address util (#7043) nicoback2
[e6a4565] [C-3533] Fix add track to collection toast (#7044) Andrew Mendelsohn
[8c1e557] Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025) Marcus Pasell
[9700752] Add rate limits for DashboardWalletUser relays (#7041) nicoback2
[95dd48f] [C-3434] Add Divider to native harmony (#7040) Kyle Shanks
[858da9f] [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039) nicoback2
[a2d87ca] [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033) nicoback2
[eec88be] [PROTO-1492] Add sandbox env to comms (#7030) Theo Ilie
[ad3f877] [C-3547] Upgrade eslint, typescript, and prettier (#7036) Dylan Jeffers
[8e65654] Fix release dates and listing status (#7037) Raymond Jacobson
[0729448] Disable scheduled releases job (#7035) Raymond Jacobson
[ddac7e8] [C-3545] Upgrade reanimated and dependents (#7031) Dylan Jeffers
[dea3dfb] Run comms locally via audius-compose (#7028) Marcus Pasell
[14385bf] Disable slack notify if full release when sent to app store (#7032) Raymond Jacobson
[29cf448] [C-3489, C-3516] Sign up QA #3 (#7016) Dylan Jeffers
[2e7f47e] [C-3526] Select artist screen perf (#7018) Dylan Jeffers
[2dcdb5a] [C-3540] tRPC call to get albums for track (#7029) Andrew Mendelsohn
[44b99b6] Re-gen SDK for DashboardWalletUsers APIs (#7027) nicoback2
schottra added a commit that referenced this pull request Jan 2, 2024
* origin/main: (64 commits)
  v1.5.58
  [C-3521] Add option menu to create collection tile (web) (#7046)
  [C-3550] Upgrade react native to 0.73.1 (#7042)
  [SDK] Fix validate ETH address util (#7043)
  [C-3533] Fix add track to collection toast (#7044)
  Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025)
  Add rate limits for DashboardWalletUser relays (#7041)
  [C-3434] Add Divider to native harmony (#7040)
  [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039)
  [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033)
  [PROTO-1492] Add sandbox env to comms (#7030)
  [C-3547] Upgrade eslint, typescript, and prettier (#7036)
  Fix release dates and listing status (#7037)
  Disable scheduled releases job (#7035)
  [C-3545] Upgrade reanimated and dependents (#7031)
  Run comms locally via audius-compose (#7028)
  Disable slack notify if full release when sent to app store (#7032)
  [C-3489, C-3516] Sign up QA #3 (#7016)
  [C-3526] Select artist screen perf (#7018)
  [C-3540] tRPC call to get albums for track (#7029)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants