-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C-3553] Upgrade all react native deps to latest #7048
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e261542
[C-3553] Upgrade all react-native deps
dylanjeffers db25070
Fix android
dylanjeffers 7e2f23c
Fixes
dylanjeffers 66925a9
Fixes and revert track player
dylanjeffers 1ca586f
Fix react-native-svg
dylanjeffers 59256c5
Fix lighten
dylanjeffers cb4475b
postinstall fix
dylanjeffers eda27c1
Improve svg package.json
dylanjeffers 7a181a9
Fix react-native-svg version
dylanjeffers 45393c5
Merge branch 'main' into dj-c-3553-upgrade-all-react-native-deps
dylanjeffers db5e108
Fix lock
dylanjeffers cd38c7c
Actually fix lock
dylanjeffers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,23 @@ | ||
# Resolve react_native_pods.rb with node to allow for hoisting | ||
require Pod::Executable.execute_command('node', ['-p', | ||
'require.resolve( | ||
"react-native/scripts/react_native_pods.rb", | ||
{paths: [process.argv[1]]}, | ||
)', __dir__]).strip | ||
def node_require(script) | ||
# Resolve script with node to allow for hoisting | ||
require Pod::Executable.execute_command('node', ['-p', | ||
"require.resolve( | ||
'#{script}', | ||
{paths: [process.argv[1]]}, | ||
)", __dir__]).strip | ||
end | ||
|
||
node_require('react-native/scripts/react_native_pods.rb') | ||
node_require('react-native-permissions/scripts/setup.rb') | ||
|
||
platform :ios, min_ios_version_supported | ||
platform :ios, 14 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this supposed to be hard coded? |
||
prepare_react_native_project! | ||
|
||
setup_permissions([ | ||
'Notifications', | ||
'PhotoLibraryAddOnly', | ||
]) | ||
|
||
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled(["Debug", "Staging.Debug"], { 'Flipper' => '0.175.0' }) | ||
|
||
linkage = ENV['USE_FRAMEWORKS'] | ||
|
@@ -23,14 +33,9 @@ project 'AudiusReactNative', | |
'Prod.Release' => :release | ||
|
||
target 'AudiusReactNative' do | ||
permissions_path = '../../../node_modules/react-native-permissions/ios' | ||
pod 'Permission-Notifications', :path => "#{permissions_path}/Notifications" | ||
pod 'Permission-PhotoLibraryAddOnly', :path => "#{permissions_path}/PhotoLibraryAddOnly" | ||
|
||
pod 'SRSRadialGradient', :path => '../../../node_modules/react-native-radial-gradient/ios' | ||
pod 'ffmpeg-kit-react-native', :subspecs => ['https-gpl-lts'], :podspec => '../../../node_modules/ffmpeg-kit-react-native/ffmpeg-kit-react-native.podspec' | ||
pod 'SRSRadialGradient', :path => '../node_modules/react-native-radial-gradient/ios' | ||
pod 'ffmpeg-kit-react-native', :subspecs => ['https-gpl-lts'], :podspec => '../node_modules/ffmpeg-kit-react-native/ffmpeg-kit-react-native.podspec' | ||
pod 'nSure' | ||
# pod 'react-native-flipper', :path => '../../../node_modules/react-native-flipper', :configuration => ['Debug', 'Staging.Debug'] | ||
|
||
config = use_native_modules! | ||
|
||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are all of these effectively guaranteed to be present?