Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C-3553] Upgrade all react native deps to latest #7048

Merged
merged 12 commits into from
Jan 3, 2024

Conversation

dylanjeffers
Copy link
Contributor

@dylanjeffers dylanjeffers commented Jan 2, 2024

Description

To use the new fabric renderer, many react-native dependencies needed to be upgraded to latest. While we should still hold off using fabric (there are some outstanding issues with flat-list), this pr brings us into a fabric compatible place should we flip the switch later this year. It's also good to get us completely up to date with react-native dependencies to ensure best performance

NOTE: This is currently block on legacy wallet-connect

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
audius-web-ssr ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2024 10:10pm

@dylanjeffers dylanjeffers requested review from a team and amendelsohn and removed request for a team January 2, 2024 18:44
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

A little scary upgrading so many at once, but great to be up to date!


platform :ios, min_ios_version_supported
platform :ios, 14
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this supposed to be hard coded?

"@react-native/babel-preset": "0.73.18",
"@react-native/eslint-config": "0.73.1",
"@react-native/babel-preset": "0.74.0",
"@react-native/eslint-config": "0.74.0",
"@react-native/metro-babel-transformer": "^0.74.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're here, does it make sense to pin this?

@@ -339,7 +339,7 @@ export const Button = (props: ButtonProps) => {
// darken the color by 10% for the press state
if (customColor) {
const c = new Color(customColor)
return c.light(0.1).hex()
return c.darken(0.1).hex()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this one a functional change?

@@ -29,7 +29,7 @@ const topArtistsApi = createApi({
async fetch(_, context) {
const { env, fetch } = context

const response = await fetch(env.SUGGESTED_FOLLOW_HANDLES)
const response = await fetch(env.SUGGESTED_FOLLOW_HANDLES!)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all of these effectively guaranteed to be present?

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

Copy link

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@react-native/babel-preset 0.74.0 None +0 14.7 kB react-native-bot
react-native-qrcode-svg 6.2.0 None +4 4.16 MB awesomejerry
react-native-modal-datetime-picker 17.1.0 None +0 43.9 kB mmazzarolo
@react-native-community/hooks 2.8.0...3.0.0 None +0/-0 111 kB pvinis
ffmpeg-kit-react-native 4.5.2...6.0.2 None +0/-0 303 kB tanersener
react-native-google-cast 4.6.0...4.6.2 None +0/-0 931 kB petrbela
@types/react-native-video 3.1.5...5.0.19 None +0/-0 10.7 kB types
@react-native/typescript-config 0.73.1...0.74.0 None +0/-0 2.08 kB react-native-bot
react-native-radial-gradient 1.1.2...1.1.4 None +0/-0 36.6 kB surajitsarkar19
@sayem314/react-native-keep-awake 1.1.0...1.2.2 None +0/-0 30.3 kB sayem314
@fingerprintjs/fingerprintjs-pro-react-native 2.0.0-test.2...2.6.0 None +0/-0 85.5 kB fp-pro
react-native-bars 1.3.0...2.4.2 None +0/-0 70.8 kB zoontek
@hcaptcha/react-native-hcaptcha 1.3.4...1.6.0 None +2/-1 185 kB hcaptcha-npmjs
react-native-notifications 4.3.3...5.1.0 None +0/-0 2.76 MB wix.mobile
react-native-autolink 4.0.0...4.2.0 None +0/-0 41.8 kB joshswan
@react-native/eslint-config 0.73.1...0.74.0 None +1/-1 24.9 kB react-native-bot
react-native-clean-project 4.0.1...4.0.3 None +0/-0 33.1 kB pmadruga
react-native-url-polyfill 1.3.0...2.0.0 None +0/-0 27.5 kB charpeni
@react-native-community/blur 4.3.0...4.3.2 None +0/-0 109 kB titozzz
react-native-restart 0.0.24...0.0.27 None +0/-0 599 kB avishayil
react-native-in-app-review 4.2.1...4.3.3 None +0/-0 60 kB minasamir
react-native-view-shot 3.4.0...3.8.0 None +5/-0 6.3 MB gre
react-native-share 8.0.0...10.0.2 None +0/-0 314 kB mateusandrade
react-native-fs 2.18.0...2.20.0 None +0/-0 570 kB hagen
react-native-haptic-feedback 1.11.0...2.2.0 None +0/-0 696 kB mkuczera
react-native-modal 13.0.0...13.0.1 None +0/-0 72.7 kB mmazzarolo
react-native-image-crop-picker 0.40.0...0.40.2 None +0/-0 2.16 MB ivpusic
react-native-config 1.4.5...1.5.1 None +0/-0 129 kB luancurti
@react-native-community/netinfo 11.0.1...11.2.1 None +0/-0 538 kB mattoakes
react-native-markdown-display 7.0.0-alpha.2...7.0.2 None +0/-0 69.7 kB iamacup
@react-native-masked-view/masked-view 0.3.0...0.3.1 None +0/-0 59 kB naturalclar
@react-native-community/slider 4.4.3...4.5.0 None +0/-0 254 kB bartoszklonowski
react-native-linear-gradient 2.6.2...2.8.3 None +0/-0 118 kB fbluemle.oss
react-native-document-picker 8.1.2...9.1.0 None +0/-0 148 kB vonovak
@storybook/react-native 6.5.6...6.5.7 None +1/-1 367 kB dannyhw
react-native-bootsplash 4.4.1...5.2.1 eval, network, filesystem +12/-33 9.83 MB zoontek
react-native-svg 12.3.0...13.14.0 None +0/-0 2.85 MB wolewicki
react-native-safe-area-context 4.5.3...4.8.2 None +0/-0 236 kB janicduplessis
react-native-permissions 3.0.5...4.0.1 None +0/-0 494 kB zoontek
@sentry/react-native 5.15.1...5.15.2 None +0/-6 1.11 MB sentry-bot
react-native-image-picker 4.10.2...7.1.0 None +0/-0 178 kB johandutoit
@testing-library/react-native 12.3.0...12.4.3 None +0/-9 690 kB mdjastrzebski

🚮 Removed packages: deprecated-react-native-prop-types@4.0.0

@audius-infra
Copy link
Collaborator

It looks like there may be some changes to native mobile code, which requires triggering a full app release. Please follow the instructions here: https://www.notion.so/audiusproject/When-to-bump-app-version-2644a8f772364a4d91f44abcba44ce0b?pvs=4. cc @nicoback2 @sliptype

@audius-infra
Copy link
Collaborator

@dylanjeffers dylanjeffers merged commit 32333e9 into main Jan 3, 2024
15 of 19 checks passed
@dylanjeffers dylanjeffers deleted the dj-c-3553-upgrade-all-react-native-deps branch January 3, 2024 22:44
audius-infra pushed a commit that referenced this pull request Jan 6, 2024
[0f7a486] [C-3478] Backlink to album from track page (#7074) Andrew Mendelsohn
[bc375b1] DDEX NODE_ENV production -> prod (#7103) Michelle Brier
[ac831b6] Actually fix discovery notif tests (#7101) Raymond Jacobson
[c9fd31e] Move uploads out of DDEX client (#7100) Michelle Brier
[d162abc] [C-3571] Fix modal header styles (#7091) Dylan Jeffers
[3e22ea8] [C-3515] Fix desktop sign up page transitions (#7084) Dylan Jeffers
[dcd6c7d] Bump version to 0.6.12 audius-infra
[dd4de97] [Web] Fix OAuth sig timestamp (#7099) nicoback2
[6aada56] Add default ddex stage keys and enforce prettier (#7098) Theo Ilie
[80ec2c0] Fix copyright year for notif test (#7079) Isaac Solo
[6e3fe0c] Increment mobile versions ahead of 1.5.59 (#7097) Raymond Jacobson
[53722a8] Add ddex upload logic to backend (#7096) Michelle Brier
[1149d51] Add 8cpu resource class to circleci runners (#7094) Danny
[7dc3969] Make Stripe the default PurchaseVendor for AddFunds on mobile (#7085) Marcus Pasell
[33e1b72] [C-3560 C-3564] Improve mobile playlist image generation perf. (#7080) Dylan Jeffers
[9d82f82] Fix harmony build (#7093) Dylan Jeffers
[e8bb46a] fix: Fix horizontal color logo clipping & resize img (#7082) JD Francis
[c8fea06] Try again to bust cache (#7090) nicoback2
[9ad8bc5] Fix esbuild on intel (#7089) Dylan Jeffers
[78460d7] Perform full disk cleanup hourly for self-hosted runners (#7088) Danny
[90f3b13] Add DDEX MVC + DB scaffolding (#7086) Theo Ilie
[a679e5b] Fix uptime optimizely env (#7083) Michelle Brier
[62a618a] Bust turbo web cache (#7081) nicoback2
[643f1d6] [C-3524] Mobile sign-up QA (#7069) Dylan Jeffers
[0cd9acf] [C-3462] Disable native font scaling (#7072) Dylan Jeffers
[9ff4ac9] [C-3546] Upgrade electron (#7071) Dylan Jeffers
[e44ec48] [PROTO-1557] Add DDEX NodeJS backend (#7064) Theo Ilie
[3d25793] Bump version to 0.6.11 audius-infra
[7840090] [Web] Enable connecting wallet to user via new OAuth `write_once` scope [C-3499] (#7045) nicoback2
[34934d7] [C-3425] Add Button component to native harmony (#7038) Kyle Shanks
[a065073] Fix svgr template when no theme (#7076) Dylan Jeffers
[c92b4c6] [Discovery API] Add transaction signature to OAuth JWT payload type (#7075) nicoback2
[f66e31c] Scheduled release UI fixes from QA (#7070) Isaac Solo
[e3ead7f] Sanitize h1 (#7073) Raymond Jacobson
[5bb8bb6] [C-3450] Native Social SignUp (#7000) JD Francis
[26f3249] Add is_scheduled_release field (#7061) Isaac Solo
[d715d6f] [PAY-2289] Fix premium/usdc modal close issues (#7060) Raymond Jacobson
[c2e15dc] Fix native storybook (#7068) Dylan Jeffers
[32333e9] [C-3553] Upgrade all react native deps to latest (#7048) Dylan Jeffers
[954437d] Restrict DDEX logins (#7062) Michelle Brier
[5acff7d] [EM] Allow dashboard wallet to sign EM CreateDashboardWalletUser tx and user to sign `user_signature` in the metadata C-3568 (#7067) nicoback2
[9102cbe] [PAY-2321] Prevent crash if nsure RN module isn't available (#7065) Randy Schott
[1bb061a] [C-3490] Improve profile touch targets (#7053) Dylan Jeffers
[d82052a] [C-3492] Fix podcast popup position (#7054) Dylan Jeffers
[e430ee8] [C-3565] Reduce saga apk size (#7058) Dylan Jeffers
[8d2d6df] Clamp upload percentage (#7049) Dylan Jeffers
[89bf61d] Fix payment method existing balance (#7063) Saliou Diallo
[6e69ecf] [PAY-2281] Fix mobile web purchase modal footer placement (#7059) Raymond Jacobson
[733f140] Bump version to 0.6.10 audius-infra
[7af8ba5] [C-3513] Private albums + show PublishButton for albums (#7055) Andrew Mendelsohn
[5c034eb] [PAY-2320] Fix explore tx link callouts (#7057) Raymond Jacobson
[f7e0852] [C-3566] UploadChip - fix text wrapping (#7056) Andrew Mendelsohn
[7811bb7] Fix schedule release gating (#7051) Isaac Solo
[eccbe31] Tag protocol dashboard `-dev` image (for audius-d) (#7052) endline
[b68a4e4] Fix react-native-svg version (#7050) Dylan Jeffers
[21ffecd] [PAY-2297] Add extra purchase metadata on mobile (#7010) Randy Schott
[9815067] Fix button color darkening (#7047) Dylan Jeffers
[1380e77] Bump version to 0.6.9 audius-infra
[7928e12] Improve sdk track upload logs (#7007) Sebastian Klingler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants