Scheduled release follow ons: usdc to special access, persist selected date, etc #7135

isaacsolo · 2024-01-10T04:37:57Z

Description

Few follow ons

Remove twitter links for scheduled release upload completion. Add back twitter share on pages.
Editing premium to special access had some cache merging behavior allowing a track to have multiple premium conditions. That's now disabled.
Add mobile hint for why hidden is disabled.
Persist selected release date when re-opening modal in upload / create.
Fix transformOnBlur to autocomplete :00 in time.
Disable release now when track is already published.
Small fix for creating a track as hidden then editing to scheduled release. is_scheduled_release should be mutable in discovery indexing.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested flows above on web and mobile in a stage environment.

vercel · 2024-01-10T04:38:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
audius-web-ssr	⬜️ Ignored (Inspect)	Visit Preview		Jan 10, 2024 9:03pm

isaacsolo · 2024-01-10T04:39:14Z

packages/common/src/store/cache/reducer.ts

@@ -89,7 +89,8 @@ const forceUpdateKeys = new Set([
  'followee_reposts',
  'followee_saves',
  'associated_wallets',
-  'associated_sol_wallets'
+  'associated_sol_wallets',
+  'premium_conditions'


with scheduled releases, you can freely change from usdc to special access. sometimes there was merging behavior so a track would have both conditions. this prevents that merging behavior.

isaacsolo · 2024-01-10T04:40:30Z

packages/discovery-provider/src/tasks/metadata.py

@@ -179,7 +179,6 @@ class PlaylistMetadata(TypedDict):
    "track_cid",
    "duration",
    "is_available",
-    "is_scheduled_release",


remove is_scheduled_release here to fix case where a track is uploaded as hidden, then a future release date should make it a scheduled release. removing it as immutable here so a track can go from false to true.

audius-infra · 2024-01-10T04:46:18Z

Preview this change https://demo.audius.co/is-sched-release-qa-2

gitguardian · 2024-01-10T21:04:04Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	Secret	Commit	Filename
9199108	PostgreSQL Credentials	`7f5b479`	packages/trpc-server/README.md	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

…d date, etc (#7135)

…arch * origin/main: (43 commits) rest endpoint for track top_listeners (#7139) [C-3577] Create account logic for native (#7145) Bump version to 0.6.16 [C-3376] Replace harmony enums with string unions (#7149) [C-3588] Show twitter popup on staging (#7147) DDEX tailwind -> harmony (#7126) Pin @types/react to 18.2.0 (#7144) Fix disabled hidden hint for create schedule release (#7143) Scheduled release follow ons: usdc to special access, persist selected date, etc (#7135) Revert unintended trpc changes (#7140) [C-3576] Create account logic for web (#7116) [C-3595 C-3574] Fix Upload share-banner share options (#7136) [C-3567] Add harmony-native text-link (#7137) Add ix_plays_user_item_date index (#7077) Bump version to 0.6.15 Remove konami, segment, clean up Collectible3D (#7131) [C-3433] Add harmony-native password input (#7125) [C-3430] Add SocialButton to native harmony (#7124) [C-3439] Add LoadingSpinner to native harmony (#7127) Allow placeholder postgres urls through secrets check (#7130) ...

[98c86fa] [C-3631] Fix social image uploads by reformatting the types (#7183) JD Francis [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) nicoback2 [c235f08] Add checks for tips/purchases/audio/usdc tx history (#7185) Raymond Jacobson [c1e11d3] Add non full /tracks/<track_id>/top_listeners (#7181) endline [12dfcd0] [C-3627] Add toasts to removeTrackFromPlaylist (#7182) Andrew Mendelsohn [018bbbc] Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466] (#7180) Reed [9d378de] [C-3626, C-3624, C-3628] Fix add to album toast message; Album info to end of track details (#7178) Andrew Mendelsohn [f45b9c5] [C-3572] Update WelcomeModal to prevent blur flashing when button is hovered (#7166) Kyle Shanks [430fa07] Fix payment method bug on native mobile (#7174) Saliou Diallo [7761248] [C-3520] Add Visit Album links to track menus (#7171) Andrew Mendelsohn [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) nicoback2 [60652a0] Fix top_listeners restx schema (#7157) Steve Perkins [aab456d] Bump version to 0.6.17 audius-infra [29eef3a] [C-3522] Add track suggestions to albums (#7170) Andrew Mendelsohn [b950c88] Increment mobile versions (#7169) Raymond Jacobson [245f7f1] Add uploadedBy and improve pagination ends (#7133) Theo Ilie [3e49221] Upgrade react-native-track-player (#7167) Raymond Jacobson [ca99a4c] [C-3618] Fix callback on upload chip (#7162) Andrew Mendelsohn [219762e] [C-3612] Update FinishProfilePage to preserve changes if the user goes back to the handle page (#7163) Kyle Shanks [f4a9b9d] DDEX dockerfile uses turbo (#7164) Michelle Brier [4ef09df] Fix audio matching buyer challenge broken for verified users (#7161) Reed [2d5ea07] Revert "[C-3523] Add create album card to mobile (#7129)" (#7146) Andrew Mendelsohn [89dc49b] Update native harmony BaseButton to not scale when full width (#7159) Kyle Shanks [78eac49] [C-3590] Add handle field positive validation to native (#7160) JD Francis [fda09d4] [C-3611] Add back button for select artists page to return to genres (#7158) Kyle Shanks [b5155af] [C-3613] Add error feedback for new sign up flow handle input (#7154) Kyle Shanks [94b75dd] [C-3610] Positive validation for sign up handles on web (#7148) JD Francis [c8bb29a] DDEX admin UI (#7151) Michelle Brier [a0a5c01] rest endpoint for track top_listeners (#7139) Steve Perkins [700aba0] [C-3577] Create account logic for native (#7145) JD Francis [3fdc293] Bump version to 0.6.16 audius-infra [1b1a133] [C-3376] Replace harmony enums with string unions (#7149) Dylan Jeffers [ff01ec6] [C-3588] Show twitter popup on staging (#7147) JD Francis [9a518c8] DDEX tailwind -> harmony (#7126) Michelle Brier [6f8c05a] Pin @types/react to 18.2.0 (#7144) Dylan Jeffers [0cbec79] Fix disabled hidden hint for create schedule release (#7143) Isaac Solo [cb181e7] Scheduled release follow ons: usdc to special access, persist selected date, etc (#7135) Isaac Solo [883064e] Revert unintended trpc changes (#7140) Andrew Mendelsohn [4db458c] [C-3576] Create account logic for web (#7116) JD Francis [264bbe9] [C-3595 C-3574] Fix Upload share-banner share options (#7136) Dylan Jeffers [31e589c] [C-3567] Add harmony-native text-link (#7137) Dylan Jeffers [c45d774] Add ix_plays_user_item_date index (#7077) Steve Perkins [41e48c2] Bump version to 0.6.15 audius-infra [d94e776] Remove konami, segment, clean up Collectible3D (#7131) Raymond Jacobson [8fa6fd2] [C-3433] Add harmony-native password input (#7125) Dylan Jeffers [1c07e8a] [C-3430] Add SocialButton to native harmony (#7124) Kyle Shanks [b58ed05] [C-3439] Add LoadingSpinner to native harmony (#7127) Kyle Shanks [f172545] Allow placeholder postgres urls through secrets check (#7130) Andrew Mendelsohn [087d4a3] [C-3523] Add create album card to mobile (#7129) Andrew Mendelsohn [aff1457] [C-3593] signUp straight to jail (#7128) JD Francis [efa999e] [PROTO-1489] [PROTO-1512] Add endpoints + UI for paginating ddex uploads and releases (#7117) Theo Ilie [7531750] Fix track-availability hook dependencies (#7122) Dylan Jeffers [1d5110a] [C-3426] Add PlainButton to native harmony (#7121) Kyle Shanks [274bc9c] Support creating dashboard wallet user in SDK (#7106) nicoback2 [98da601] [C-3407] Error messages for invalid profile image uploads (#7107) JD Francis [d525f5e] Revert adding extra icon (#7092) nicoback2 [d7ed4fa] [C-3573] Persist email across all 3 sign up pages (#7105) JD Francis [8a44190] [C-3432] Add harmony-native text-input (#7113) Dylan Jeffers [fea264c] [PAY-2334] Add lossless downloads feature flag (#7120) Reed [42c4571] Bump version to 0.6.14 audius-infra [6a2b3f2] [PAY-2340] Fix dms playlist unfurl (#7119) Saliou Diallo [45ad02c] Scheduled release publishing confirmation (#7115) Isaac Solo [88ca790] Fix issues found in 1.5.59 release (#7118) Dylan Jeffers [54ffb7d] Fix ios build by patching boost (#7114) Dylan Jeffers [096ae53] DDEX uses sdk oauth (#7110) Michelle Brier [83a498b] Fix trpc-server ci cache (#7111) Dylan Jeffers [2c0bb12] Schedule release disables hidden + editable release date on web (#7078) Isaac Solo [c7acefe] Remove DDEX .gitignore (#7112) Michelle Brier [34049db] Track ddex frontend changes and install uuid (#7109) Theo Ilie [e5f0607] [PROTO-1489] [PROTO-1512] Add ddex queue flows with db persistence (#7102) Theo Ilie [de73a4a] Enable schedule release job (#7108) Isaac Solo [272120d] Bump version to 0.6.13 audius-infra

[cf14a3c] [C-3622] Exclude 'Visit Album' from menus when already on album page (#7179) Andrew Mendelsohn [54d8c62] [C-3583] Improve radial-gradient, update social-button (#7176) Dylan Jeffers [c4c4938] Prepare for full app release 1.1.81 (#7191) Dylan Jeffers [6e2927a] repairEntityManagerUserV2 (#7189) Marcus Pasell [c030b99] Revert "Revert "Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466]"" (#7190) JD Francis [2b5cc0e] v1.5.60 (#7187) Raymond Jacobson [62d7f86] Revert "Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466]" (#7188) JD Francis [98c86fa] [C-3631] Fix social image uploads by reformatting the types (#7183) JD Francis [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) nicoback2 [c235f08] Add checks for tips/purchases/audio/usdc tx history (#7185) Raymond Jacobson [c1e11d3] Add non full /tracks/<track_id>/top_listeners (#7181) endline [12dfcd0] [C-3627] Add toasts to removeTrackFromPlaylist (#7182) Andrew Mendelsohn [018bbbc] Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466] (#7180) Reed [9d378de] [C-3626, C-3624, C-3628] Fix add to album toast message; Album info to end of track details (#7178) Andrew Mendelsohn [f45b9c5] [C-3572] Update WelcomeModal to prevent blur flashing when button is hovered (#7166) Kyle Shanks [430fa07] Fix payment method bug on native mobile (#7174) Saliou Diallo [7761248] [C-3520] Add Visit Album links to track menus (#7171) Andrew Mendelsohn [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) nicoback2 [60652a0] Fix top_listeners restx schema (#7157) Steve Perkins [aab456d] Bump version to 0.6.17 audius-infra [29eef3a] [C-3522] Add track suggestions to albums (#7170) Andrew Mendelsohn [b950c88] Increment mobile versions (#7169) Raymond Jacobson [245f7f1] Add uploadedBy and improve pagination ends (#7133) Theo Ilie [3e49221] Upgrade react-native-track-player (#7167) Raymond Jacobson [ca99a4c] [C-3618] Fix callback on upload chip (#7162) Andrew Mendelsohn [219762e] [C-3612] Update FinishProfilePage to preserve changes if the user goes back to the handle page (#7163) Kyle Shanks [f4a9b9d] DDEX dockerfile uses turbo (#7164) Michelle Brier [4ef09df] Fix audio matching buyer challenge broken for verified users (#7161) Reed [2d5ea07] Revert "[C-3523] Add create album card to mobile (#7129)" (#7146) Andrew Mendelsohn [89dc49b] Update native harmony BaseButton to not scale when full width (#7159) Kyle Shanks [78eac49] [C-3590] Add handle field positive validation to native (#7160) JD Francis [fda09d4] [C-3611] Add back button for select artists page to return to genres (#7158) Kyle Shanks [b5155af] [C-3613] Add error feedback for new sign up flow handle input (#7154) Kyle Shanks [94b75dd] [C-3610] Positive validation for sign up handles on web (#7148) JD Francis [c8bb29a] DDEX admin UI (#7151) Michelle Brier [a0a5c01] rest endpoint for track top_listeners (#7139) Steve Perkins [700aba0] [C-3577] Create account logic for native (#7145) JD Francis [3fdc293] Bump version to 0.6.16 audius-infra [1b1a133] [C-3376] Replace harmony enums with string unions (#7149) Dylan Jeffers [ff01ec6] [C-3588] Show twitter popup on staging (#7147) JD Francis [9a518c8] DDEX tailwind -> harmony (#7126) Michelle Brier [6f8c05a] Pin @types/react to 18.2.0 (#7144) Dylan Jeffers [0cbec79] Fix disabled hidden hint for create schedule release (#7143) Isaac Solo [cb181e7] Scheduled release follow ons: usdc to special access, persist selected date, etc (#7135) Isaac Solo [883064e] Revert unintended trpc changes (#7140) Andrew Mendelsohn [4db458c] [C-3576] Create account logic for web (#7116) JD Francis [264bbe9] [C-3595 C-3574] Fix Upload share-banner share options (#7136) Dylan Jeffers [31e589c] [C-3567] Add harmony-native text-link (#7137) Dylan Jeffers [c45d774] Add ix_plays_user_item_date index (#7077) Steve Perkins [41e48c2] Bump version to 0.6.15 audius-infra [d94e776] Remove konami, segment, clean up Collectible3D (#7131) Raymond Jacobson [8fa6fd2] [C-3433] Add harmony-native password input (#7125) Dylan Jeffers [1c07e8a] [C-3430] Add SocialButton to native harmony (#7124) Kyle Shanks [b58ed05] [C-3439] Add LoadingSpinner to native harmony (#7127) Kyle Shanks [f172545] Allow placeholder postgres urls through secrets check (#7130) Andrew Mendelsohn [087d4a3] [C-3523] Add create album card to mobile (#7129) Andrew Mendelsohn [aff1457] [C-3593] signUp straight to jail (#7128) JD Francis [efa999e] [PROTO-1489] [PROTO-1512] Add endpoints + UI for paginating ddex uploads and releases (#7117) Theo Ilie [7531750] Fix track-availability hook dependencies (#7122) Dylan Jeffers [1d5110a] [C-3426] Add PlainButton to native harmony (#7121) Kyle Shanks [274bc9c] Support creating dashboard wallet user in SDK (#7106) nicoback2 [98da601] [C-3407] Error messages for invalid profile image uploads (#7107) JD Francis [d525f5e] Revert adding extra icon (#7092) nicoback2 [d7ed4fa] [C-3573] Persist email across all 3 sign up pages (#7105) JD Francis [8a44190] [C-3432] Add harmony-native text-input (#7113) Dylan Jeffers [fea264c] [PAY-2334] Add lossless downloads feature flag (#7120) Reed [42c4571] Bump version to 0.6.14 audius-infra [6a2b3f2] [PAY-2340] Fix dms playlist unfurl (#7119) Saliou Diallo [45ad02c] Scheduled release publishing confirmation (#7115) Isaac Solo [88ca790] Fix issues found in 1.5.59 release (#7118) Dylan Jeffers [54ffb7d] Fix ios build by patching boost (#7114) Dylan Jeffers [096ae53] DDEX uses sdk oauth (#7110) Michelle Brier [83a498b] Fix trpc-server ci cache (#7111) Dylan Jeffers [2c0bb12] Schedule release disables hidden + editable release date on web (#7078) Isaac Solo [c7acefe] Remove DDEX .gitignore (#7112) Michelle Brier [34049db] Track ddex frontend changes and install uuid (#7109) Theo Ilie [e5f0607] [PROTO-1489] [PROTO-1512] Add ddex queue flows with db persistence (#7102) Theo Ilie [de73a4a] Enable schedule release job (#7108) Isaac Solo [272120d] Bump version to 0.6.13 audius-infra

isaacsolo added 3 commits January 9, 2024 16:15

working

6bc9e15

lint clean

cd1e75c

confirm release now button + fix usdc -> spec access case

15b220c

pull-request-size bot added the size/L label Jan 10, 2024

isaacsolo requested a review from sddioulde January 10, 2024 04:38

isaacsolo commented Jan 10, 2024

View reviewed changes

sddioulde approved these changes Jan 10, 2024

View reviewed changes

remove twitter link on mobile

8190002

isaacsolo enabled auto-merge (squash) January 10, 2024 20:52

isaacsolo added 2 commits January 10, 2024 13:00

Merge branch 'main' into is-sched-release-qa-2

7f5b479

remove share your new track clean merge

d25d877

isaacsolo disabled auto-merge January 10, 2024 21:04

isaacsolo merged commit cb181e7 into main Jan 10, 2024
14 of 18 checks passed

isaacsolo deleted the is-sched-release-qa-2 branch January 10, 2024 21:12

isaacsolo added a commit that referenced this pull request Jan 10, 2024

Scheduled release follow ons: usdc to special access, persist selecte…

26d47b8

…d date, etc (#7135)

isaacsolo added a commit that referenced this pull request Jan 10, 2024

Scheduled release follow ons: usdc to special access, persist selecte…

f798697

…d date, etc (#7135)

raymondjacobson mentioned this pull request Jan 13, 2024

v1.5.60 #7187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Scheduled release follow ons: usdc to special access, persist selected date, etc #7135

Scheduled release follow ons: usdc to special access, persist selected date, etc #7135

isaacsolo commented Jan 10, 2024 •

edited

Loading

vercel bot commented Jan 10, 2024 •

edited

Loading

isaacsolo Jan 10, 2024

isaacsolo Jan 10, 2024

audius-infra commented Jan 10, 2024

gitguardian bot commented Jan 10, 2024

Scheduled release follow ons: usdc to special access, persist selected date, etc #7135

Scheduled release follow ons: usdc to special access, persist selected date, etc #7135

Conversation

isaacsolo commented Jan 10, 2024 • edited Loading

Description

How Has This Been Tested?

vercel bot commented Jan 10, 2024 • edited Loading

isaacsolo Jan 10, 2024

Choose a reason for hiding this comment

isaacsolo Jan 10, 2024

Choose a reason for hiding this comment

audius-infra commented Jan 10, 2024

gitguardian bot commented Jan 10, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

isaacsolo commented Jan 10, 2024 •

edited

Loading

vercel bot commented Jan 10, 2024 •

edited

Loading