[C-3522] Add track suggestions to albums #7170

amendelsohn · 2024-01-12T02:27:20Z

Description

Add SuggestedTracks to albums

Web:

Mobile:

How Has This Been Tested?

local web & mobile

vercel · 2024-01-12T02:27:26Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
audius-web-ssr	⬜️ Ignored (Inspect)	Visit Preview		Jan 12, 2024 7:17am

audius-infra · 2024-01-12T02:32:03Z

Preview this change https://demo.audius.co/am-album-suggested-tracks

dylanjeffers

Super clean and easy to follow after our architecture discussion on it.

dylanjeffers · 2024-01-12T02:46:46Z

packages/common/src/api/suggestedTracks.ts

+  const [suggestedTrackIds, setSuggestedTrackIds] = useState<ID[]>([])
+  const [isRefreshing, setIsRefreshing] = useState(false)
+
+  const collectionTrackIds = useSelector((state: CommonState) =>


Good looks to diff these out

dylanjeffers · 2024-01-12T02:47:03Z

packages/common/src/api/suggestedTracks.ts

+
+  useEffect(() => {
+    if (ownTracks?.length) {
+      const suggestedTrackIds = difference(


What a line!

dylanjeffers · 2024-01-12T02:47:28Z

packages/common/src/api/suggestedTracks.ts

+  useEffect(() => {
+    if (ownTracks?.length) {
+      const suggestedTrackIds = difference(
+        shuffle(ownTracks).map((track) => parseInt(track.track_id.toString())),


How come we parse int a tostring?

dylanjeffers · 2024-01-12T02:48:14Z

packages/common/src/api/suggestedTracks.ts

@@ -148,13 +213,13 @@ export const useGetSuggestedTracks = (collectionId: ID) => {
  )

  const handleAddTrack = useCallback(
-    (trackId: ID, collectionId: ID) => {


Nice improvement

dylanjeffers · 2024-01-12T02:48:33Z

packages/common/src/api/user.ts

@@ -68,7 +68,6 @@ const userApi = createApi({
        return apiUser?.[0]
      },
      options: {
-        idArgKey: 'handle',


Sup with this?

That isn't the right value to be passing. idArgKey should be the name of the arg containing the id of the entity you're getting.

As written, it would be looking for the handle as an existing id in the users cache. We don't have a way to do that for non-id fields currently, so removing it is correct. Just a campground improvement.

dylanjeffers · 2024-01-12T02:49:02Z

packages/common/src/api/user.ts

+        audiusQueryContext
+      ) => {
+        const { apiClient } = audiusQueryContext
+        const { handle } = await userApiFetch.getUserById(


Love that we can use the fetch from other apis

dylanjeffers · 2024-01-12T02:50:13Z

packages/mobile/src/components/suggested-tracks/SuggestedCollectionTracks.tsx

+}
+
+export const SuggestedCollectionTracks = (
+  props: SuggestedCollectionTracksProps


I see so just easier to use this one component in both places and pass a prop in?

You don't even need a prop. collectionId is sufficient to differentiate between collectionTypes since we're selecting the collection anyway.

dylanjeffers · 2024-01-12T02:51:49Z

packages/mobile/src/components/suggested-tracks/components/SuggestedTracks.tsx

-            {messages.title}
-          </Text>
+      <TouchableOpacity onPress={handleExpanded}>
+        <View style={styles.heading}>


Does it make sense to have handleExpanded on both the icon and the row? Maybe just make the row and drop the button icon in favor of just icon? Or do we want the animation on icon for press still? Maybe this is okay for a11y cause we need some button element which this services. Does the handle get called twice when clicking the arrow though?

dylanjeffers · 2024-01-12T02:52:43Z

packages/probers/cypress/e2e/favoriteTrack.cy.ts

@@ -12,7 +12,9 @@ describe('Favorite Track', () => {
    const base64Entropy = Buffer.from(user.entropy).toString('base64')
    cy.visit(`${track.route}?login=${base64Entropy}`)

-    cy.findByText(user.name, { timeout: Cypress.env('initialLoadTimeout') }).should('exist')
+    cy.findByText(user.name, {
+      timeout: Cypress.env('initialLoadTimeout')


wtf I didn't change this or the other tests... 😵 reverting those changes

audius-infra · 2024-01-12T06:14:06Z

Preview this change https://demo.audius.co/am-album-suggested-tracks

audius-infra · 2024-01-12T07:28:33Z

Preview this change https://demo.audius.co/am-album-suggested-tracks

[98c86fa] [C-3631] Fix social image uploads by reformatting the types (#7183) JD Francis [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) nicoback2 [c235f08] Add checks for tips/purchases/audio/usdc tx history (#7185) Raymond Jacobson [c1e11d3] Add non full /tracks/<track_id>/top_listeners (#7181) endline [12dfcd0] [C-3627] Add toasts to removeTrackFromPlaylist (#7182) Andrew Mendelsohn [018bbbc] Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466] (#7180) Reed [9d378de] [C-3626, C-3624, C-3628] Fix add to album toast message; Album info to end of track details (#7178) Andrew Mendelsohn [f45b9c5] [C-3572] Update WelcomeModal to prevent blur flashing when button is hovered (#7166) Kyle Shanks [430fa07] Fix payment method bug on native mobile (#7174) Saliou Diallo [7761248] [C-3520] Add Visit Album links to track menus (#7171) Andrew Mendelsohn [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) nicoback2 [60652a0] Fix top_listeners restx schema (#7157) Steve Perkins [aab456d] Bump version to 0.6.17 audius-infra [29eef3a] [C-3522] Add track suggestions to albums (#7170) Andrew Mendelsohn [b950c88] Increment mobile versions (#7169) Raymond Jacobson [245f7f1] Add uploadedBy and improve pagination ends (#7133) Theo Ilie [3e49221] Upgrade react-native-track-player (#7167) Raymond Jacobson [ca99a4c] [C-3618] Fix callback on upload chip (#7162) Andrew Mendelsohn [219762e] [C-3612] Update FinishProfilePage to preserve changes if the user goes back to the handle page (#7163) Kyle Shanks [f4a9b9d] DDEX dockerfile uses turbo (#7164) Michelle Brier [4ef09df] Fix audio matching buyer challenge broken for verified users (#7161) Reed [2d5ea07] Revert "[C-3523] Add create album card to mobile (#7129)" (#7146) Andrew Mendelsohn [89dc49b] Update native harmony BaseButton to not scale when full width (#7159) Kyle Shanks [78eac49] [C-3590] Add handle field positive validation to native (#7160) JD Francis [fda09d4] [C-3611] Add back button for select artists page to return to genres (#7158) Kyle Shanks [b5155af] [C-3613] Add error feedback for new sign up flow handle input (#7154) Kyle Shanks [94b75dd] [C-3610] Positive validation for sign up handles on web (#7148) JD Francis [c8bb29a] DDEX admin UI (#7151) Michelle Brier [a0a5c01] rest endpoint for track top_listeners (#7139) Steve Perkins [700aba0] [C-3577] Create account logic for native (#7145) JD Francis [3fdc293] Bump version to 0.6.16 audius-infra [1b1a133] [C-3376] Replace harmony enums with string unions (#7149) Dylan Jeffers [ff01ec6] [C-3588] Show twitter popup on staging (#7147) JD Francis [9a518c8] DDEX tailwind -> harmony (#7126) Michelle Brier [6f8c05a] Pin @types/react to 18.2.0 (#7144) Dylan Jeffers [0cbec79] Fix disabled hidden hint for create schedule release (#7143) Isaac Solo [cb181e7] Scheduled release follow ons: usdc to special access, persist selected date, etc (#7135) Isaac Solo [883064e] Revert unintended trpc changes (#7140) Andrew Mendelsohn [4db458c] [C-3576] Create account logic for web (#7116) JD Francis [264bbe9] [C-3595 C-3574] Fix Upload share-banner share options (#7136) Dylan Jeffers [31e589c] [C-3567] Add harmony-native text-link (#7137) Dylan Jeffers [c45d774] Add ix_plays_user_item_date index (#7077) Steve Perkins [41e48c2] Bump version to 0.6.15 audius-infra [d94e776] Remove konami, segment, clean up Collectible3D (#7131) Raymond Jacobson [8fa6fd2] [C-3433] Add harmony-native password input (#7125) Dylan Jeffers [1c07e8a] [C-3430] Add SocialButton to native harmony (#7124) Kyle Shanks [b58ed05] [C-3439] Add LoadingSpinner to native harmony (#7127) Kyle Shanks [f172545] Allow placeholder postgres urls through secrets check (#7130) Andrew Mendelsohn [087d4a3] [C-3523] Add create album card to mobile (#7129) Andrew Mendelsohn [aff1457] [C-3593] signUp straight to jail (#7128) JD Francis [efa999e] [PROTO-1489] [PROTO-1512] Add endpoints + UI for paginating ddex uploads and releases (#7117) Theo Ilie [7531750] Fix track-availability hook dependencies (#7122) Dylan Jeffers [1d5110a] [C-3426] Add PlainButton to native harmony (#7121) Kyle Shanks [274bc9c] Support creating dashboard wallet user in SDK (#7106) nicoback2 [98da601] [C-3407] Error messages for invalid profile image uploads (#7107) JD Francis [d525f5e] Revert adding extra icon (#7092) nicoback2 [d7ed4fa] [C-3573] Persist email across all 3 sign up pages (#7105) JD Francis [8a44190] [C-3432] Add harmony-native text-input (#7113) Dylan Jeffers [fea264c] [PAY-2334] Add lossless downloads feature flag (#7120) Reed [42c4571] Bump version to 0.6.14 audius-infra [6a2b3f2] [PAY-2340] Fix dms playlist unfurl (#7119) Saliou Diallo [45ad02c] Scheduled release publishing confirmation (#7115) Isaac Solo [88ca790] Fix issues found in 1.5.59 release (#7118) Dylan Jeffers [54ffb7d] Fix ios build by patching boost (#7114) Dylan Jeffers [096ae53] DDEX uses sdk oauth (#7110) Michelle Brier [83a498b] Fix trpc-server ci cache (#7111) Dylan Jeffers [2c0bb12] Schedule release disables hidden + editable release date on web (#7078) Isaac Solo [c7acefe] Remove DDEX .gitignore (#7112) Michelle Brier [34049db] Track ddex frontend changes and install uuid (#7109) Theo Ilie [e5f0607] [PROTO-1489] [PROTO-1512] Add ddex queue flows with db persistence (#7102) Theo Ilie [de73a4a] Enable schedule release job (#7108) Isaac Solo [272120d] Bump version to 0.6.13 audius-infra

[cf14a3c] [C-3622] Exclude 'Visit Album' from menus when already on album page (#7179) Andrew Mendelsohn [54d8c62] [C-3583] Improve radial-gradient, update social-button (#7176) Dylan Jeffers [c4c4938] Prepare for full app release 1.1.81 (#7191) Dylan Jeffers [6e2927a] repairEntityManagerUserV2 (#7189) Marcus Pasell [c030b99] Revert "Revert "Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466]"" (#7190) JD Francis [2b5cc0e] v1.5.60 (#7187) Raymond Jacobson [62d7f86] Revert "Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466]" (#7188) JD Francis [98c86fa] [C-3631] Fix social image uploads by reformatting the types (#7183) JD Francis [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) nicoback2 [c235f08] Add checks for tips/purchases/audio/usdc tx history (#7185) Raymond Jacobson [c1e11d3] Add non full /tracks/<track_id>/top_listeners (#7181) endline [12dfcd0] [C-3627] Add toasts to removeTrackFromPlaylist (#7182) Andrew Mendelsohn [018bbbc] Revert "[Mobile] Fix profile + cover pic not uploading upon social sign up [C-3466] (#7180) Reed [9d378de] [C-3626, C-3624, C-3628] Fix add to album toast message; Album info to end of track details (#7178) Andrew Mendelsohn [f45b9c5] [C-3572] Update WelcomeModal to prevent blur flashing when button is hovered (#7166) Kyle Shanks [430fa07] Fix payment method bug on native mobile (#7174) Saliou Diallo [7761248] [C-3520] Add Visit Album links to track menus (#7171) Andrew Mendelsohn [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) nicoback2 [60652a0] Fix top_listeners restx schema (#7157) Steve Perkins [aab456d] Bump version to 0.6.17 audius-infra [29eef3a] [C-3522] Add track suggestions to albums (#7170) Andrew Mendelsohn [b950c88] Increment mobile versions (#7169) Raymond Jacobson [245f7f1] Add uploadedBy and improve pagination ends (#7133) Theo Ilie [3e49221] Upgrade react-native-track-player (#7167) Raymond Jacobson [ca99a4c] [C-3618] Fix callback on upload chip (#7162) Andrew Mendelsohn [219762e] [C-3612] Update FinishProfilePage to preserve changes if the user goes back to the handle page (#7163) Kyle Shanks [f4a9b9d] DDEX dockerfile uses turbo (#7164) Michelle Brier [4ef09df] Fix audio matching buyer challenge broken for verified users (#7161) Reed [2d5ea07] Revert "[C-3523] Add create album card to mobile (#7129)" (#7146) Andrew Mendelsohn [89dc49b] Update native harmony BaseButton to not scale when full width (#7159) Kyle Shanks [78eac49] [C-3590] Add handle field positive validation to native (#7160) JD Francis [fda09d4] [C-3611] Add back button for select artists page to return to genres (#7158) Kyle Shanks [b5155af] [C-3613] Add error feedback for new sign up flow handle input (#7154) Kyle Shanks [94b75dd] [C-3610] Positive validation for sign up handles on web (#7148) JD Francis [c8bb29a] DDEX admin UI (#7151) Michelle Brier [a0a5c01] rest endpoint for track top_listeners (#7139) Steve Perkins [700aba0] [C-3577] Create account logic for native (#7145) JD Francis [3fdc293] Bump version to 0.6.16 audius-infra [1b1a133] [C-3376] Replace harmony enums with string unions (#7149) Dylan Jeffers [ff01ec6] [C-3588] Show twitter popup on staging (#7147) JD Francis [9a518c8] DDEX tailwind -> harmony (#7126) Michelle Brier [6f8c05a] Pin @types/react to 18.2.0 (#7144) Dylan Jeffers [0cbec79] Fix disabled hidden hint for create schedule release (#7143) Isaac Solo [cb181e7] Scheduled release follow ons: usdc to special access, persist selected date, etc (#7135) Isaac Solo [883064e] Revert unintended trpc changes (#7140) Andrew Mendelsohn [4db458c] [C-3576] Create account logic for web (#7116) JD Francis [264bbe9] [C-3595 C-3574] Fix Upload share-banner share options (#7136) Dylan Jeffers [31e589c] [C-3567] Add harmony-native text-link (#7137) Dylan Jeffers [c45d774] Add ix_plays_user_item_date index (#7077) Steve Perkins [41e48c2] Bump version to 0.6.15 audius-infra [d94e776] Remove konami, segment, clean up Collectible3D (#7131) Raymond Jacobson [8fa6fd2] [C-3433] Add harmony-native password input (#7125) Dylan Jeffers [1c07e8a] [C-3430] Add SocialButton to native harmony (#7124) Kyle Shanks [b58ed05] [C-3439] Add LoadingSpinner to native harmony (#7127) Kyle Shanks [f172545] Allow placeholder postgres urls through secrets check (#7130) Andrew Mendelsohn [087d4a3] [C-3523] Add create album card to mobile (#7129) Andrew Mendelsohn [aff1457] [C-3593] signUp straight to jail (#7128) JD Francis [efa999e] [PROTO-1489] [PROTO-1512] Add endpoints + UI for paginating ddex uploads and releases (#7117) Theo Ilie [7531750] Fix track-availability hook dependencies (#7122) Dylan Jeffers [1d5110a] [C-3426] Add PlainButton to native harmony (#7121) Kyle Shanks [274bc9c] Support creating dashboard wallet user in SDK (#7106) nicoback2 [98da601] [C-3407] Error messages for invalid profile image uploads (#7107) JD Francis [d525f5e] Revert adding extra icon (#7092) nicoback2 [d7ed4fa] [C-3573] Persist email across all 3 sign up pages (#7105) JD Francis [8a44190] [C-3432] Add harmony-native text-input (#7113) Dylan Jeffers [fea264c] [PAY-2334] Add lossless downloads feature flag (#7120) Reed [42c4571] Bump version to 0.6.14 audius-infra [6a2b3f2] [PAY-2340] Fix dms playlist unfurl (#7119) Saliou Diallo [45ad02c] Scheduled release publishing confirmation (#7115) Isaac Solo [88ca790] Fix issues found in 1.5.59 release (#7118) Dylan Jeffers [54ffb7d] Fix ios build by patching boost (#7114) Dylan Jeffers [096ae53] DDEX uses sdk oauth (#7110) Michelle Brier [83a498b] Fix trpc-server ci cache (#7111) Dylan Jeffers [2c0bb12] Schedule release disables hidden + editable release date on web (#7078) Isaac Solo [c7acefe] Remove DDEX .gitignore (#7112) Michelle Brier [34049db] Track ddex frontend changes and install uuid (#7109) Theo Ilie [e5f0607] [PROTO-1489] [PROTO-1512] Add ddex queue flows with db persistence (#7102) Theo Ilie [de73a4a] Enable schedule release job (#7108) Isaac Solo [272120d] Bump version to 0.6.13 audius-infra

amendelsohn added 6 commits January 10, 2024 16:03

add getTracksByUser to audius-query

3a3fda2

wip

c1cabe8

Merge branch 'main' into am-album-suggested-tracks

3faabc2

fetching works

598bb35

improve onclick

9d40e19

done

4b83b77

amendelsohn requested review from dylanjeffers and a team January 12, 2024 02:27

pull-request-size bot added the size/L label Jan 12, 2024

dylanjeffers approved these changes Jan 12, 2024

View reviewed changes

amendelsohn added 2 commits January 11, 2024 21:53

fix shuffling (hack)

99ea064

address feedback

9bd7438

fix error on loading

331be41

amendelsohn merged commit 29eef3a into main Jan 12, 2024
21 checks passed

amendelsohn deleted the am-album-suggested-tracks branch January 12, 2024 08:08

raymondjacobson mentioned this pull request Jan 13, 2024

v1.5.60 #7187

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-3522] Add track suggestions to albums #7170

[C-3522] Add track suggestions to albums #7170

amendelsohn commented Jan 12, 2024

vercel bot commented Jan 12, 2024 •

edited

Loading

audius-infra commented Jan 12, 2024

dylanjeffers left a comment

dylanjeffers Jan 12, 2024

dylanjeffers Jan 12, 2024

dylanjeffers Jan 12, 2024

dylanjeffers Jan 12, 2024

dylanjeffers Jan 12, 2024

amendelsohn Jan 12, 2024

dylanjeffers Jan 12, 2024

dylanjeffers Jan 12, 2024

amendelsohn Jan 12, 2024

dylanjeffers Jan 12, 2024

dylanjeffers Jan 12, 2024

amendelsohn Jan 12, 2024

audius-infra commented Jan 12, 2024

audius-infra commented Jan 12, 2024

[C-3522] Add track suggestions to albums #7170

[C-3522] Add track suggestions to albums #7170

Conversation

amendelsohn commented Jan 12, 2024

Description

How Has This Been Tested?

vercel bot commented Jan 12, 2024 • edited Loading

audius-infra commented Jan 12, 2024

dylanjeffers left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

audius-infra commented Jan 12, 2024

audius-infra commented Jan 12, 2024

vercel bot commented Jan 12, 2024 •

edited

Loading