⚠️ [ONC-19] Error on failed gas estimation #7569

raymondjacobson · 2024-02-13T02:58:53Z

Description

When you perform certain actions on the protocol dashboard where gas estimation fails (likely because transaction simulation shows that the tx itself would fail), we pass a huge default gas limit along to ensure that the transaction never runs out of gas. In practice, the transaction likely fails anyway because simulation failed and you end up using some small amount of the insanely high gas limit.

Couple changes:

⚠️ estimate gas can throw an error instead of falling back to the default and will do so for all protocol dashboard<>metamask interactions (ethWeb3Manager.sendTransaction with an external wallet). Metamask does their own gas estimation, so don't even pass our estimation along, but try to estimate for the UX benefit of quitting early
sdk(libs)/discovery: Have multi provider error the last error instead of 'All Requests Failed' (finally figured out where this comes from....)
fix confirmation modal for transactions so that when it errors, it clears state (similar to other confirmations)
Parse out the error before the line-break as metamask gives a giant string error sometimes instead of something nicely parseable

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Error in simulation exposed:

Using metamask's gas estimation:

audius-infra · 2024-02-13T03:16:06Z

Preview this change https://demo.audius.co/rj-gas-estimation-fixes

nicoback2 · 2024-02-14T22:43:05Z

packages/discovery-provider/src/utils/multi_provider.py

                continue
-        raise Exception("All requests failed")
+        raise last_exception if last_exception else Exception()


i think i'm probably reading this wrong... but won't this raise an exception every time?

early return on line 20 if any request succeeds, so this just makes it throw a more useful error if nothing succeeds

nicoback2 · 2024-02-14T22:43:48Z

packages/libs/src/services/ethWeb3Manager/EthWeb3Manager.ts

    const gasLimit =
      txGasLimit ??
      (await estimateGas({
        method: contractMethod,
        from: this.ownerWallet,
-        gasLimitMaximum: MAX_GAS_LIMIT
+        gasLimitMaximum: MAX_GAS_LIMIT,
+        shouldThrow: !internalWallet


why not just throw before we call estimateGas if !internalWallet?

oh nvm, i see the other comment now

nicoback2 · 2024-02-14T22:45:10Z

packages/libs/src/utils/estimateGas.ts

  multiplier?: number
+  // Whether or not to throw if gas estimation fails. Usually this signals that a
+  // contract call's simulation failed and likely the actual contract call will fail.
+  shouldThrow?: boolean


shouldThrowIfGasEstimationFails might be an annoyingly long but better name - shouldThrow makes it sound like it should always throw

I like that!

nicoback2 · 2024-02-14T22:46:40Z

packages/libs/src/utils/multiProvider.ts

      }
    }

-    throw new Error('All requests failed')
+    throw lastError || new Error()


maybe add a message to the generic Error here so it's easy to trace where it came from

nice. this only throws if there is no RPC provided, so I'll make that an explicit message and update the multi_provider.py one too

nicoback2 · 2024-02-14T22:50:53Z

protocol-dashboard/src/components/TransactionStatus/TransactionStatus.tsx

@@ -78,7 +78,7 @@ const WaitingTransaction: React.FC<WaitingTransactionProps> = props => {
    setError,
    setStatus,
    cancelTransaction
-  } = useCancelTransaction(props.name)
+  } = useCancelTransaction(props.name, !isOpen)


would prefer if this hook returned a fn reset that's called in this component in a useEffect, to make the behavior more predictable

but if you want to go this route could you change the params be named params (instead of positional)? client + money decided that if there are 2+ params they should be named

This is the same pattern used across most of the hooks (10+) in the protocol dashboard for fetching data. I'll make a ticket for that work, totally agree that the return reset pattern is way better/safer. But want to be careful to not touch too many things here and I think having consistency at least for now is good.

https://linear.app/audius/issue/C-3831/protocol-dashboard-hooks-should-return-a-resetclean-up-fn-instead-of

nicoback2 · 2024-02-14T22:51:01Z

protocol-dashboard/src/components/TransactionStatus/TransactionStatus.tsx

  const {
    status: submitStatus,
    error: submitError,
    submitTransaction
-  } = useSubmitTransaction(props.name)
+  } = useSubmitTransaction(props.name, !isSubmitOpen)


nicoback2

lgtm

audius-infra · 2024-02-14T23:16:44Z

Preview this change https://demo.audius.co/rj-gas-estimation-fixes

[533a178] Fix release tag reference (#7660) Dylan Jeffers [87f0b90] [PAY-2512] Add more audio file type icons (#7658) Saliou Diallo [93018df] Bump version to 0.6.42 audius-infra [5693187] Fix generate-client-release script version (#7657) Dylan Jeffers [58f6fd5] [C-3851] Remove all "harmony" components from stems (#7637) Dylan Jeffers [206d386] Allow CI workflows to be manually triggered (#7656) Raymond Jacobson [eaacf44] [PROTO-1667] Add DDEX sessions and admin+artist auth (#7645) Theo Ilie [04bb965] PROTO-1574: sepolia config and register all nodes (#7648) alecsavvy [49ff569] [ONC-17] Remove hotkeys on unmount of playbar to prevent double-triggers (#7654) Randy Schott [f6b21ac] make dominant_genre_count nullable (#7653) Steve Perkins [e8a45c5] [PAY-2508] Fix download lossless mp3 failure (#7646) Saliou Diallo [fce5455] Fix native track-list play/pause icons (#7649) Dylan Jeffers [0db255e] Disable related artists job (#7652) Isaac Solo [73cab49] Bump version to 0.6.41 audius-infra [a522345] Bump version to 0.6.40 audius-infra [aa5fa95] Update dapp-store build artifacts audius-infra [99e5580] fix self album share button (#7647) alecsavvy [d7d42a2] Fix wallet connect icons [C-3871] (#7635) nicoback2 [ef0b2cd] Fix single download (#7643) Raymond Jacobson [8c7d4cb] [ONC-27] Update collection cache reducer to add track uids to tracks in playlist_contents if not present (#7642) Kyle Shanks [8f47040] [C-3852] Fix android bottom bar button colors (#7641) Dylan Jeffers [edda3f5] Update mobile app versions (#7639) Raymond Jacobson [83a9654] Fix mobile typecheck (#7640) Sebastian Klingler [25d45fa] Use more transcode workers on larger machines (#7363) Steve Perkins [d4dab56] [PAY-2509] Bring lossless downloads mobile web up to spec (#7638) Reed [40dd9bb] Cascade delete on dashboard wallet users fkey (#7636) Isaac Solo [b9e2778] [C-3733] Update tiktok user api usage to v2 (#7610) Sebastian Klingler [bf4cd5f] [C-3842] Add feature flag for native TikTok auth (#7634) Sebastian Klingler [efdb27e] [ONC-28] Fix track tile icon size (#7631) Kyle Shanks [dff9ae4] Fix android downloads (#7633) Raymond Jacobson [19ca463] Drop dashboard wallet users blockhash fkey (#7629) Isaac Solo [b5812fa] Mirror orig upload in parallel (#7630) Steve Perkins [71368df] Fix mobile @audius/common auto imports (#7632) Sebastian Klingler [fe4eda3] Fix and clean up more lossless downloads issues (#7626) Saliou Diallo [9d38155] Fix mobile play icons (#7628) Dylan Jeffers [469bf40] Persist active task log (#7627) Isaac Solo [dc3aa8d] [PROTO-1665] DDEX: Add failure states, fix write scope, and clean up (#7619) Theo Ilie [dde01a7] Bump version to 0.6.39 audius-infra [f90880e] Bump mobile versions (#7625) Raymond Jacobson [f468dd1] ⚠️ [PAY-2493] Replace RNFetchBlob with ReactNativeBlobUtil (#7624) Raymond Jacobson [f244cd7] Make user bank indexer run ever 1s instead of 5 (#7623) Raymond Jacobson [e52515c] Upgrade ruby from 2.7 to 3.1.4 (#7622) Dylan Jeffers [3ae7cf5] Fix audius-cmd health check (#7621) Raymond Jacobson [3a9d4e2] [PAY-2503] Fix mobile crypto transfer purchase flow (#7620) Raymond Jacobson [f8232bb] Native Sign Up Various QA Fixes (#7607) JD Francis [336bab2] Set up protodash for Harmony use [C-3843] (#7614) nicoback2 [4e707b0] Revert [C-3561] Improve playback delay when playing track on mobile (#7616) Dylan Jeffers [8004f92] Fix modal styles and remove unused hooks (#7615) Dylan Jeffers [25a83fd] [PAY-2493] Upgrade RNFetchBlob to 0.13.0-beta.1 (#7617) Raymond Jacobson [fa33251] Add priority fee ixs to purchase txs (#7613) Reed [b6a58ab] [C-3833] Migrate modal to harmony (#7596) Dylan Jeffers [349e87c] Indexers fetch confirmed sol txs instead of finalized (#7612) Reed [862c9e6] [C-3821] Fix native double save (#7609) Dylan Jeffers [75925a9] Log active tasks and mem usage (#7611) Isaac Solo [b47ef80] Push protocol dashboard better (#7608) Raymond Jacobson [e3ecd49] [PAY-2492][PAY-2500] Add waitlist for premium downloads (#7603) Saliou Diallo [069ab6f] [PAY-2498] Fix multiple download warning in web (#7604) Raymond Jacobson [e26dd70] [ONC-9] Fix profile image display in old sign up flow (#7606) Kyle Shanks [f5b038d] Run dashboard job on client release (#7605) Raymond Jacobson [2efe8af] [C-3709 C-3814] Fix native text aligment issues (#7598) Dylan Jeffers [c8178da] [C-3812] Upgrade xcode from 14x to 15x, migrate to m1 (#7579) Dylan Jeffers [9c42c99] Fix armada project id (#7597) Raymond Jacobson [4677d86] relay log cleanup (#7601) alecsavvy [e109394] Dedupe tracks in album and fix broken import (#7599) Theo Ilie [de6750b] Bump version to 0.6.38 audius-infra [0cd31cf] [PROTO-1664] Replicate transcode result in parallel (#7593) Steve Perkins [23edd81] ⚠️ [ONC-19] Error on failed gas estimation (#7569) Raymond Jacobson [58fd090] [C-3811] Migrate popup to harmony (#7576) Dylan Jeffers [a22dc7a] rework relay selection (#7539) alecsavvy [7af96f0] PROTO-1646: fix app verify in relay (#7595) alecsavvy [c9c9244] Bypass errors on health check for autoheal (#7582) Isaac Solo [d7b9259] [PROTO-1661] Make ddex download from S3 and publish via Audius SDK (#7552) Michelle Brier [c213244] [Web] Fix red icon kebab horizontal icon [C-3829] (#7594) nicoback2 [acd8e5e] Fix follow-gated download row on web (#7592) Reed [97f9e12] [PAY-2467] Fix purchased flickering on own downloadable tracks (#7591) Reed [199a1a5] [PAY-2485][PAY-2483] Adds download Retry behavior for mobile (#7583) Randy Schott [8d509fc] [DVRL-5.1] - multisig node registration walkthrough (#7530) Sam Gutentag [01b9389] [C-3732] Update tiktok oauth calls in identity-service to v2 (#7585) Sebastian Klingler [570d049] [PAY-2458][PAY-2463][PAY-2474] Add lossless downloads edit flow and other fixes (#7590) Saliou Diallo [3bcf175] Bump version to 0.6.37 audius-infra [1fe3be6] Relax timeout for re-doing transcode (#7581) Steve Perkins [4ae791d] Fix ddex indexer excluding nested resources (#7572) Theo Ilie [494c66f] Patch decimal return type serialization (#7589) Raymond Jacobson [154e20c] Fix edit/delete track sagas (#7588) Dylan Jeffers [193f59e] Add time limit for payment router (#7587) Isaac Solo [d1d318b] [ONC-20] Fix sign on page saga for fetching suggested artists (#7586) Kyle Shanks [ca7ddf1] Fix spacing in Token docs (#7584) Sebastian Klingler [ad3a35e] Fix action-button alignment (#7578) Dylan Jeffers [f59e66a] [DVRL-15] - Connect Audius Account To Protocol Dashboard With MetaMask Guide (#7549) Sam Gutentag [cb4a82b] Rewrite USDCCard in harmony-native to fix android text (#7577) Reed [bf1887d] [PAY-2465] Fix contextual menu stems (#7570) Raymond Jacobson [36f8f09] [PAY-2478] Add overshoot clamping to drawer close (#7573) Raymond Jacobson [ce72ac5] [PAY-2468] Dedup filenames during download (#7563) Reed [ba2263b] [C-3769] Fix where condition for aggregate_user query. (#7575) Steve Perkins [f4a240e] Convert saved lineup sagas to ts (#7453) Kyle Shanks [813d7ce] Remove extra horizontal padding from SegmentedControl tabs (#7574) Randy Schott [030ce6a] [PAY-2472] Make USDCManualTransfer modal buy button actually buy (#7571) Raymond Jacobson [8ebc8cb] Bump version to 0.6.36 audius-infra [7029d77] Don't render InputAccessoryView on non-iOS platforms (#7568) Marcus Pasell [420e56e] [C-3666] Add autocomplete fields to new sign up/sign in fields (#7567) JD Francis [5598860] [C-3659] Float continue button above keyboard on native OTP (#7566) JD Francis [589ed01] [C-3561] Improve playback delay when playing track on mobile (#7267) Dylan Jeffers [8b2e00e] Fix native handle field floating on the wrong side (#7565) JD Francis [2575478] Upgrade native for full release (#7521) Dylan Jeffers [2be1ade] [C-3804 C-3794] Fix native icon colors and size (#7560) Dylan Jeffers [ff80da2] Uses selected DN node for trpc endpoint (#7562) Steve Perkins [57033a5] [PAY-2486] Change Email: Copy changes and current email screen on mobile (#7564) Marcus Pasell [fe284c2] [PAY-2414] Remove manual mime type specification for Android downloads (#7561) Randy Schott [00b4df5] Improve Connect MetaMask UX, esp. when both MetaMask and Phantom are installed [C-3750] (#7537) nicoback2 [fbc00f5] [PAY-2469] Always show file size for downloadable files (#7559) Reed [ce1ff59] [PAY-2482] Purchase details modal downloadable content UI (#7548) Reed [887e0c2] [Web][Harmony] Forward ref in Harmony IconButtob; Fix red kebab icon and too big tip tile close icon (#7553) nicoback2 [59b8df9] Migrate some buttons to Harmony [C-3751] (#7488) nicoback2 [4eec211] [PAY-2484] Ensure temporary download files are always deleted (#7554) Randy Schott [f560b22] Fix structured data (#7556) Sebastian Klingler [28c70fa] Patch trpc batching (#7555) Steve Perkins [85181d0] Fix rive-react-native for ios and android (#7551) Dylan Jeffers [88d4037] Bump version to 0.6.35 audius-infra

[skip ci] ## Changelog - 2024-02-29 [b9c440e] Test pt 3 [sliptype] - 2024-02-28 [63494e0] Use turbo to build sdk in release workflow [sliptype] - 2024-02-22 [21f5d8e] [DVRL-10] Ensure history uses track activity model (#7678) [Raymond Jacobson] - 2024-02-21 [fc4ead6] ⚠️ [PAY-2421] Upload stems in parallel (#7644) [Marcus Pasell] - 2024-02-21 [0c37ede] Revert "PROTO-1574: sepolia config and register all nodes" (#7667) [alecsavvy] - 2024-02-21 [51cdfd6] [DVRL-10] Add auth middleware sdk changes for history (#7663) [Raymond Jacobson] - 2024-02-21 [01563db] v1.5.67 [audius-infra] - 2024-02-20 [eaacf44] [PROTO-1667] Add DDEX sessions and admin+artist auth (#7645) [Theo Ilie] - 2024-02-20 [04bb965] PROTO-1574: sepolia config and register all nodes (#7648) [alecsavvy] - 2024-02-15 [fa33251] Add priority fee ixs to purchase txs (#7613) [Reed] - 2024-02-14 [23edd81] ⚠️ [ONC-19] Error on failed gas estimation (#7569) [Raymond Jacobson] - 2024-02-14 [a22dc7a] rework relay selection (#7539) [alecsavvy] - 2024-02-10 [8ecf162] v1.5.66 [audius-infra] - 2024-02-09 [d924e3d] [PAY-2464] Add access to purchases + sales endpoints (#7526) [Reed] - 2024-02-08 [85194b5] force reselection on relay 500s (#7529) [alecsavvy] - 2024-02-08 [328e805] [PAY-2450][PAY-2451] Purchase indexing uses access from memo (#7510) [Reed] - 2024-02-07 [4b39b68] ⚠️ [PAY-2387][PAY-2385] Web/Mobile Web: Change Email and Change Password (#7352) [Marcus Pasell] - 2024-02-05 [e513ff3] [PAY-2329] Use download_conditions in purchase flow (#7385) [Reed] - 2024-02-03 [42966c1] v1.5.65 [audius-infra] - 2024-02-02 [4140f4c] [PAY-2448] Exclude system USDC transactions by default (#7429) [Randy Schott] - 2024-02-01 [ba35a42] [PAY-2373][PAY-2406][PAY-2374] Support file sizes for stems / downloads (#7421) [Raymond Jacobson] - 2024-01-31 [3c898a8] Unbundle @audius/common (#7379) [Dylan Jeffers] - 2024-01-27 [6da6f9a] v1.5.64 [audius-infra] - 2024-01-24 [7b53f91] ⚠️ [INF-547] SSR Track Page (#7213) [Sebastian Klingler] - 2024-01-23 [439f10b] Add ChallengesApi, RewardManager to SDK (#7026) [Marcus Pasell] - 2024-01-23 [17f3a6c] [Web][Libs] QA for Link Audius Profile to Dashboard Wallet feature [C-3683] [C-3686] (#7283) [nicoback2] - 2024-01-20 [6a332ac] v1.5.63 [audius-infra] - 2024-01-19 [1599367] [PROTO-1598] Use tRPC in ddex (#7150) [Theo Ilie] - 2024-01-18 [2a15a64] v1.5.62 (#7243) [Dylan Jeffers] - 2024-01-17 [c3c2148] [Web] [Libs] Disconnect dashboard wallet - web and SDK changes (#7209) [nicoback2] - 2024-01-16 [ab1d3e9] Add USDC gated downloads flow (#6899) [Saliou Diallo] - 2024-01-14 [8d031a4] [PROTO-1599] Add OTP support (#7193) [Raymond Jacobson] - 2024-01-13 [39448b8] v1.5.61 [audius-infra] - 2024-01-12 [6e2927a] repairEntityManagerUserV2 (#7189) [Marcus Pasell] - 2024-01-12 [2b5cc0e] v1.5.60 (#7187) [Raymond Jacobson] - 2024-01-12 [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) [nicoback2] - 2024-01-12 [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) [nicoback2] - 2024-01-12 [60652a0] Fix top_listeners restx schema (#7157) [Steve Perkins] - 2024-01-11 [a0a5c01] rest endpoint for track top_listeners (#7139) [Steve Perkins] - 2024-01-09 [274bc9c] Support creating dashboard wallet user in SDK (#7106) [nicoback2] - 2024-01-06 [b9f0b43] v1.5.59 [audius-infra] - 2024-01-02 [7928e12] Improve sdk track upload logs (#7007) [Sebastian Klingler] - 2023-12-30 [8ae982c] v1.5.58 [audius-infra] - 2023-12-29 [8300ad0] [C-3550] Upgrade react native to 0.73.1 (#7042) [Dylan Jeffers] - 2023-12-29 [116a19a] [SDK] Fix validate ETH address util (#7043) [nicoback2] - 2023-12-28 [8c1e557] Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025) [Marcus Pasell] - 2023-12-28 [858da9f] [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039) [nicoback2] - 2023-12-28 [a2d87ca] [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033) [nicoback2] - 2023-12-27 [ad3f877] [C-3547] Upgrade eslint, typescript, and prettier (#7036) [Dylan Jeffers] - 2023-12-27 [dea3dfb] Run comms locally via audius-compose (#7028) [Marcus Pasell] - 2023-12-26 [44b99b6] Re-gen SDK for DashboardWalletUsers APIs (#7027) [nicoback2] - 2023-12-23 [daa5a9b] v1.5.57 [audius-infra] - 2023-12-22 [179ba8a] [SDK] Add dashboard wallet users API to SDK [C-3530] (#6971) [nicoback2] - 2023-12-21 [a002560] Fix sdk Storage retry logic (#7006) [Sebastian Klingler] - 2023-12-21 [500f9a7] Publish sdk and fix publish flow (#6995) [Sebastian Klingler] - 2023-12-20 [9eefe64] Revert "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7002) [Marcus Pasell] - 2023-12-20 [a542274] Add Solana Support to SDK with sdk.users.sendTip() (#6891) [Marcus Pasell] - 2023-12-19 [8967859] Fix sdk write w/ vite and fix npm publish (#6986) [Sebastian Klingler] - 2023-12-16 [7bb95df] v1.5.56 [audius-infra] - 2023-12-15 [7a8d979] Use retry logic for coinflow (#6957) [Marcus Pasell] - 2023-12-13 [b18a138] rm does_follow_current_user from API response (#6836) [Steve Perkins] - 2023-12-11 [7929dd0] [PAY-2128] Implement general coinflow scaffolding (#6847) [Raymond Jacobson] - 2023-12-11 [ab24471] Add memo for purchaser user id (#6846) [Reed] - 2023-12-09 [7e1dbfc] v1.5.55 [audius-infra] - 2023-12-08 [976b787] [PAY-2221] Purchase content through payment router (#6880) [Reed] - 2023-12-07 [f9de2f3] [INF-557] Convert libs to esm so vite HMR works (#6882) [Sebastian Klingler] - 2023-12-05 [9946c48] Payment router instructions in @audius/spl (#6862) [Reed] - 2023-12-05 [cd431cb] Fix typo in libs solana decimals constants (#6863) [Reed] - 2023-12-02 [f3398f6] v1.5.54 [audius-infra] - 2023-11-28 [00b0d25] Add Solana Relay to Discovery (#6782) [Marcus Pasell] - 2023-11-25 [e794c14] v1.5.53 [audius-infra] - 2023-11-20 [db88ed2] Fix electron w/ vite (#6747) [Sebastian Klingler] - 2023-11-18 [32514e5] v1.5.52 [audius-infra] - 2023-11-11 [d4d13e6] v1.5.51 [audius-infra] - 2023-11-09 [62de2d4] Update default RPCs (#6639) [Raymond Jacobson] - 2023-11-06 [fd12b98] [PAY-2091] Update aao error emojis and libs mapped error (#6593) [Saliou Diallo] - 2023-11-06 [6c473bb] ⚠️ [INF-507] Migrate from CRA to Vite (#6567) [Sebastian Klingler] - 2023-11-04 [41a3c27] v1.5.50 [audius-infra] - 2023-10-28 [f5cf244] v1.5.48 [audius-infra] - 2023-10-26 [76b14ce] [PAY-2041] Connect stripe session creation errors to analytics (#6465) [Randy Schott] - 2023-10-25 [3a176a2] Add fallbacks to SDK upload (#5970) [Theo Ilie] - 2023-10-21 [5c4aba5] v1.5.47 [audius-infra] - 2023-10-19 [785a815] [PAY-2060] Fix wrong challenge claimed so far amounts (#6398) [Reed] - 2023-10-18 [492a51a] [INF-484] Remove postinstall builds (#6381) [Sebastian Klingler] - 2023-10-17 [8cc5a64] [PAY-2009] Challenge cooldown UI (#6363) [Reed] - 2023-10-17 [741a0a6] Revert "Revert "[INF-498] Leverage turborepo cache in docker builds i… (#6365) [Sebastian Klingler] - 2023-10-16 [5162831] PROTO-1335: relay upload delay (#6281) [Alec Savvy] - 2023-10-14 [11fd490] v1.5.46 [audius-infra] - 2023-10-13 [5781951] [PAY-1886] Challenge cooldown: created_at migration + backend updates (#6326) [Reed] - 2023-10-12 [d133591] Fix audio balance error C-3207 C-3208 (#6317) [nicoback2] - 2023-10-12 [a384b2f] Revert "[INF-498] Leverage turborepo cache in docker builds in CI (#6… (#6320) [Isaac Solo] - 2023-10-11 [efd5ba7] [INF-498] Leverage turborepo cache in docker builds in CI (#6293) [Sebastian Klingler] - 2023-10-07 [7c00f48] v1.5.45 [audius-infra] - 2023-10-05 [faa348d] @audius/sdk: v3.0.11-beta.21 [audius-infra]

[skip ci] ## Changelog - 2024-02-29 [2738765] Use turbo for sdk release (#7748) [Sebastian Klingler] - 2024-02-28 [c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) [Michelle Brier] - 2024-02-26 [398db27] PROTO-1574: sepolia (#7698) [alecsavvy] - 2024-02-26 [beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) [Danny] - 2024-02-24 [5452dcb] v1.5.68 [audius-infra] - 2024-02-22 [21f5d8e] [DVRL-10] Ensure history uses track activity model (#7678) [Raymond Jacobson] - 2024-02-21 [fc4ead6] ⚠️ [PAY-2421] Upload stems in parallel (#7644) [Marcus Pasell] - 2024-02-21 [0c37ede] Revert "PROTO-1574: sepolia config and register all nodes" (#7667) [alecsavvy] - 2024-02-21 [51cdfd6] [DVRL-10] Add auth middleware sdk changes for history (#7663) [Raymond Jacobson] - 2024-02-21 [01563db] v1.5.67 [audius-infra] - 2024-02-20 [eaacf44] [PROTO-1667] Add DDEX sessions and admin+artist auth (#7645) [Theo Ilie] - 2024-02-20 [04bb965] PROTO-1574: sepolia config and register all nodes (#7648) [alecsavvy] - 2024-02-15 [fa33251] Add priority fee ixs to purchase txs (#7613) [Reed] - 2024-02-14 [23edd81] ⚠️ [ONC-19] Error on failed gas estimation (#7569) [Raymond Jacobson] - 2024-02-14 [a22dc7a] rework relay selection (#7539) [alecsavvy] - 2024-02-10 [8ecf162] v1.5.66 [audius-infra] - 2024-02-09 [d924e3d] [PAY-2464] Add access to purchases + sales endpoints (#7526) [Reed] - 2024-02-08 [85194b5] force reselection on relay 500s (#7529) [alecsavvy] - 2024-02-08 [328e805] [PAY-2450][PAY-2451] Purchase indexing uses access from memo (#7510) [Reed] - 2024-02-07 [4b39b68] ⚠️ [PAY-2387][PAY-2385] Web/Mobile Web: Change Email and Change Password (#7352) [Marcus Pasell] - 2024-02-05 [e513ff3] [PAY-2329] Use download_conditions in purchase flow (#7385) [Reed] - 2024-02-03 [42966c1] v1.5.65 [audius-infra] - 2024-02-02 [4140f4c] [PAY-2448] Exclude system USDC transactions by default (#7429) [Randy Schott] - 2024-02-01 [ba35a42] [PAY-2373][PAY-2406][PAY-2374] Support file sizes for stems / downloads (#7421) [Raymond Jacobson] - 2024-01-31 [3c898a8] Unbundle @audius/common (#7379) [Dylan Jeffers] - 2024-01-27 [6da6f9a] v1.5.64 [audius-infra] - 2024-01-24 [7b53f91] ⚠️ [INF-547] SSR Track Page (#7213) [Sebastian Klingler] - 2024-01-23 [439f10b] Add ChallengesApi, RewardManager to SDK (#7026) [Marcus Pasell] - 2024-01-23 [17f3a6c] [Web][Libs] QA for Link Audius Profile to Dashboard Wallet feature [C-3683] [C-3686] (#7283) [nicoback2] - 2024-01-20 [6a332ac] v1.5.63 [audius-infra] - 2024-01-19 [1599367] [PROTO-1598] Use tRPC in ddex (#7150) [Theo Ilie] - 2024-01-18 [2a15a64] v1.5.62 (#7243) [Dylan Jeffers] - 2024-01-17 [c3c2148] [Web] [Libs] Disconnect dashboard wallet - web and SDK changes (#7209) [nicoback2] - 2024-01-16 [ab1d3e9] Add USDC gated downloads flow (#6899) [Saliou Diallo] - 2024-01-14 [8d031a4] [PROTO-1599] Add OTP support (#7193) [Raymond Jacobson] - 2024-01-13 [39448b8] v1.5.61 [audius-infra] - 2024-01-12 [6e2927a] repairEntityManagerUserV2 (#7189) [Marcus Pasell] - 2024-01-12 [2b5cc0e] v1.5.60 (#7187) [Raymond Jacobson] - 2024-01-12 [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) [nicoback2] - 2024-01-12 [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) [nicoback2] - 2024-01-12 [60652a0] Fix top_listeners restx schema (#7157) [Steve Perkins] - 2024-01-11 [a0a5c01] rest endpoint for track top_listeners (#7139) [Steve Perkins] - 2024-01-09 [274bc9c] Support creating dashboard wallet user in SDK (#7106) [nicoback2] - 2024-01-06 [b9f0b43] v1.5.59 [audius-infra] - 2024-01-02 [7928e12] Improve sdk track upload logs (#7007) [Sebastian Klingler] - 2023-12-30 [8ae982c] v1.5.58 [audius-infra] - 2023-12-29 [8300ad0] [C-3550] Upgrade react native to 0.73.1 (#7042) [Dylan Jeffers] - 2023-12-29 [116a19a] [SDK] Fix validate ETH address util (#7043) [nicoback2] - 2023-12-28 [8c1e557] Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025) [Marcus Pasell] - 2023-12-28 [858da9f] [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039) [nicoback2] - 2023-12-28 [a2d87ca] [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033) [nicoback2] - 2023-12-27 [ad3f877] [C-3547] Upgrade eslint, typescript, and prettier (#7036) [Dylan Jeffers] - 2023-12-27 [dea3dfb] Run comms locally via audius-compose (#7028) [Marcus Pasell] - 2023-12-26 [44b99b6] Re-gen SDK for DashboardWalletUsers APIs (#7027) [nicoback2] - 2023-12-23 [daa5a9b] v1.5.57 [audius-infra] - 2023-12-22 [179ba8a] [SDK] Add dashboard wallet users API to SDK [C-3530] (#6971) [nicoback2] - 2023-12-21 [a002560] Fix sdk Storage retry logic (#7006) [Sebastian Klingler] - 2023-12-21 [500f9a7] Publish sdk and fix publish flow (#6995) [Sebastian Klingler] - 2023-12-20 [9eefe64] Revert "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7002) [Marcus Pasell] - 2023-12-20 [a542274] Add Solana Support to SDK with sdk.users.sendTip() (#6891) [Marcus Pasell] - 2023-12-19 [8967859] Fix sdk write w/ vite and fix npm publish (#6986) [Sebastian Klingler] - 2023-12-16 [7bb95df] v1.5.56 [audius-infra] - 2023-12-15 [7a8d979] Use retry logic for coinflow (#6957) [Marcus Pasell] - 2023-12-13 [b18a138] rm does_follow_current_user from API response (#6836) [Steve Perkins] - 2023-12-11 [7929dd0] [PAY-2128] Implement general coinflow scaffolding (#6847) [Raymond Jacobson] - 2023-12-11 [ab24471] Add memo for purchaser user id (#6846) [Reed] - 2023-12-09 [7e1dbfc] v1.5.55 [audius-infra] - 2023-12-08 [976b787] [PAY-2221] Purchase content through payment router (#6880) [Reed] - 2023-12-07 [f9de2f3] [INF-557] Convert libs to esm so vite HMR works (#6882) [Sebastian Klingler] - 2023-12-05 [9946c48] Payment router instructions in @audius/spl (#6862) [Reed] - 2023-12-05 [cd431cb] Fix typo in libs solana decimals constants (#6863) [Reed] - 2023-12-02 [f3398f6] v1.5.54 [audius-infra] - 2023-11-28 [00b0d25] Add Solana Relay to Discovery (#6782) [Marcus Pasell] - 2023-11-25 [e794c14] v1.5.53 [audius-infra] - 2023-11-20 [db88ed2] Fix electron w/ vite (#6747) [Sebastian Klingler] - 2023-11-18 [32514e5] v1.5.52 [audius-infra] - 2023-11-11 [d4d13e6] v1.5.51 [audius-infra] - 2023-11-09 [62de2d4] Update default RPCs (#6639) [Raymond Jacobson] - 2023-11-06 [fd12b98] [PAY-2091] Update aao error emojis and libs mapped error (#6593) [Saliou Diallo] - 2023-11-06 [6c473bb] ⚠️ [INF-507] Migrate from CRA to Vite (#6567) [Sebastian Klingler] - 2023-11-04 [41a3c27] v1.5.50 [audius-infra] - 2023-10-28 [f5cf244] v1.5.48 [audius-infra] - 2023-10-26 [76b14ce] [PAY-2041] Connect stripe session creation errors to analytics (#6465) [Randy Schott] - 2023-10-25 [3a176a2] Add fallbacks to SDK upload (#5970) [Theo Ilie] - 2023-10-21 [5c4aba5] v1.5.47 [audius-infra] - 2023-10-19 [785a815] [PAY-2060] Fix wrong challenge claimed so far amounts (#6398) [Reed] - 2023-10-18 [492a51a] [INF-484] Remove postinstall builds (#6381) [Sebastian Klingler] - 2023-10-17 [8cc5a64] [PAY-2009] Challenge cooldown UI (#6363) [Reed] - 2023-10-17 [741a0a6] Revert "Revert "[INF-498] Leverage turborepo cache in docker builds i… (#6365) [Sebastian Klingler] - 2023-10-16 [5162831] PROTO-1335: relay upload delay (#6281) [Alec Savvy] - 2023-10-14 [11fd490] v1.5.46 [audius-infra] - 2023-10-13 [5781951] [PAY-1886] Challenge cooldown: created_at migration + backend updates (#6326) [Reed] - 2023-10-12 [d133591] Fix audio balance error C-3207 C-3208 (#6317) [nicoback2] - 2023-10-12 [a384b2f] Revert "[INF-498] Leverage turborepo cache in docker builds in CI (#6… (#6320) [Isaac Solo] - 2023-10-11 [efd5ba7] [INF-498] Leverage turborepo cache in docker builds in CI (#6293) [Sebastian Klingler] - 2023-10-07 [7c00f48] v1.5.45 [audius-infra] - 2023-10-05 [faa348d] @audius/sdk: v3.0.11-beta.21 [audius-infra]

[ONC-19] Error on failed gas estimation

879c8b7

pull-request-size bot added the size/M label Feb 13, 2024

Fix up

0bc51c2

raymondjacobson requested a review from nicoback2 February 13, 2024 02:59

nicoback2 reviewed Feb 14, 2024

View reviewed changes

nicoback2 approved these changes Feb 14, 2024

View reviewed changes

PR comments

20f7518

raymondjacobson merged commit 23edd81 into main Feb 15, 2024
33 checks passed

raymondjacobson deleted the rj-gas-estimation-fixes branch February 15, 2024 00:03

raymondjacobson added a commit that referenced this pull request Feb 15, 2024

⚠️ [ONC-19] Error on failed gas estimation (#7569)

4527431

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ [ONC-19] Error on failed gas estimation #7569

⚠️ [ONC-19] Error on failed gas estimation #7569

raymondjacobson commented Feb 13, 2024 •

edited

Loading

audius-infra commented Feb 13, 2024

nicoback2 Feb 14, 2024

raymondjacobson Feb 14, 2024

nicoback2 Feb 14, 2024

nicoback2 Feb 14, 2024

nicoback2 Feb 14, 2024

raymondjacobson Feb 14, 2024

nicoback2 Feb 14, 2024

raymondjacobson Feb 14, 2024

nicoback2 Feb 14, 2024

raymondjacobson Feb 14, 2024

nicoback2 Feb 14, 2024

nicoback2 left a comment

audius-infra commented Feb 14, 2024

⚠️ [ONC-19] Error on failed gas estimation #7569

⚠️ [ONC-19] Error on failed gas estimation #7569

Conversation

raymondjacobson commented Feb 13, 2024 • edited Loading

Description

How Has This Been Tested?

audius-infra commented Feb 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nicoback2 left a comment

Choose a reason for hiding this comment

audius-infra commented Feb 14, 2024

raymondjacobson commented Feb 13, 2024 •

edited

Loading