Add ddex_app field for ddex tracks/playlists to discovery #7734

michellebrier · 2024-02-28T10:30:16Z

Description

Discovery keeps track of ddex apps via a new audius_ddex_apps envvar (configured in audius-docker-compose).

Upon playlist/track create, the indexer sets the ddex_app field if the tx signer is in this audius_ddex_apps list.

When indexing playlist/track updates/deletes, if the ddex_app field is truthy, discovery only applies the change if the tx signer matches ddex_app. This way only sdk writes from DDEX nodes should be successfully indexed. Caveat is when setting up a new DDEX node, we'll need to manually add it to the discovery audius_ddex_apps envvar in audius-docker-compose until we build some sort of proper UI / indexing / persisting for this.

Later on we can add client changes greying out edit buttons for DDEX tracks using this ddex_app field.

How Has This Been Tested?

Untested until stage DDEX starts actually publishing via sdk... but shouldn't affect normal activity on the app until then.
Will sanity check on a stage node before merging.

audius-infra · 2024-02-28T10:38:21Z

Preview this change https://demo.audius.co/mbrier/proto-1683/metadata-uneditable

theoilie

looks good!

audius-infra · 2024-02-29T06:26:35Z

Preview this change https://demo.audius.co/mbrier/proto-1683/metadata-uneditable

audius-infra · 2024-02-29T07:09:47Z

Preview this change https://demo.audius.co/mbrier/proto-1683/metadata-uneditable

[skip ci] ## Changelog - 2024-02-29 [2738765] Use turbo for sdk release (#7748) [Sebastian Klingler] - 2024-02-28 [c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) [Michelle Brier] - 2024-02-26 [398db27] PROTO-1574: sepolia (#7698) [alecsavvy] - 2024-02-26 [beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) [Danny] - 2024-02-24 [5452dcb] v1.5.68 [audius-infra] - 2024-02-22 [21f5d8e] [DVRL-10] Ensure history uses track activity model (#7678) [Raymond Jacobson] - 2024-02-21 [fc4ead6] ⚠️ [PAY-2421] Upload stems in parallel (#7644) [Marcus Pasell] - 2024-02-21 [0c37ede] Revert "PROTO-1574: sepolia config and register all nodes" (#7667) [alecsavvy] - 2024-02-21 [51cdfd6] [DVRL-10] Add auth middleware sdk changes for history (#7663) [Raymond Jacobson] - 2024-02-21 [01563db] v1.5.67 [audius-infra] - 2024-02-20 [eaacf44] [PROTO-1667] Add DDEX sessions and admin+artist auth (#7645) [Theo Ilie] - 2024-02-20 [04bb965] PROTO-1574: sepolia config and register all nodes (#7648) [alecsavvy] - 2024-02-15 [fa33251] Add priority fee ixs to purchase txs (#7613) [Reed] - 2024-02-14 [23edd81] ⚠️ [ONC-19] Error on failed gas estimation (#7569) [Raymond Jacobson] - 2024-02-14 [a22dc7a] rework relay selection (#7539) [alecsavvy] - 2024-02-10 [8ecf162] v1.5.66 [audius-infra] - 2024-02-09 [d924e3d] [PAY-2464] Add access to purchases + sales endpoints (#7526) [Reed] - 2024-02-08 [85194b5] force reselection on relay 500s (#7529) [alecsavvy] - 2024-02-08 [328e805] [PAY-2450][PAY-2451] Purchase indexing uses access from memo (#7510) [Reed] - 2024-02-07 [4b39b68] ⚠️ [PAY-2387][PAY-2385] Web/Mobile Web: Change Email and Change Password (#7352) [Marcus Pasell] - 2024-02-05 [e513ff3] [PAY-2329] Use download_conditions in purchase flow (#7385) [Reed] - 2024-02-03 [42966c1] v1.5.65 [audius-infra] - 2024-02-02 [4140f4c] [PAY-2448] Exclude system USDC transactions by default (#7429) [Randy Schott] - 2024-02-01 [ba35a42] [PAY-2373][PAY-2406][PAY-2374] Support file sizes for stems / downloads (#7421) [Raymond Jacobson] - 2024-01-31 [3c898a8] Unbundle @audius/common (#7379) [Dylan Jeffers] - 2024-01-27 [6da6f9a] v1.5.64 [audius-infra] - 2024-01-24 [7b53f91] ⚠️ [INF-547] SSR Track Page (#7213) [Sebastian Klingler] - 2024-01-23 [439f10b] Add ChallengesApi, RewardManager to SDK (#7026) [Marcus Pasell] - 2024-01-23 [17f3a6c] [Web][Libs] QA for Link Audius Profile to Dashboard Wallet feature [C-3683] [C-3686] (#7283) [nicoback2] - 2024-01-20 [6a332ac] v1.5.63 [audius-infra] - 2024-01-19 [1599367] [PROTO-1598] Use tRPC in ddex (#7150) [Theo Ilie] - 2024-01-18 [2a15a64] v1.5.62 (#7243) [Dylan Jeffers] - 2024-01-17 [c3c2148] [Web] [Libs] Disconnect dashboard wallet - web and SDK changes (#7209) [nicoback2] - 2024-01-16 [ab1d3e9] Add USDC gated downloads flow (#6899) [Saliou Diallo] - 2024-01-14 [8d031a4] [PROTO-1599] Add OTP support (#7193) [Raymond Jacobson] - 2024-01-13 [39448b8] v1.5.61 [audius-infra] - 2024-01-12 [6e2927a] repairEntityManagerUserV2 (#7189) [Marcus Pasell] - 2024-01-12 [2b5cc0e] v1.5.60 (#7187) [Raymond Jacobson] - 2024-01-12 [a021a74] [Web][SDK] Send EM transaction from Audius client for connect wallet feature (previously reviewed) (#7186) [nicoback2] - 2024-01-12 [c8efc84] [Discovery] Allow `wallet_signature` message in CreateDashboardWalletUser tx metadata to contain user handle (#7173) [nicoback2] - 2024-01-12 [60652a0] Fix top_listeners restx schema (#7157) [Steve Perkins] - 2024-01-11 [a0a5c01] rest endpoint for track top_listeners (#7139) [Steve Perkins] - 2024-01-09 [274bc9c] Support creating dashboard wallet user in SDK (#7106) [nicoback2] - 2024-01-06 [b9f0b43] v1.5.59 [audius-infra] - 2024-01-02 [7928e12] Improve sdk track upload logs (#7007) [Sebastian Klingler] - 2023-12-30 [8ae982c] v1.5.58 [audius-infra] - 2023-12-29 [8300ad0] [C-3550] Upgrade react native to 0.73.1 (#7042) [Dylan Jeffers] - 2023-12-29 [116a19a] [SDK] Fix validate ETH address util (#7043) [nicoback2] - 2023-12-28 [8c1e557] Reland "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7025) [Marcus Pasell] - 2023-12-28 [858da9f] [SDK] Export DashboardWalletUsersAPI + types in SDK index file, add missing param (#7039) [nicoback2] - 2023-12-28 [a2d87ca] [SDK] Have DashboardWalletUsers extend generated dashboard wallet users API (#7033) [nicoback2] - 2023-12-27 [ad3f877] [C-3547] Upgrade eslint, typescript, and prettier (#7036) [Dylan Jeffers] - 2023-12-27 [dea3dfb] Run comms locally via audius-compose (#7028) [Marcus Pasell] - 2023-12-26 [44b99b6] Re-gen SDK for DashboardWalletUsers APIs (#7027) [nicoback2] - 2023-12-23 [daa5a9b] v1.5.57 [audius-infra] - 2023-12-22 [179ba8a] [SDK] Add dashboard wallet users API to SDK [C-3530] (#6971) [nicoback2] - 2023-12-21 [a002560] Fix sdk Storage retry logic (#7006) [Sebastian Klingler] - 2023-12-21 [500f9a7] Publish sdk and fix publish flow (#6995) [Sebastian Klingler] - 2023-12-20 [9eefe64] Revert "Add Solana Support to SDK with sdk.users.sendTip() (#6891)" (#7002) [Marcus Pasell] - 2023-12-20 [a542274] Add Solana Support to SDK with sdk.users.sendTip() (#6891) [Marcus Pasell] - 2023-12-19 [8967859] Fix sdk write w/ vite and fix npm publish (#6986) [Sebastian Klingler] - 2023-12-16 [7bb95df] v1.5.56 [audius-infra] - 2023-12-15 [7a8d979] Use retry logic for coinflow (#6957) [Marcus Pasell] - 2023-12-13 [b18a138] rm does_follow_current_user from API response (#6836) [Steve Perkins] - 2023-12-11 [7929dd0] [PAY-2128] Implement general coinflow scaffolding (#6847) [Raymond Jacobson] - 2023-12-11 [ab24471] Add memo for purchaser user id (#6846) [Reed] - 2023-12-09 [7e1dbfc] v1.5.55 [audius-infra] - 2023-12-08 [976b787] [PAY-2221] Purchase content through payment router (#6880) [Reed] - 2023-12-07 [f9de2f3] [INF-557] Convert libs to esm so vite HMR works (#6882) [Sebastian Klingler] - 2023-12-05 [9946c48] Payment router instructions in @audius/spl (#6862) [Reed] - 2023-12-05 [cd431cb] Fix typo in libs solana decimals constants (#6863) [Reed] - 2023-12-02 [f3398f6] v1.5.54 [audius-infra] - 2023-11-28 [00b0d25] Add Solana Relay to Discovery (#6782) [Marcus Pasell] - 2023-11-25 [e794c14] v1.5.53 [audius-infra] - 2023-11-20 [db88ed2] Fix electron w/ vite (#6747) [Sebastian Klingler] - 2023-11-18 [32514e5] v1.5.52 [audius-infra] - 2023-11-11 [d4d13e6] v1.5.51 [audius-infra] - 2023-11-09 [62de2d4] Update default RPCs (#6639) [Raymond Jacobson] - 2023-11-06 [fd12b98] [PAY-2091] Update aao error emojis and libs mapped error (#6593) [Saliou Diallo] - 2023-11-06 [6c473bb] ⚠️ [INF-507] Migrate from CRA to Vite (#6567) [Sebastian Klingler] - 2023-11-04 [41a3c27] v1.5.50 [audius-infra] - 2023-10-28 [f5cf244] v1.5.48 [audius-infra] - 2023-10-26 [76b14ce] [PAY-2041] Connect stripe session creation errors to analytics (#6465) [Randy Schott] - 2023-10-25 [3a176a2] Add fallbacks to SDK upload (#5970) [Theo Ilie] - 2023-10-21 [5c4aba5] v1.5.47 [audius-infra] - 2023-10-19 [785a815] [PAY-2060] Fix wrong challenge claimed so far amounts (#6398) [Reed] - 2023-10-18 [492a51a] [INF-484] Remove postinstall builds (#6381) [Sebastian Klingler] - 2023-10-17 [8cc5a64] [PAY-2009] Challenge cooldown UI (#6363) [Reed] - 2023-10-17 [741a0a6] Revert "Revert "[INF-498] Leverage turborepo cache in docker builds i… (#6365) [Sebastian Klingler] - 2023-10-16 [5162831] PROTO-1335: relay upload delay (#6281) [Alec Savvy] - 2023-10-14 [11fd490] v1.5.46 [audius-infra] - 2023-10-13 [5781951] [PAY-1886] Challenge cooldown: created_at migration + backend updates (#6326) [Reed] - 2023-10-12 [d133591] Fix audio balance error C-3207 C-3208 (#6317) [nicoback2] - 2023-10-12 [a384b2f] Revert "[INF-498] Leverage turborepo cache in docker builds in CI (#6… (#6320) [Isaac Solo] - 2023-10-11 [efd5ba7] [INF-498] Leverage turborepo cache in docker builds in CI (#6293) [Sebastian Klingler] - 2023-10-07 [7c00f48] v1.5.45 [audius-infra] - 2023-10-05 [faa348d] @audius/sdk: v3.0.11-beta.21 [audius-infra]

[73c35e5] Bump mobile app version for full-app release (#7770) Dylan Jeffers [fa9c7ce] [PAY-2490] Delete backfill txs tables (#7768) Reed [acf5840] Fix reset-password-modal icon + ui (#7769) Dylan Jeffers [cb9c022] [C-3929] Fix select-artist genres (#7765) Dylan Jeffers [709ff70] Fix reset password (#7767) Marcus Pasell [1c1474e] [C-3708] Fix wallet text clipping issue in withdrawals table (#7762) Kyle Shanks [7f4b187] Add an isNativeMobile prop to amplitude (#7766) JD Francis [4f6972f] [PAY-2527] Return `playlists_containing_track` from track apis (#7764) Andrew Mendelsohn [dbc6dc1] Fix download buttons erroneously displaying (#7763) Reed [8cf2464] [PAY-2531] Grant access to stream track if user has purchased album (#7753) Reed [762a9ac] [C-3926] Add error helper text to new sign in password field (#7761) Kyle Shanks [6d6117f] [C-3885] Migrate to harmony text-link (#7746) Dylan Jeffers [82dd8c5] Update dapp-store build artifacts audius-infra [1c554c6] [C-3924] Fix misc font/type issues on purchase flow (#7760) Raymond Jacobson [b695203] [C-3923] Remove double badges on purchase flow (#7759) Raymond Jacobson [e1dd6e0] [PAY-2488] Remove stripe option from purchase flow (#7755) Raymond Jacobson [4931acb] Bump version to 0.6.50 audius-infra [c8eaa02] [C-2928] Add auth request signing middleware to sdk (#7724) Raymond Jacobson [0d2d3b1] Add verifier checks to discovery relay (#7756) Raymond Jacobson [c3f0a99] useHarmonyField (#7514) Marcus Pasell [ce226e7] Publish harmony to npm (#7751) Sebastian Klingler [d5c0c98] [C-3897] Fix ai-attribution dropdown (#7754) Dylan Jeffers [26f9c7d] [PAY-2533] Index album purchases (#7735) Andrew Mendelsohn [375f5b5] [C-3888] Add header-shadow to sign-up-screen (#7750) Dylan Jeffers [dbbbc88] @audius/sdk: v3.0.35 audius-infra [5125501] [DRVL-16] - Documentation Site Updates (#7699) Sam Gutentag [2738765] Use turbo for sdk release (#7748) Sebastian Klingler [23072cd] [C-3918] Fix wallet and dev-apps icons (#7749) Dylan Jeffers [a4bbe1c] Update stem limit to 20 (#7745) Raymond Jacobson [f4863c6] Fix social sign ups redirecting unintentionally (#7744) JD Francis [557142b] Disable play button if all collection tracks deleted (#7743) Saliou Diallo [5f28d5d] Add others to skip otp (#7741) Raymond Jacobson [b33bc5b] Add download gated column (#7742) Saliou Diallo [9f0f84e] Bump version to 0.6.49 audius-infra [c2a9c46] Add ddex_app field for ddex tracks/playlists to discovery (#7734) Michelle Brier [c932495] [PROTO-1686] Setup DDEX choreography infra and related improvements (#7739) Theo Ilie [aec57f9] Misc sign up social fixes (#7737) JD Francis [682a384] [ONC-35] Fix crash on android due to react native importing images as numbers (#7738) Marcus Pasell [273be01] Misc Sign up fixes (spacing & page swipe animation) (#7736) JD Francis [cb39083] [ONC-34] Fix bug in mobile suggested collection tracks (#7731) Saliou Diallo [8db7400] [C-3866] Update placement of theme reset in mobile sign out to make colors display properly (#7728) Kyle Shanks [0d15ae7] [C-3898] Fix faded gray screen android on sign up (#7730) JD Francis [a0d314b] Bump version to 0.6.48 audius-infra [f43e956] [PROTO-1513] Add e2e ddex test (#7733) Theo Ilie [f5ad4c3] Fix harmony ssr (#7732) Dylan Jeffers [06af9d2] [C-3909] Fix upload track challenge copy (#7729) Saliou Diallo [8f73c19] [C-3899] Fix android able to go back on signup (#7727) JD Francis [d04b4bc] [PAY-2529] Index album stream_conditions (#7720) Reed [8966f88] [QA-779][QA-704] Fix some UI issues (#7725) Saliou Diallo [d29c83f] Misc Sign Up QA Fixes (#7722) JD Francis [90b098a] Discovery placement hosts (#7718) Steve Perkins [9674780] Bump version to 0.6.47 audius-infra [398db27] PROTO-1574: sepolia (#7698) alecsavvy [40583e6] Improve search analytics (#7696) Isaac Solo [3e1b544] Add env linter (#7697) Raymond Jacobson [5a3498c] [DVRL-11] Move client history requests to sdk (#7679) Raymond Jacobson [beb054b] Remove all usage of PROTOCOL_DIR env var (#7714) Danny [6230eca] [PAY-2528] is_stream_gated + stream_conditions on Playlist (#7717) Reed [4136985] [PAY-2524, PAY-2525, PAY-2526] Add collections_containing_track field to tracks (#7708) Andrew Mendelsohn [f25cc23] Fix the same typo in another spot (#7716) Theo Ilie [f51ccd8] [C-3858] Additional padding on select artists screen (#7715) JD Francis [9ff7262] [C-3858] Social sign on loading screen adjustments (#7710) JD Francis [4c3a35c] Fix typo breaking audius-compose push (#7713) Theo Ilie [74facea] Bump mobile versions for prod release (#7712) Dylan Jeffers [392bb21] Bump version to 0.6.46 audius-infra

pull-request-size bot added the size/M label Feb 28, 2024

michellebrier requested a review from theoilie February 28, 2024 10:33

theoilie approved these changes Feb 28, 2024

View reviewed changes

pull-request-size bot added size/L and removed size/M labels Feb 29, 2024

michellebrier added 3 commits February 28, 2024 22:07

Add ddex_app field for ddex tracks/playlists to discovery

3401d82

cleanup

88371b0

lint + fix typo

8bb4bbc

michellebrier force-pushed the mbrier/proto-1683/metadata-uneditable branch from f4bf9ef to 8bb4bbc Compare February 29, 2024 06:08

fix test

6403b2e

michellebrier merged commit c2a9c46 into main Feb 29, 2024
37 checks passed

michellebrier deleted the mbrier/proto-1683/metadata-uneditable branch February 29, 2024 07:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ddex_app field for ddex tracks/playlists to discovery #7734

Add ddex_app field for ddex tracks/playlists to discovery #7734

michellebrier commented Feb 28, 2024 •

edited

Loading

audius-infra commented Feb 28, 2024

theoilie left a comment

audius-infra commented Feb 29, 2024

audius-infra commented Feb 29, 2024

Add ddex_app field for ddex tracks/playlists to discovery #7734

Add ddex_app field for ddex tracks/playlists to discovery #7734

Conversation

michellebrier commented Feb 28, 2024 • edited Loading

Description

How Has This Been Tested?

audius-infra commented Feb 28, 2024

theoilie left a comment

Choose a reason for hiding this comment

audius-infra commented Feb 29, 2024

audius-infra commented Feb 29, 2024

michellebrier commented Feb 28, 2024 •

edited

Loading