-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C-4453] Fix notification email image and layout #8647
Conversation
|
8447c49
to
5643993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job, mind running a quick lint/lint:fix?
if (!user.creator_node_endpoint) { | ||
return null | ||
} | ||
const contentNodes = user.creator_node_endpoint.split(',') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
big yikes. nice. can you check if user has .cover_photo
and .profile_picture
? if they are coming from our api they should just full content-node urls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't think we have those, it's coming straight from the discovery DB
Lines 129 to 141 in 5643993
const userRows: UserResource[] = await dnDb | |
.select( | |
'users.user_id', | |
'users.handle', | |
'users.name', | |
'users.profile_picture_sizes', | |
'users.profile_picture', | |
'users.creator_node_endpoint' | |
) | |
.from('users') | |
.whereIn('user_id', Array.from(ids.users)) | |
.andWhere('is_current', true) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah word, yup this good then :)
[7343561] [PAY-2842][PAY-2780][PAY-3069] Fix authorized endpoints not supporting manager mode (#8646) Randy Schott [ddaa1b3]⚠️ Third Party Wallet Support [PAY-2949][PAY-2948][PAY-2950] (#8611) Marcus Pasell [c15f20d] Fix prod mediorum dockerfile to have keyfinder dependency (#8666) Michelle Brier [7fe9451] Fix solana-relay logging, fix eslint config (#8663) Marcus Pasell [a495f42] [C-4453] Fix notification email image and layout (#8647) Isaac Solo [2ceae28] Audio analysis: mediorum changes (#8536) Michelle Brier [15a34b3] [C-4353] Add recent searches to search v2 (#8615) Sebastian Klingler [0050b29] Fix sdk typecheck (#8656) Sebastian Klingler
Description
Notification emails look wonky because:
text-align
fixes.How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Ran with stage DN1. Confirmed layout looks good on web and mobile Chrome / Safari.