Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdk typecheck #8656

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix sdk typecheck #8656

merged 1 commit into from
May 30, 2024

Conversation

sliptype
Copy link
Contributor

Description

  • remove @types/cron because cron already ships with them

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@sliptype sliptype requested a review from alecsavvy May 30, 2024 17:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 30, 2024

⚠️ No Changeset found

Latest commit: 1893828

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

alecsavvy
alecsavvy approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@alecsavvy alecsavvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my b, thank you!

@sliptype sliptype merged commit 0050b29 into main May 30, 2024
5 of 6 checks passed
@sliptype sliptype deleted the sk-cron-types branch May 30, 2024 17:27
schottra added a commit that referenced this pull request May 30, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2842-manager-mode…
ff1dc8c 
…-pay-and-earn

* origin/main:
  [C-4353] Add recent searches to search v2 (#8615)
  [QA-1335] Fix embed for non-premium tracks (#8658)
  Upgrade mobile apps to .99 (#8655)
  Fix sdk typecheck (#8656)
  [C-4427] react-native-video rough POC (#8654)
  Small fix to static image imports (#8653)
  Version Packages (#8189)
  [C-4309] Add ssr metatags (#8649)
  Audius Protocol v0.6.115
  Move EditTrackForm to edit-track component directory (#8641)
  [C-4320] Add web mobile profile page for SSR (#8642)
  [QA-1330] Fix mobile track edit button (#8644)
  [QA-1325] Fix playing icon position (#8643)
audius-infra pushed a commit that referenced this pull request May 31, 2024
Audius Protocol v0.6.116
806938e 
[7343561] [PAY-2842][PAY-2780][PAY-3069] Fix authorized endpoints not supporting manager mode (#8646) Randy Schott
[ddaa1b3] ⚠️ Third Party Wallet Support [PAY-2949][PAY-2948][PAY-2950] (#8611) Marcus Pasell
[c15f20d] Fix prod mediorum dockerfile to have keyfinder dependency (#8666) Michelle Brier
[7fe9451] Fix solana-relay logging, fix eslint config (#8663) Marcus Pasell
[a495f42] [C-4453] Fix notification email image and layout (#8647) Isaac Solo
[2ceae28] Audio analysis: mediorum changes (#8536) Michelle Brier
[15a34b3] [C-4353] Add recent searches to search v2 (#8615) Sebastian Klingler
[0050b29] Fix sdk typecheck (#8656) Sebastian Klingler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecsavvy alecsavvy alecsavvy approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliptype @alecsavvy