Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA-1335] Fix embed for non-premium tracks #8658

Merged
merged 2 commits into from
May 30, 2024
Merged

[QA-1335] Fix embed for non-premium tracks #8658

merged 2 commits into from
May 30, 2024

Conversation

dharit-tan
Copy link
Contributor

@dharit-tan dharit-tan commented May 30, 2024 •
edited
Loading

Description

Add null-check for streamConditions on embed player (they are all js)

How Has This Been Tested?

Local web
track:
Screenshot 2024-05-30 at 3 22 21 PM
album:
Screenshot 2024-05-30 at 3 27 24 PM

@dharit-tan dharit-tan requested review from rickyrombo and sliptype May 30, 2024 19:19
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 782baac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dharit-tan dharit-tan merged commit 3fa7573 into main May 30, 2024
9 checks passed
@dharit-tan dharit-tan deleted the rt-fix-embed branch May 30, 2024 19:33
schottra added a commit that referenced this pull request May 30, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2842-manager-mode…
ff1dc8c 
…-pay-and-earn

* origin/main:
  [C-4353] Add recent searches to search v2 (#8615)
  [QA-1335] Fix embed for non-premium tracks (#8658)
  Upgrade mobile apps to .99 (#8655)
  Fix sdk typecheck (#8656)
  [C-4427] react-native-video rough POC (#8654)
  Small fix to static image imports (#8653)
  Version Packages (#8189)
  [C-4309] Add ssr metatags (#8649)
  Audius Protocol v0.6.115
  Move EditTrackForm to edit-track component directory (#8641)
  [C-4320] Add web mobile profile page for SSR (#8642)
  [QA-1330] Fix mobile track edit button (#8644)
  [QA-1325] Fix playing icon position (#8643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliptype sliptype sliptype approved these changes

@rickyrombo rickyrombo rickyrombo approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dharit-tan @rickyrombo @sliptype