Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update recovery email #8758

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Update recovery email #8758

merged 1 commit into from
Jun 10, 2024

Conversation

isaacsolo
Copy link
Contributor

@isaacsolo isaacsolo commented Jun 7, 2024

Description

Update recovery email design.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Ran on stage identity and confirmed recovery link works.

Copy link

changeset-bot bot commented Jun 7, 2024

⚠️ No Changeset found

Latest commit: c70699e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@isaacsolo isaacsolo requested a review from DejayJD June 7, 2024 16:41
Comment on lines +12 to +20
<!--[if mso]>
<style>
* {
font-family: sans-serif !important;
}
</style>
<![endif]-->
<!--[if !mso]><!-->
<!-- <![endif]-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could delete

<!-- Preview Text Spacing Hack : BEGIN -->
<div
style="display: none; font-size: 1px; line-height: 1px; max-height: 0px; max-width: 0px; opacity: 0; overflow: hidden; mso-hide: all; font-family: sans-serif;">
&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;&zwnj;&nbsp;
Copy link
Contributor

@DejayJD DejayJD Jun 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol thats a lot of nbsp, this could probably be css instead

Comment on lines +68 to +75
<!--[if gte mso 9]>
<xml>
<o:OfficeDocumentSettings>
<o:AllowPNG/>
<o:PixelsPerInch>96</o:PixelsPerInch>
</o:OfficeDocumentSettings>
</xml>
<![endif]-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: another comment that could go

Copy link
Contributor

@DejayJD DejayJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits!
I'm not sure how much you're manually editing these html templates but if it's mostly generated stuff, probably just disregard the nits

Comment on lines +334 to +339
<!--[if mso]>
<v:roundrect xmlns:v="urn:schemas-microsoft-com:vml" xmlns:w="urn:schemas-microsoft-com:office:word" href="#" style="height:48px;v-text-anchor:middle;width:420px;" fillcolor="#7e1bcc" stroke="f" arcsize="17%">
<w:anchorlock/>
<center style="white-space:nowrap;display:inline-block;text-align:center;color:#ffffff;font-weight:600;font-family:Inter,Arial,sans-serif;font-size:18px;">Reset My Password</center>
</v:roundrect>
<![endif]-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can delete

@isaacsolo
Copy link
Contributor Author

Just some nits! I'm not sure how much you're manually editing these html templates but if it's mostly generated stuff, probably just disregard the nits

thanks! yea all the html is pretty much the template 🤷‍♂️

@isaacsolo isaacsolo merged commit a4a910d into main Jun 10, 2024
11 checks passed
@isaacsolo isaacsolo deleted the is-update-recovery-email branch June 10, 2024 15:31
schottra added a commit that referenced this pull request Jun 11, 2024
…-gated-content

* origin/main: (42 commits)
  Improve listen count checking (#8784)
  [C-4512] Implement purchase vendor tracking (#8763)
  [QA-973] Fix top playlists (#8774)
  Fix monorepo verify (#8781)
  [C-4475] Consume MusicBadge on track/collection pages (#8779)
  [QA-1342] Fix default SSR tags (#8719)
  [Web][Mobile] Reapply "Display manager mode notifications" [C-4426] without rogue .env (#8778)
  [C-4484] Add NoResultsTile to new search page (#8772)
  [C-4485] Prevent category changes when there is no search query (#8770)
  Upgrade mobile apps to .101 (#8777)
  Revert "Display manager mode notifications" [C-4426] (#8775)
  [Notifications] Update bad snapshot (#8776)
  [QA-1288] Fix tip reactions on mobile (#8773)
  [Discovery] [Notifications] Push and email notifs for manager mode [PAY-2830] (#8622)
  Add small variant to web Harmony MusicBage (#8771)
  Update recovery email (#8758)
  Audius Protocol v0.6.122
  Audius Client (Web and Mobile) v1.5.84
  [C-4476] HarmonyNative MusicBadge component (#8765)
  [QA-1361] Fix audio-nfts playlist (#8764)
  ...
audius-infra pushed a commit that referenced this pull request Jun 11, 2024
[7852ecc] Improve listen count checking (#8784) Raymond Jacobson
[dfa3b62] [C-4512] Implement purchase vendor tracking (#8763) Raymond Jacobson
[d232cfe] [QA-973] Fix top playlists (#8774) Dylan Jeffers
[904e70c] Fix monorepo verify (#8781) Dylan Jeffers
[87e2f63] [Notifications] Update bad snapshot (#8776) nicoback2
[c3eaf37] [Discovery] [Notifications] Push and email notifs for manager mode [PAY-2830] (#8622) nicoback2
[a4a910d] Update recovery email (#8758) Isaac Solo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants