[C-4512] Implement purchase vendor tracking #8763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 10116465 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648675 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648676 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648677 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
| 11648681 | Triggered | Generic High Entropy Secret | 1c98290 | .env | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
isaacsolo
changed the title
dharit-tan
reviewed
Jun 11, 2024
| class PurchaseVendor(str, enum.Enum): | ||
| user_bank = "user_bank" | ||
| coinflow = "coinflow" | ||
|
|
There was a problem hiding this comment.
the USDC comes from the user bank not stripe. we can do this soon by adding,.. another memo heheh
dharit-tan
approved these changes
Jun 11, 2024
schottra
added a commit
that referenced
this pull request
Jun 11, 2024
…-gated-content * origin/main: (42 commits) Improve listen count checking (#8784) [C-4512] Implement purchase vendor tracking (#8763) [QA-973] Fix top playlists (#8774) Fix monorepo verify (#8781) [C-4475] Consume MusicBadge on track/collection pages (#8779) [QA-1342] Fix default SSR tags (#8719) [Web][Mobile] Reapply "Display manager mode notifications" [C-4426] without rogue .env (#8778) [C-4484] Add NoResultsTile to new search page (#8772) [C-4485] Prevent category changes when there is no search query (#8770) Upgrade mobile apps to .101 (#8777) Revert "Display manager mode notifications" [C-4426] (#8775) [Notifications] Update bad snapshot (#8776) [QA-1288] Fix tip reactions on mobile (#8773) [Discovery] [Notifications] Push and email notifs for manager mode [PAY-2830] (#8622) Add small variant to web Harmony MusicBage (#8771) Update recovery email (#8758) Audius Protocol v0.6.122 Audius Client (Web and Mobile) v1.5.84 [C-4476] HarmonyNative MusicBadge component (#8765) [QA-1361] Fix audio-nfts playlist (#8764) ...
audius-infra
pushed a commit
that referenced
this pull request
Jun 11, 2024
[7852ecc] Improve listen count checking (#8784) Raymond Jacobson [dfa3b62] [C-4512] Implement purchase vendor tracking (#8763) Raymond Jacobson [d232cfe] [QA-973] Fix top playlists (#8774) Dylan Jeffers [904e70c] Fix monorepo verify (#8781) Dylan Jeffers [87e2f63] [Notifications] Update bad snapshot (#8776) nicoback2 [c3eaf37] [Discovery] [Notifications] Push and email notifs for manager mode [PAY-2830] (#8622) nicoback2 [a4a910d] Update recovery email (#8758) Isaac Solo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to track the vendor for purchases. This will help us send e-mails that clarify whether a purchase was made through Coinflow or the user bank.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Purchased track and confirmed notification included vendor.