Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Grand Theft Auto Rage Protocol Class #544

Merged
merged 3 commits into from
Jun 7, 2020
Merged

Added Grand Theft Auto Rage Protocol Class #544

merged 3 commits into from
Jun 7, 2020

Conversation

Ruslan-700
Copy link
Contributor

For this request #517

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.8%) to 86.069% when pulling 4ac4c14 on Ruslan-700:v3 into 80e675a on Austinb:v3.

@coveralls
Copy link

coveralls commented Apr 25, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.07%) to 87.798% when pulling dc8c622 on Ruslan-700:v3 into 80e675a on Austinb:v3.

uilson
uilson suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@uilson uilson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add at least 2 tests to prove it is working. (if you don't know how, check the wiki section)
It did not work when I tried, it's unable to parse the response.

@Austinb
Copy link
Owner

Austinb commented May 3, 2020

@Ruslan-700 Got to have at least 2 tests like @uilson stated. Please commit them to this PR and will test and then merge if everything looks good.

@Austinb Austinb self-assigned this May 3, 2020
@Austinb Austinb self-requested a review May 3, 2020 18:22
Austinb
Austinb requested changes May 3, 2020
View reviewed changes
Copy link
Owner

@Austinb Austinb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need at least two tests using data from working servers.

uilson
uilson suggested changes May 9, 2020
View reviewed changes
Copy link
Contributor

@uilson uilson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To pass the Travis CI test, please fix the errors in the code indentation on the protocol.
You can see the errors in the Travis CI log.

@scrutinizer-notifier
Copy link

The inspection completed: 3 updated code elements

@stale
Copy link

stale bot commented Jun 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Marked as stale label Jun 6, 2020
@Ruslan-700 Ruslan-700 requested a review from Austinb June 7, 2020 07:25
@stale stale bot removed the Stale Marked as stale label Jun 7, 2020
@Austinb Austinb added this to the v3.0.16 milestone Jun 7, 2020
@Austinb Austinb merged commit 60a8140 into Austinb:v3 Jun 7, 2020
@Zorrototo Zorrototo mentioned this pull request Jul 7, 2020
Closed
@bumbummen99 bumbummen99 added the Enhancement This request does add something to the project. label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilson uilson uilson requested changes

@Austinb Austinb Austinb approved these changes

Assignees

@Austinb Austinb

Labels
Enhancement This request does add something to the project. Feature Request v3
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@Ruslan-700 @coveralls @Austinb @scrutinizer-notifier @uilson @bumbummen99