Update Security section links on Jetpack Dashboard (#10846)

* Update Security section links on Jetpack Dashboard * Remove failing tests
Automattic · Dec 6, 2018 · c824fae · c824fae
1 parent 22f9a68
commit c824fae
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 26 deletions.
diff --git a/_inc/client/at-a-glance/index.jsx b/_inc/client/at-a-glance/index.jsx
@@ -63,11 +63,11 @@ class AtAGlance extends Component {
 					settingsPath={ this.props.userCanManageModules ? '#security' : undefined }
 					externalLink={ this.props.isDevMode || ! this.props.userCanManageModules
 						? ''
-						: __( 'Manage security on WordPress.com' )
+						: __( 'Manage security settings' )
 					}
 					externalLinkPath={ this.props.isDevMode
 						? ''
-						: 'https://wordpress.com/settings/security/' + this.props.siteRawUrl
+						: '#security'
 					}
 					externalLinkClick={ trackSecurityClick }
 				/>;

diff --git a/_inc/client/components/dash-section-header/index.jsx b/_inc/client/components/dash-section-header/index.jsx
@@ -4,8 +4,6 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import classNames from 'classnames';
-import Gridicon from 'components/gridicon';
-import { translate as __ } from 'i18n-calypso';
 import analytics from 'lib/analytics';
 
 export class DashSectionHeader extends React.Component {
@@ -35,7 +33,6 @@ export class DashSectionHeader extends React.Component {
 	};
 
 	render() {
-		let settingsIcon;
 		let externalLink;
 		let children;
 
@@ -44,17 +41,6 @@ export class DashSectionHeader extends React.Component {
 			'jp-dash-section-header'
 		);
 
-		if ( this.props.settingsPath ) {
-			settingsIcon = (
-				<a className="jp-dash-section-header__settings" href={ this.props.settingsPath }>
-					<span className="screen-reader-text">
-						{ __( 'Settings', { context: 'Noun. Displayed to screen readers.' } ) }
-					</span>
-					<Gridicon onClick={ this.trackCogClick } icon="cog" size={ 16 } />
-				</a>
-			);
-		}
-
 		if ( this.props.externalLink ) {
 			externalLink = (
 				<a
@@ -81,7 +67,6 @@ export class DashSectionHeader extends React.Component {
 					<h2 className="jp-dash-section-header__name">
 						{ this.props.label }
 					</h2>
-					{ settingsIcon }
 				</div>
 				{ externalLink }
 				{ children }

diff --git a/_inc/client/components/dash-section-header/test/component.js b/_inc/client/components/dash-section-header/test/component.js
@@ -50,15 +50,6 @@ describe( 'DashSectionHeader', () => {
 
 		const wrapper = shallow( <DashSectionHeader { ...testProps } /> );
 
-		it( 'displays an icon for Security', () => {
-			expect( wrapper.find( 'Gridicon' ) ).to.have.length( 1 );
-		} );
-
-		it( 'the icon is linked to a section', () => {
-			expect( wrapper.find( 'a.jp-dash-section-header__settings' ) ).to.have.length( 1 );
-			expect( wrapper.find( 'a.jp-dash-section-header__settings' ).props().href ).to.be.equal( '#security' );
-		} );
-
 		it( 'there is an external link', () => {
 			expect( wrapper.find( 'a.jp-dash-section-header__external-link' ) ).to.have.length( 1 );
 			expect( wrapper.find( 'a.jp-dash-section-header__external-link' ).props().href ).to.be.equal( externalPath );