Update Security section links on Jetpack Dashboard

[joanrho]

Fixes #10687 and #10693

Changes proposed in this Pull Request:

1. Change the wording of the "Manage security on WordPress.com" text link to "Manage security settings"
2. Update destination of the above text link from https://wordpress.com/settings/security/SITE_URL (Calypso Settings) to SITE_URL/wp-admin/admin.php?page=jetpack#security (wp-admin Jetpack Settings)
3. Remove gear icon.

BEFORE

AFTER

Testing instructions:

• Check out this branch
• Run yarn build
• Visit the Jetpack dashboard in wp-admin on your Jetpack Sandbox site (or whatever site you're testing on)
• Ensure the changes reflect the above "After" mockup and that the text link "Manage security settings" links to the wp-admin Jetpack Security settings page.

Proposed changelog entry for your changes:

• Clarify and unify Security settings links on Jetpack Dashboard

[jetpackbot]

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: January 10, 2019.
Scheduled code freeze: January 3, 2019

Generated by 🚫 dangerJS

[joanrho]

Note to @Automattic/jetpack-crew when you're testing this — I'll need your help fixing the bug where the /wp-admin/admin.php?page=jetpack#security link jumps to the middle part of the page instead of just the top of the page.

[dereksmart]

@joanrho It looks there are tests that expect these to be there, which is why the PR is failing currently. You're going to need to remove these two tests for the PR to pass: https://github.com/Automattic/jetpack/blob/master/_inc/client/components/dash-section-header/test/component.js#L53-L60

You can run that test before you commit with the command yarn test-adminpage.

I'll need your help fixing the bug where the /wp-admin/admin.php?page=jetpack#security link jumps to the middle part of the page instead of just the top of the page.

I think this issue has come up before. If there isn't one already logged, can you please create a new one in the repo and we can take care of it in a separate PR?

[joanrho]

Thanks @dereksmart! Removed those tests.

I think this issue has come up before. If there isn't one already logged, can you please create a new one in the repo and we can take care of it in a separate PR?

Yep, it has, but the issue referenced the gear Gridicon, which we are now removing. Will open a fresh issue that we can address once we merge this one.

[jeherve]

It works well for me, although the jump to the middle of the page is confusing, as you mentioned.

[jeffgolenski]

Tested and works great.